New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1725, on October 1st, 2012, 11:37 PM »
rev 1725
(2 files, 1kb)

! The curse of the Last-Minute Tweak... Fixed padding and margins in media homepage. (Media.template.php, media.css)
Re: New revs
« Reply #1726, on October 2nd, 2012, 12:04 AM »
rev 1726
(2 files, 1kb)

! Shouldn't commit when I'm tired... Anyway -- restored some debug session changes and moved a hardcoded style to the media stylesheet. (Media.template.php, media.css)
Re: New revs
« Reply #1727, on October 4th, 2012, 06:46 PM »
rev 1727 -- the installer overhaul. Still got files left to commit, but nothing related to the installer I believe.
(9 files, 13kb)

! Fixed clean_cache() to properly handle sub-folders and delete them if they're emptied. (Subs-Cache.php)

! Fixed updateSettings()'s handling during install. (install.php, Load.php, Subs.php)

! Fixed database structure, got screwed up a bit last month. (install.sql)

! enableCompressedData was never set up at install time, despite all the related code. (install.php, install.sql)

! Settings.php file was being rewritten with superfluous linebreaks everywhere. (install.php)

! Fixed CSS cache file generation in install process, it was broken for multiple reasons. (install.php)

! Fixed 404 handling to support the new css and js cache folders. (QueryString.php)

* Overhauled installer design. It's looking quite a bit better now. (install.php, install.css)

* Moved language select box from header to first page's content area. Also fixed the JS to actually use sbox on it. (install.php)

* Improved the 'pass' test strings during install. (Install.language.php)
Re: New revs
« Reply #1728, on October 5th, 2012, 12:07 AM »Last edited on October 5th, 2012, 04:35 PM
rev 1728 -- more files left to commit -- but not too many actually! I'm getting close to a releasable alpha really...
(12 files, 2kb)

* Harmonized font-weight declarations to 400 and 700 instead of normal and bold. It's a tad shorter, and skinners really should learn to use weights by number rather than by name. It makes more sense in the end. Especially for the non-English population... I also updated section.css but need to clean it up first. (editor.js, install.css, extra.rtl.css, index.member.css, mana.css, media.css, report.css, up.css, zoom.css, Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

:edit: Had got the commit number wrong...
Re: New revs
« Reply #1729, on October 5th, 2012, 04:36 PM »
rev 1729
(3 files, 2kb)

* Tweaked default welcome page to look better with the current stylesheets.
  Ensured that InfoCenter wouldn't use any hardcoded styles because it wouldn't be too good on a generic template.
  Sidebar should have some bottom padding when it's at the bottom.
  Finished converting font weights.
  (InfoCenter.template.php, Welcome.template.php, sections.css)
Re: New revs
« Reply #1730, on October 5th, 2012, 09:54 PM »
rev 1730
(12 files, 4kb)

* Moved $txt['quickmod_confirm'] declaration to script.js, renamed it to $txt['generic_confirm_request'], and replaced everything everywhere... This is for that kind of cool simplification that I implemented cacheable language strings. :) Also simplified InTopicModeration strings. (ManageMail.php, Aeva-Foxy.php, Display.template.php, ManageMedia.template.php, Media.template.php, MessageIndex.template.php, Search.template.php, index.language.php, mediadmin.js, script.js, topic.js)

+ Added a confirm box to the thought removal button... After (as an admin) deleting several thoughts from wedge.org accidentally in the last few months, it was long overdue... (script.js)
Re: New revs
« Reply #1731, on October 6th, 2012, 02:15 PM »
rev 1731
(8 files, 7kb)

* Moved index.css's variables to common.css, so that they can be re-used in external files. I'll commit the slim version of index.css once I'm done with all the little tweaks. Also updated .postbg background declarations to use $post_bg and $post_bg2. Which I could have sworn I'd already done... (common.css, sections.css, Wine/extra.css)

* Moved oEditorStrings and ptxt to editor.js and post.js respectively... Now that's even cooler. Changed opt.message_ext_error_final to a local variable. (Class-Editor.php, Post.template.php, editor.js, post.js)

* .zoom-base should be a virtual, even its name implies it... (zoom.css)
Re: New revs
« Reply #1732, on October 6th, 2012, 03:01 PM »
rev 1732
(4 files, 1kb)

! Forgot to declare the @language keywords... Maybe I should assume that 'index' is always loaded anyway, at that point in the script..? (editor.js, post.js, topic.js)

- Duplicate CSS declaration. (Wine/extra.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1733, on October 7th, 2012, 04:14 PM »
(2 files, 2KB)

Revision: 1733
Author: arantor
Date: 07 October 2012 15:13:26
Message:
! Certain navigation links were hidden if the user was a guest, even if guests had the permission to do what the navigation menu was pointing to. (MessageIndex.php)

! Fixed some validation errors, thanks live! (Post.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Post.template.php
Re: New revs
« Reply #1734, on October 7th, 2012, 05:45 PM »
(3 files, 1KB)

Revision: 1734
Author: arantor
Date: 07 October 2012 16:45:02
Message:
! SMF bug 4870: incorrectly capitalised dates. In our case, if setlocale is used, trust the locale database as being correct (because it is likely to be correct). If setlocale is not used, trust the language strings we have for things. Interestingly, French already behaved this way anyway since the old option was already off in French. (Subs, index language file)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Re: New revs
« Reply #1735, on October 7th, 2012, 07:07 PM »
(1 file, 3KB)

Revision: 1735
Author: arantor
Date: 07 October 2012 18:06:27
Message:
! Hopefully fix my old bug related to DNS lookups, and introducing IPv6 support for it at the same time. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Re: New revs
« Reply #1736, on October 7th, 2012, 07:17 PM »
(1 file, 1KB, 1 line)

Revision: 1736
Author: arantor
Date: 07 October 2012 18:16:52
Message:
! Theoretically prevent mass duplication of language loading. Essentially when using a non-English language, by default there is a call to load English first so that missing strings don't cause errors. But in the admin search in particular, it calls multiple times - and since the previous load was not English, the subsequent call is for English. IOW, if the current call is a fallback call, don't bother if already loaded (since we would have hit English first anyway). This should not break anything else... (Load.php)
----
Modified : /trunk/Sources/Load.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1737, on October 9th, 2012, 02:25 PM »
rev 1737
(4 files, 3kb)

+ Added support for simple variables in skeleton blocks. Used these to make the bottom linktree code cleaner, giving control to the skeleton rather than a random block not related to the linktree at all. Please note that while I'm declaring the top linktree as <linktree />, it can just as easily be declared as <linktree:top /> (like in the Warm skeleton), as the default value is set to 'top'. (Load.php, Subs-Template.php, index.template.php, Warm/skin.xml)

* Modified param order in RSS feed declaration, to match the other meta tags'. Also removed a few globals that weren't used at all, and $shown_linktree (same reason). (index.template.php)
Re: New revs
« Reply #1738, on October 11th, 2012, 10:47 PM »
rev 1738
(8 files, 9kb)

+ Added wetem::move() method, which allows you to move a template block from one place to another. It had the usual target parameters: select a layer or block, and select a position relative to it (basically: add (equivalent of 'last'), first, before and after.) (Subs-Template.php)

+ Added <move> command to skin.xml files, where you can invoke the wetem::move with this setting: <move block="block_name" to="target_layer_or_block" where="after" />. You can use the params in any order you want, I should probably rewrite my other mini-parsers to do the same because it's more flexible... No? Regarding Load.php, I'm not too happy I had to postpone the move() call to it, but right now it's the only way it can be done. Maybe later if I rewrite the entire wetem object to manipulate the skeleton string instead of the skeleton array, it can be done nicely... (Load.php, Subs-Cache.php)

* Wine will now show the linktree above and below the sidebar, rather than next to it. Yes, that's the reason I wrote the above method... (Wine/skin.xml)

! Tons of little fixes/tweaks to the main CSS, such as the padding button on IE6/7 buttons, .bbc_img needing a max-width of 100% rather than 650px, and padding tweaks. (index.css)

* Also several tweaks to Wine, most notably in responsive mode, and linktree paddings. (Wine/extra.css)

! And another responsive fix for Warm this time... (Warm/extra.css)

! Fixed menu alignment, linktree styling and responsive sidebar styling in Wuthering. (Wuthering/extra.css)

@ Known issue: recent changes to the skin system have been bad for IE... Even IE9 doesn't like the new Wuthering (hasn't for some time). Responsive modes are pretty broken, too... I'll probably need to go for a negative margin hack for them.

@ Known issue: if you access the 'Current Theme' page in the admin area, if you're not using Weaving it will use a mix between Weaving and your skin... Which is odd. It's only on that page, though. We need to find a solution for this... Anyone, any idea? That's in Themes.php, function SetThemeSettings.
Re: New revs
« Reply #1739, on October 13th, 2012, 06:42 PM »
rev 1739
(7 files +1, 7kb)

+ Added a $radius CSS variable to help change the overall page's border radius more easily. (common.css, index.css, Wuthering/extra.css)

* Warm layout was off by a couple of pixels in old IEs due to a lack of cellspacing param. (index.template.php, Warm/skin.xml)

* Several tweaks to Wuthering to make it cooler... In my opinion at least. What do I know. (Wuthering/extra.css, Wuthering/extra.ie[-9].css)

+ Added a funny styling for Wuthering linktrees. I don't know if you'll like it. I may even remove it in the future. But I worked on it for a day, tweaking it bit by bit, so at least it deserves even a temporary commit... (Wuthering/extra.css, images/theme/tria.gif)

- Debug code. (Wine/skin.xml)

@ Note: the extra linktree code adds less than 200 bytes to a gzipped css file... I think it's acceptable.