New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1695, on September 19th, 2012, 04:47 AM »
(4 files, 9KB)

Revision: 1695
Author: arantor
Date: 19 September 2012 03:47:02
Message:
! Added permissions management directly from the plugin files. (plugin-info.rng, ManagePermissions.php, ManagePlugins.php, Reports.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/other/plugin-info.rng
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1696, on September 19th, 2012, 10:46 AM »
rev 1696
(2 files, 4kb)

* There are times in life when it's time to say it's okay. So, it's okay to commit my Aeva changes, even if I can't for the life of me remember the logic behind them (I do remember, however, the need I had to fix autolink and protection bugs). So, it's a major simplification of the protection process, I don't know if it's going to create new bugs, but it's been in use at wedge.org for many months and I haven't seen anyone complain, so let's say it's all right. I'll deal with the aftermath later. Or just revert. (Aeva-Embed.php, Subs-BBC.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1697, on September 19th, 2012, 03:27 PM »
(2 files, 2KB)

Revision: 1697
Author: arantor
Date: 19 September 2012 14:27:28
Message:
! Stupid bug in permissions code when there aren't any enabled plugins. (ManagePermissions.php, Reports.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1698, on September 19th, 2012, 06:05 PM »
rev 1698
(5 files -1, 5kb)

* hasBrowser() now supports any $browser['is_*'] variable, including the OS ones. You can also freely add spaces between the brackets. Finally, added a $browser['is_mobile'] that reflects $user_info['is_mobile']. Use it with care, especially in skin files! It's not a toy. (Load.php)

! In some situations, CSS cache files could start with a dash (most likely, a bot trying to access your forum). I felt an urge to have this heresy cleaned up. (Subs-Cache.php)

* Cleaned up IE 6/7 to add their short custom crap directly to common.css instead of an extra file. Actually, I think I already cleaned up these files before and forgot to update the main one... Anyway, something interesting: as @is is run before most of the other Wess plugins, you can include root-level classes in a test that's inside a non-root element... How cool is that? No? Please? (common.css)

* Restored use of average() for menu gradients, this time for IE 6-8 instead of IE 9... How silly. (index.css)

* Replaced selectbox buttons with box shadows in IE9. It's always better than a PNG image... (index.css)

* More minor cleanup. (extra.firefox.css, extra.ie10.css, extra.iphone.css)
Re: New revs
« Reply #1699, on September 20th, 2012, 07:23 PM »
rev 1699
(6 files, 2kb)

* Another update that stayed in my local install for a long time... Overhauled the search page UI to go from 'quite ugly' to 'watchable'. Many changes, although in the end most of it is under the hood, I guess. (Search.php, Search.template.php, Search.language.php, index.french.php)

* Just adding an extra comment to the macro area in the index template... I believe it's needed to explain what it does in this case. (index.template.php)
Re: New revs
« Reply #1700, on September 21st, 2012, 06:02 PM »
rev 1700
(9 files -2, 5kb)

* Wine now uses a minor hack to switch the sidebar position, removing the need to provide a new skeleton in the skin file, as well as updated macros. You can still view sample macros and skeletons in the Warm skin, which is pretty much there precisely for that reason... Also updated Warm and Wuthering to react correctly. If you look closely, you'll see that Wuthering redefines #sidebar but this is needed, as currently Wess will remove items from classes listed in @remove, regardless of whether there are other classes using them. Rewriting Wess any other way would make it way too complex. Finally, wanted to say that since Warm redefines the HTML layout it won't react to it properly anyway, it should be repositioned slightly differently. I've indicated how in an extra.css comment as well. (Wine/extra.css, Wine/skin.xml, Warm/extra.css, Warm/skin.xml, Wuthering/extra.css)

- Are IE6/7/8 users really worth showing a subtle gradient in select box buttons...? Would they even notice it? No, I don't think so. That saves us about 100 gzipped bytes per CSS file. (select_arrow_bg.gif, select_arrow_bg_hover.gif, extra.ie[-8].css)

! Shortened clearfix for IE 6/7. While not exactly critical here, I've still decided to write a proper version... And it's shorter than for other browsers, for once. Also, fixing clearfix additions that were badly handled -- for some reason, they were using spaces instead of tabs. (common.css, extra.ie6.css, extra.ie7.css)

* Now using box shadows instead of gradients for Wine headers. They're too small to have any strong impact on browser rendering performance, I'd say. Also fixing inline blocks in responsive layouts. (Wine/extra.css)
Re: New revs
« Reply #1701, on September 22nd, 2012, 03:39 PM »
rev 1701 -- the cleanup rev, + @if at last! I'm seeing the end of the tunnel!
(4 files, 9kb)

+ Added @if function to Wess. The difference with @is is in the syntax: "@is (test, true, false)" can be done inline (so basically it's an @inlineif), while "@if test" is on its own line, and should be followed by an @endif on the same tab level, with a potential @else in between. This should allow for cleaner tests. And just like @is, they're nestable. Replaced a few @is calls with @if. (Class-CSS.php, common.css, index.css)

* Made more functions stricter when it comes to whitespace (i.e. not accept linebreaks within their declarations): rgb(a), hsl(a), gradient, @import, @charset, @mixin, mixes, properties, reset, virtual, unextends (extends was already done this way), final, @remove, @dynamic, @ifnull, @is and @if. Also on variable declarations, which made me realize that their regex is a bit flaxed, someone please remind me to rework it. (Class-CSS.php)

@ Note: I've compiled a before/after version and the result is the same, so it's probably bug-free.

+ Added more support for @is and @if to manage variables, but it's still not built in. The idea is to call the plugin twice: once before the mixins, to do the globals, and once after, to deal with local variables mostly. And no, this isn't ready yet. Dunno if it'll even be ready before the first release. (Class-CSS.php)

* Some cleaner code in the media quota edit page. (ManageMedia.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1702, on September 22nd, 2012, 05:07 PM »
(3 files, 7KB)

Revision: 1702
Author: arantor
Date: 22 September 2012 16:02:20
Message:
! Cleaner behaviour with respect to scheduled tasks in the event of a task being disabled, or if the installation moves folders/servers, by using the master folder listing rather than having the path in the DB. (ScheduledTasks.php, ManagePlugins.php)

! When disabling a plugin, check for any plugins that rely on the current plugin's hooks and refuse to disable it if any dependent plugins are found. (ManagePlugins.php, ManagePlugins language file)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php


For the first case, this should not be any problem for any current Wedge user. The only time there is an issue is if a plugin has declared a scheduled task - to the best of my knowledge, there are only two plugins that currently declare a scheduled task, and neither of them are in use anywhere (Birthdays, WedgeDesk). It does also mean that when declaring the filename in the plugin-info.xml file you no longer have to prefix it with $plugindir. I will commit the update to the Birthdays plugin for reference later.

For the second, there are still going to be fringe cases. If you were to enable, say, Dragooon's notification plugin and the notify-on-reply child plugin, you cannot safely disable notifications without disabling the child plugin. Now the manager will not let you disable the main plugin without disabling the child plugin first. You could, theoretically, still disable it by physically altering the folder, but to remedy that would require a vast extra overhead every single page, to check all plugins every page, which is unnecessary.
Re: New revs
« Reply #1703, on September 22nd, 2012, 05:28 PM »
(1 file, 1KB... it's literally one line)

Revision: 1703
Author: arantor
Date: 22 September 2012 16:11:32
Message:
! Oops, forgot to add the actual optional test. (ManagePlugins.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Re: New revs
« Reply #1704, on September 23rd, 2012, 08:00 PM »
(2 files, 3KB)

Revision: 1704
Author: arantor
Date: 23 September 2012 18:59:36
Message:
! Use proper note classes for the numbers within the PM menu area. Everywhere else does it, this should too. (PersonalMessage.php)

! The manage rules area needed some consistency attached to it, using buttons consistently rather than two links and a button. Some minor logic changes were needed to make it work but no biggie. (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/PersonalMessage.template.php

(Yes, a purely aesthetic commit from me. It doesn't happen often, either.)
Re: New revs
« Reply #1705, on September 23rd, 2012, 09:15 PM »
(6 files, 5KB)

Revision: 1705
Author: arantor
Date: 23 September 2012 20:14:49
Message:
! Spacinazi. (Profile-View.php, Register.template.php)

! Remove one of the remaining instances of string manipulation actually in a language file. (ManagePosts.php, Help language file)

! Update BB implementation to match 2.2.10 ruleset, notably updating MSN ranges and some extra URL checking that *shouldn't* cause any problems. (Security.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Re: New revs
« Reply #1706, on September 24th, 2012, 01:45 AM »
(13 files, 9KB)

Revision: 1706
Author: arantor
Date: 24 September 2012 00:45:00
Message:
! Removing yet another string concatenation that wasn't entirely necessary. (MoveTopic.php, ManageTopics language file)

! Not all instances of notice handler were styling things correctly. (GenericMenu.template.php)

! Converting pretend buttons into real buttons. (ManageBoards.template.php, ManageMembergroups.php, Admin.template.php)

! Juggling around the menu handling for manage members so that menu items are actually correct. This does generate a small side bug I will fix shortly in the admin search, well, more accurately it'll fix an edge case that's technically an SMF bug too. (Admin.php, ManageMembers.php, ManageMembers and Admin language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.french.php
Re: New revs
« Reply #1707, on September 24th, 2012, 02:06 AM »
(2 files, 2KB)

Revision: 1707
Author: arantor
Date: 24 September 2012 01:05:30
Message:
! SMF bug: if a subaction is declared in the admin menu and it is declared with a custom URL in the process, that will be ignored during the admin search processing all the menu contents. (Admin.php)

! Maintenance move boards in bulk had malformed tags, replaced the broken tags with the styling we're using elsewhere anyway. (ManageMaintenance.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Re: New revs
« Reply #1708, on September 24th, 2012, 03:56 AM »
(20 files, 2KB, simply removing lines is quite lean in SVN)

Revision: 1708
Author: arantor
Date: 24 September 2012 02:55:55
Message:
! Clean-up of duplicate strings in general. More to do, though. (ManageAttachments.php, ManageSmileys.php, Modlog.php, ManageBoards.template.php, ManagePaid.template.php, Packages.template.php, language files: Admin, ManageBoards, ManagePaid, ManageSmileys, Modlog, Packages, Profile)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1709, on September 24th, 2012, 09:48 AM »
rev 1709 -- easy to revert in case I change my mind for common.css... :)
(8 files, 2kb)

- Stopped including automatically common.css to all CSS cached files, just in case one would include a file in regular CSS format. (I'm committed to keep supporting these for plugins and custom themes, although I haven't tested this format in a long while...) You will now have to explicitly add 'common' to the array of files you're loading in case you want to use one of its virtuals (.inline-block, .clearfix etc.) Or just copy the virtuals into your own file, it's exactly the same to me... (Admin.php, Class-Editor.php, Packages.template.php -- yes, I know this one will end up being deleted...)

* Spacinazi. Thanks Pete for that reminder... (index.css)

* Translation. (ManagePlugins.french.php)
Plugin revs »