New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1635, on July 13th, 2012, 10:09 AM »
rev 1635 - the playlist commit
(4 files, 1kb) (must be buggy because the diff patch is 11KB! For rev 1634 it was 6KB...)

! Fixed playlists no longer working after the latest Foxy commit. (Aeva-Foxy.php)

! Fixed undefined variable when visiting a playlist page with at least one vote. (Aeva-Foxy.php)

! Fixed non-AeMe calls to Zoomedia generating undefined errors. (Aeva-Subs-Vital.php)

* Moved the rest of playlists' inline JavaScript to player.js. (Aeva-Foxy.php, player.js)

* Moved playlist and media item names to the category header. (Aeva-Foxy.php, Aeva-Gallery.php)
Re: New revs
« Reply #1636, on July 13th, 2012, 11:51 PM »
rev 1636
(14 files, 5kb, diff patch is 11kb, I need to let go of what svn tells me when committing...)

! Fixed a potential undefined index when the client doesn't have any headers specifying the requested host name. This certainly means it's a mischievous bot, but it should already have been stopped by Bad Behavior at this point, so no need to generate a regular error as well... In case it's a 'proper' query, rebuilding the host name from the default one. (Load.php)

! Fixed another undefined index error that would trigger when visiting a Media admin page with an outdated session ID. (ManageMedia.php)

- Removing some unneeded tab_data elements. (Admin.php, ManageMail.php, ManagePaid.php, ManagePermissions.php, ManageScheduledTasks.php, ModerationCenter.php, PackageGet.php, RepairBoards.php)

* If a file was shortened after an error was generated in it, and the error was near the end, Wedge would show nothing in the file viewer popup. Replacing this with a warning about the user being out of bounds. (ManageErrors.php, ManageMaintenance.language.php)

* Don't bother specifying a height for file viewer popups. Really, most browsers will behave and choose the best possible height. Except for IE, but I don't give a damn. (ManageErrors.php)

* Changed default windowbg colors for Weaving. I like change from time to time... (index.css)

* Chrome doesn't cooperate with box-sizing stuff. As far as I know, 0.4% * 2 + 49% < 50%, but it still would insist on showing just one column per row, instead of two. Decreasing the width by 0.1% helps it behave better. Meh. (index.css)

@ And I just discovered that TortoiseSVN, or RepoHosting, now allow editing any changelog's body or author... :) Used to refuse to let me do it!
Re: New revs
« Reply #1637, on July 14th, 2012, 10:49 PM »
rev 1637
(6 files, 3kb)

* Spacinazi and other details. (Class-Editor.php, index.css, sections.css)

+ Added an 'add_js_unique' helper function, which allows you to add a JS snippet multiple times while ensuring it's only printed once. Very useful for adding JS from a function we don't know how many times will be called. (Subs-Cache.php)

* Turned profile page's name back into a link. Although it's linking to the same page, at least we get the proper group color... (And I'm wary of re-introducing color fetching from the database. For now at least.) (Profile.template.php)

! Wrong color alignment in the stats page. (Stats.template.php)
Re: New revs
« Reply #1638, on July 14th, 2012, 10:50 PM »
rev 1638
(2 files, 8kb)

- Removed code tag's hack code from theme.js because I did some testing and couldn't find a single browser that had problems with these. I'll restore it if someone can provide me with a clean test case. (theme.js)

* Moved img.resized JS code to the img tag parser, and got rid of theme.js contents in the process, saving about 200 gzipped bytes from the main script file. (install.sql, theme.js)

* Replaced CRLF codes with simple Linux linefeeds in bbcode PHP. This should be just fine this way. (install.sql)

* Ensuring that the install script declares all auto-incremented IDs as unsigned. I don't even know if it's possible to manually insert a negative ID in these... Probably possible, but pointless. (install.sql)

* Started harmonizing field sizes in the database. For instance, id_member is mediumint(8) unsigned (I don't think there's any case where an id_member is stored as negative, even for a pseudo-member), things like that. (install.sql)

+ Added an id_media field to topics, for future use. (Yeah, don't have to be Einstein to get that one...) (install.sql)
Re: New revs
« Reply #1639, on July 18th, 2012, 08:36 PM »
rev 1639 (the bugfix commit)
(5 files, 2kb)

! Non-file cache systems (at least APC) were broken in Wedge because failed cached retrievals wouldn't be properly detected. (Subs-Cache.php)

! Navigating user posts would lead you to the wrong profile when visiting older pages. (Profile-View.php)

! Undefined index in voter visibility code (poll_votes_visible was used instead of poll_voters_visible.) (Poll.php)

! A couple of bugs with zlib.output_compression. (index.php, SSI.php)
Re: New revs
« Reply #1640, on July 19th, 2012, 12:53 AM »
rev 1640
(6 files, 3kb)

+ Added a we_board variable to board pages. Although it's less often used than we_topic, it's still worth adding it, if only for future plugins. (Display.template.php, index.template.php, Post.template.php, post.js, topic.js)

* Moved delete and submit strings to the generic JS code (instead of just the thought code), so that guests can always see them without having to load them twice. (index.template.php, script.js)
Re: New revs
« Reply #1641, on July 20th, 2012, 10:32 PM »
rev 1641 -- the Post commit. More to come... (Scary stuff.)
(2 files, 2kb)

! Post page didn't present current attachments in the right order. (Post.php)

! Post page ignored zero-byte attachments in some situations. (Post.php)

* Used the opportunity to simplify the current_attachments array and remove the deprecated 'approved' flag. At this point it's only an array because of the 'unchecked' boolean. (Post.php, Post.template.php)
Re: New revs
« Reply #1642, on July 20th, 2012, 11:21 PM »
rev 1642
(6 files, 11kb)

! SMF bug: there was some code to preview external avatars as they were entered, but the avatar preview was shown on a different tab, and thus invisible... Also fixed the JS to ensure that the image would load entirely before attempting to get its dimensions. A classic. (Profile.template.php)

* Rewrote keep-alive JS code to only trigger on textareas and WYSIWYG editors. Moved it to editor-func.js because I don't really see a reason to bother when it's a textarea lost in some far away admin area or something. Saves nearly 50 gzipped bytes off the main script. Laugh all you want about my optimizations, but that script is now easily a kilobyte shorter than months ago. (script.js, editor-func.js)

! Fixed reqWin popup auto-height in IE10. Well, at least the old Win7 preview. Not my fault if Microsoft wants to force us to use their crappy Win8. Hopefully it doesn't break other browsers or specific situations. (script.js)

* Simplified get/sendXMLDocument() functions. They should look less cryptic now. Also optimized script for size, as always... (script.js)

! Fixed WYSIWYG editor throwing errors at IE9. Which didn't happen before. Anyway, using feature detection instead of is_ie (even though is_ie8down would fix that.) (editor.js)

- Removed on-the-fly minification of JavaScript through the minify_html hidden variable. It's still available for tab removal, but minification was both slow and buggy. (Subs-Template.php)

* Remove stats.js into a singleton to save over 80 gzipped bytes compared to the latest version. (stats.js)
Re: New revs
« Reply #1643, on July 20th, 2012, 11:44 PM »
rev 1643
(52 files, 10kb) (more frightening than threatening, as the size implies.)

* Replaced these old "new Image().src" calls with $.get(). (upgrade.php, Load.php, ScheduledTasks.php, Subs-Scheduled.php, Admin.template.php, Themes.template.php)

* Moved blankGif() over to VerificationCode.php, as it was only used there at that point. (Subs.php, VerificationCode.php)

* It suddenly hit me that die() isn't an enticing function name, and I decided to replace them all with exit. Except for hacking attempts, because that's what they deserve. Or because I'm too lazy to change all of these for now. Next time I'll revert all of that to die() calls because it's "shorter", ah ah. Don't mind me. (index.php, install.php, a dozen of useless other/* files, smfinfo.php, upgrade.php, Ajax.php, Class-DB.php, Display.php, Dlattach.php, Errors.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Class-Media.php, Load.php, MessageIndex.php, QueryString.php, ScheduledTasks.php, Search2.php, Security.php, Spellcheck.php, Subs-Captcha.php, Subs-Scheduled.php, Subs-Sound.php, Subscriptions-PayPal.php, Themes.php, Unread.php, UnreadReplies.php, SSI.php, subscriptions.php)

* Some more minor JavaScript optimizations (mostly for size.) (install.php, a few more obscure other/* files, upgrade.php, Load.php, Display.template.php, Register.template.php, avasize.js)

* Spacinazi. Just the one line. (Stats.php, Subs-Media.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
New revs
« Reply #1644, on July 23rd, 2012, 02:34 AM »
(8 files, 3KB)

Revision: 1644
Author: arantor
Date: 23 July 2012 01:32:49
Message:
! Couple of miscellaneous grammar fixes. One of them even seems to have been mine. (ManageSettings.english.php)

! Add a checkbox, on by default, to show the feed block in the sidebar. Of course it won't show if feeds are disabled, but at least now it's optional. (index.php, install.sql, ManageNews.php, ManageSettings language file)

! Make password error logging be optional. (install.sql, Login2.php, ManageSettings.php, ManageSettings language file)

! Don't log certain user account errors as errors. So what if users are trying to register with reserved names? They get stopped at the door, but there's really no need to log that fact too. (Subs-Members.php)

! Sync BB implementation to BB 2.2.7. (Security.php)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1645, on July 24th, 2012, 12:41 PM »
rev 1645
(9 files, 4kb)

* Simplified weUrl() function by making it always use we_script as the base URL. The param is still optional so it doesn't save any gzipped bytes, but it's still better IMHO. (script.js)

* Replaced Ajax draft call tests with is_ajax instead of xml, allowing for some shorter JS. And getting rid of an annoying line of code. (PersonalMessage.php, Post2.php, editor-func.js)

* More byte saving: some getXMLDocument to $.get, referring to 'window.location' as just 'location'... (script.js, stats.js, suggest.js, topic.js)

! IE9 doesn't support border-radius on elements with a filter. Removed filter from .note classes because the solid border radius looks better than a square gradient. (index.ie9.css)

* French translation. (ManageSettings.french.php)
Re: New revs
« Reply #1646, on July 24th, 2012, 05:33 PM »
rev 1646
(16 files +2, 53kb -- most of this is the new files)

+ It would appear that I forgot to upload a couple of new files from when I split the splitter... (Split.php, Merge.template.php)

! Hopefully fixed a theme JS function that was incorrectly handling the script URL. (Themes.template.php)

* Harmonized all weUrl() calls to use the new param format. (Load.php, Admin.template.php, index.template.php, Packages.template.php, Themes.template.php, editor-func.js, editor.js, mediadmin.js, player.js, post.js, register.js, stats.js, suggest.js, topic.js, up.js)
Re: New revs
« Reply #1647, on July 24th, 2012, 11:10 PM »
rev 1647
(6 files +2-2, 9kb)

* Replaced boardstatus system with a single icon with different opacities according to the board type (on, off, redirect). This saves about a kilobyte off the main gzipped CSS file, and paves the way for custom board icons taken from the media area. Removed the legend because it sucked, and added titles to redirect board icons. Decided to get rid of the on/new differences because basically if a sub-board has new posts, a 'new' icon will show up for it anyway, no need to change the parent's status icon. (boardicon.png, boardstatus.png, boardstatus-ie6.png, Boards.template.php, MessageIndex.template.php, index.ie6.css, sections.css)

! Fixed a couple of bugs in the Groups page, which could cause a server crash and/or menu errors. Don't ask, I have no idea. (Groups.php, Subs.php)
Re: New revs
« Reply #1648, on July 28th, 2012, 11:49 AM »
rev 1648
(5 files, 4kb)

+ Added an internal rgb2hex function in WeCSS. It makes it easier to return a #rgb value for CSS while compressing it if possible (#fc9 instead of #ffcc99). (Class-CSS.php)

! It is with great sadness that I'm hereby forced to allow selectors to start with a digit, while it conflicts with the basics of CSS. It's not my fault that they allow these for @-keyframes declarations. (Class-CSS.php)

+ Added support for the 'fr' value (fraction) in the math() function. I doubt anyone will ever need to use math(2fr * 3fr), but whatever! (Class-CSS.php)

! Partially reverted rev 1143's IE9 fixes for gradients. While it did fix gradients, it also completely deleted rgba() declarations from IE9 files. The new fix should be the best of both worlds... (Class-CSS.php)

* Renamed signature_minposts language string to signature_needs_posts, to avoid conflicts in the admin search. (Profile-Modify.php, Profile.language.php)

! Fixed title icon alignment in Recent page. (Recent.template.php)
Re: New revs
« Reply #1649, on July 28th, 2012, 05:12 PM »
rev 1649
(6 files, 3kb)

* Cleaned up reqWin, removed desiredHeight and asWindow params which were no longer in common use. (Install.language.php, Packages.template.php, captcha.js, editor.js, script.js)

* Cleaned up weUrl() as well, removing the fallback for empty urls (if you need to get the URL with no param, just pass an empty string), and the extra test that made sure to add a semi-colon -- which, as far as my tests show, would never happen in any situation. (script.js)

* While doing a documentation search on something else, I noticed the $.now() function in jQuery. This compresses even better than '+new Date', which was my beloved trick for saving space compared to the ugly '(new Date()).getTime()' that jQuery also uses. Well, I can't rewrite jQuery (maybe I should!), so I'll have to use that, but if you don't use jQuery, try and remember to use '+new Date', because it rocks. (script.js)

@ BTW, the rgb2hex optimization from last rev saved nearly 20 gzipped bytes (about 60 non-gzipped), which was better than I hoped for. :)
Plugin revs »