New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1620, on June 15th, 2012, 08:36 PM »
rev 1620
(12 files, 5kb)

- Removed can_ajax -- if you really need this (it's so 2001), use $.support.ajax instead. It actually saves a whopping 29 bytes if gzipped script.js files, had I noticed earlier it'd be gone already... (upgrade.php, Class-Editor.php, Display.template.php, Post.language.php, Packages.template.php, Split.template.php, editor.js, register.js, script.js, suggest.js, topic.js)
Re: New revs
« Reply #1621, on June 17th, 2012, 05:26 PM »
rev 1621
(10 files, 4kb)

* Rewrote skin list processing to provide a more realistic tree, removed $level parameter, etc. (Themes.php, ManageBoards.template.php, Themes.template.php)

! wetem::$has_layer was set wrongly when providing an empty layer. Also documented wetem::layer(), FWIW. (Subs-Template.php)

+ Added variables to allow setting up custom fonts for blog posts. (sections.css)

! Not really fixable, but at east muted the dns_get_record error that could happen when visiting a profile on some servers. (Subs.php)

! Credits page was missing a linktree. (Credits.php)

* Linktrees had a bit too much space below them, I'd say... (index.css)

- Forgot to remove a setting after rewriting the group title hiding code. (Settings.template.php)

- Commenazi. (Aeva-Subs-Vital.php)
Re: New revs
« Reply #1622, on June 19th, 2012, 06:48 PM »
rev 1622
(8 files, 4kb)

! Fixed HTML error. (Display.template.php, PersonalMessage.template.php)

! nbsp isn't allowed in alert texts. Well, AFAIK. (Post.french.php)

- Removed iStart variable (no longer used.) Shortened related JS function by about 20 bytes. (Display.template.php, topic.js)

* Allow for multiple attachment selection... Although it's not implemented in core yet, adding it here is needed for the feature to work in Opera. Talk about a bug... (Post.template.php)

* Replaced appendTo with simple append calls. As odd as it may sounds, it saves about 10 bytes. (script.js)

* Simplified icon function. (post.js)

* Pixelnazi. (index.css)
Re: New revs
« Reply #1623, on June 20th, 2012, 01:15 PM »
rev 1623
(5 files, 3kb)

* Still not done with the UI, but in the meantime enjoy this one: in profile pages > account settings, membergroup selection is now showing you the badges you're going to get. It only works for badges that always show up or badges that show up depending on their status (primary or additional). For instance, if the admin group has a badge but it's set to show only if used as a primary group, then the primary group list shows an admin badge, and the additional group list doesn't. (Profile-Modify.php, Profile.template.php)

* A couple of attic files had an extra line break at the end of the file. Which isn't cool. (attic/*)

* Another popup tweak.. Never completely happy with it eh? (script.js)
Re: New revs
« Reply #1624, on June 21st, 2012, 05:42 PM »
rev 1624
(1 file, 1kb) <-- doesn't do justice to the time I spent on this :lol:

* Updated list of IP ranges per whois server for IP tracking. I s'pose no one's gonna go and check that I didn't do any mistakes, so I'll just say that the list will need to be updated as long as all ranges aren't assigned. (Profile-View.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
New revs
« Reply #1625, on June 24th, 2012, 01:00 AM »
(I cannot presently post to the main New Revs thread, so putting it here)

(14 files, 20KB)

Revision: 1625
Author: arantor
Date: 23 June 2012 23:59:34
Message:
! Allow admins, admins+thread creator, logged in members, or everyone to see who voted in a poll, and make that controllable from the poll creation. Note that by design it should not be possible to change who can see this, as it might otherwise influence voting. (install.sql, Display.php, Poll.php, Display.template.php, Post.template.php, Poll.template.php, Language files: Help, index, Post)

! Added param for reqWin to prevent reqWin automatically grabbing a title. It's hackish, I'm sorry, but I couldn't think of a better way of doing it than this without altering every single case where reqWin was invoked. I didn't check how much larger it made script.js when compressed either. (script.js)

! Rearranged the likes display in posts to move the number to the right of the action itself, and to make that a link to the popup showing who liked a post. In order to do this some style juggling had to occur. If this can be improved, please please do so. (index.php, Like.php, Display.template.php, index.css, sections.css, Language files: index)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/index.php
Modified : /trunk/other/install.sql

@ As discussed, this is not an 'I'm ba-aaaaack' commit. It's one that I did because it needed to be done and was annoying me that it had not been done yet. I consider it a WIP but I don't really know how to do some of it better. It may well be better just to revert bits of it and be done with it, but that's not really my call to me. Those who have source access, check it out and let me know.

@ This looks like a lot, but we're really talking about 6 hours work across three days. Nothing to even stress me out over.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1626, on July 1st, 2012, 12:26 AM »
rev 1626
(4 files, 4kb) -- getting back to work after a one-week holiday...

! Don't double-encode entities in safe page titles. Is that a good idea..? How to reproduce: go to an album page where the name of the album is a long word. 'Shy' should show up in the title... (Subs.php)

* French translation. (Help.french.php, index.french.php, Post.french.php)
Re: New revs
« Reply #1627, on July 4th, 2012, 05:19 PM »
rev 1627 -- hoping for some feedback about the new reqWin ;)
(11 files, 12kb)

* Rewrote the reqWin popup code. The world wasn't ready for a bottom-right aligned thingy. The new one is simpler, shorter and, admittedly, better. Support for IE (position fixed), iOS (ditto) and generally low-res devices is better, too. Things like noDrag are no longer needed, as the scrollbar is always in an undraggable area. Also saves 200+ bytes of gzipped code compared to the previous version. But you're used to that by now... (Display.php, Like.php, ManageAttachments.php, Display.template.php, Help.template.php, Packages.template.php, script.js, index.css, index.ie6.css, mana.css)

! Fixed select boxes showing squares instead of arrows in IE6. (index.ie6.css)

! Fixed fixed positioning for popups in iOS. (Not that's not a typo.) (index.iphone.css)

- Removed support for bottom-right alignments in dragslide because it takes space for nothing (I don't think anyone would use that outside of the earlier reqWin.) (script.js)
Re: New revs
« Reply #1628, on July 5th, 2012, 02:26 PM »
rev 1628 - a few more commits are coming up... I tried to split them by category.
(6 files, 5kb)

! Fixed error log's file viewer and made it use the Help template instead of a custom one. (ManageErrors.php, Errors.template.php)

! Fixed permission profile page in media area. Notably, empty values in option tags need to be replaced with data-hide. I think I should try harder and look at fixing these on the fly, really... (ManageMedia.php, ManageMedia.template.php)

+ Added an 'or' statement in the permission profile page to make it clear that you have a choice between two actions. (ManageMedia.php, ManageMedia.template.php, ManageMedia.language.php)
Re: New revs
« Reply #1629, on July 5th, 2012, 02:30 PM »
rev 1629 - the 'short' one.
(4 files, 2kb)

+ Added ability to specify a default display string in select boxes that isn't listed in the select box dropdown. Use data-default="string" in your select tag. (sbox.js)

! Fixed reqWin popup vertical position in iOS devices. Thank you Apple... (script.js)

! Fixed select boxes no longer showing up in IE6 and IE7. (index.template.php)

* Minor tweaks to the popup visuals. Optimized for size, too. By a couple of bytes uh... (index.css)
Re: New revs
« Reply #1630, on July 5th, 2012, 02:32 PM »
rev 1630 - the comfort commit.
(3 files, 2kb)

* The statistics page will now show days in reverse order, so that you can develop consecutive months and analyze daily stats in order without disruption. You know -- it's the kind of thing you never understand but use as is, and then one day you think, okay I'll just change that... (Stats.php)

* Ensuring that you can directly call add_js_file() for an external file without having to specify it's a direct URL -- this is because external files always have a :// in the URL. Well, I left the boolean in, just in case for some odd reason you need to call it with no protocol. (Subs-Cache.php)

* Switched membergroup name and badge positions in the profile account page. Cleaner this way. (Profile.template.php)
Re: New revs
« Reply #1631, on July 5th, 2012, 02:38 PM »
rev 1631 - the sizenazi commit. Final commit for now, will be back later with some Foxy new changes.
(9 files, 4kb)

* Replaced a str_replace with a preg_replace in the dynamic replacement code -- it pains me, but it starts with a long unchanging string so it should be nearly as fast, and it allows me to optimize a few places I didn't think of with closing and reopening script tags. (Subs-Template.php)

* Size optimizations. Removing "> 0" tests (and replacing == 0 with !) when we know the variable is an integer, or close enough. Hope I didn't screw up the selectionStart thing. Also, stats.js was never fully optimized to begin with. (editor-func.js, editor.js, post.js, spellcheck.js, stats.js, suggest.js, topic.js, zoomedia.js)

* Turned Zoomedia into a closure. I like those, didn't you notice...? (zoomedia.js)
Re: New revs
« Reply #1632, on July 10th, 2012, 06:07 PM »
I'm sorry for such a huge changelog, but today I'm not strong enough to separate my changes into thematic commits... At this point I'm only praying that I documented everything and didn't forget any features or files ;)

rev 1632
(23 files +2, 36kb)

* Rewrote reqWin even more, mostly to add background dimming behind the popup, and to simplify the code. For instance, because we no longer attach events to unrelated elements, there's no need to fix the event format or unbind some events. (script.js, index.css)

* Fade out the reqWin popup when closing it via the 'Close window' link as well. (Help.template.php)

! Fixed reqWin centering in iOS. (script.js)

! Fixed errors in media playlists, and made the player use Wedge caching. (Aeva-Foxy.php, player.js)

! Fixed swfobject embedding, and harmonized version to 2.2. (Aeva-Foxy.php, Aeva-Subs-Vital.php)

* Trying not to have too many actions in the index file, I moved displaylike to Like.php and used a sub-action for viewing likes. (index.php, Like.php, Display.template.php)

* Increased post box height from 175 to 250px. I was through resizing it by myself. I'm sure no one will mind and it may actually encourage posting more. (Post.php)

+ Added a polyfill for IE 6-8 to support media queries. It'll only support min-width and max-width which are the most common cases, but at least it'll be fast (and short) enough not to bother me too much. (Load.php, respond.js)

- No need to fill in a $no_resize variable when it's only useful once. Removing it does add some extra code to old IEs though, hopefully it won't make them go crazy. Yes, it's just a call to an empty function for resize(), but I've seen worse from them. (index.template.php)

- Label selects in PM pages actually don't need to be fixed. (PersonalMessage.template.php)

- According to my stats, Opera < 9.5 is used by less than 0.2% of web users. If I'm going to drop support for IE6 one day, and I sure will, I have to set an example even if it's my favorite browser... So, removed Wysiwyg detection for Opera < 9.5. Saves about 20 bytes overall. For everyone... (editor.js, script.js)

* In post pages, moved topic icons inside their select box, and moved topic title input box to the right of the icon select box. Makes more sense. (Post.template.php, post.js)

* More space-saving optimizations. Saves something like 70 gzipped bytes when added to script.js, yay. (sbox.js)

* Some space-saving on CSS as well. Unless I'm horribly mistaken, "margin: auto" is the same as "margin: auto". No need to use both. (index.css, index.ie6.css, sections.css)

* Shortened param code for weToggle. It actually saves a nice amount of bytes, and is still easy to understand. (TEMPLATES: Admin, Boards, Display, index, ManagePermissions, Packages, PersonalMessage, Post, SCRIPTS: post.js, script.js, stats.js)
Re: New revs
« Reply #1633, on July 11th, 2012, 11:45 AM »
rev 1633 -- the Zoomedia commit. :)
(7 files, 9kb)

! Rewrote Zoomedia's initialization routine to improve handling of titles and descriptions. Seriously, it was horribly broken. Plus, the new version is shorter by 150+ gzipped bytes. It's all in a day's work for Byte Repair Man. (zoomedia.js, zoom.css)

* Harmonized/simplified Zoomedia call code. (Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php)

* All attachment resizing is now done through Zoomedia rather than a window popup or the expandThumbs function. (Display.php, Display.template.php)

! Give access to hidden/forbidden user albums to users who have explicit permission to post in them. (Aeva-Gallery.php)

! Fixed centering of media items. (Aeva-Subs-Vital.php, Subs-Media.php)
Re: New revs
« Reply #1634, on July 13th, 2012, 10:08 AM »
rev 1634
(8 files, 4kb)

* Stripped tags from HTML-safe page titles. No longer generating this variable before it's really needed. (Subs-Template.php, Subs.php)

* Adjusting error log's code popup height. I'm not exactly sure why it didn't fit anymore... (ManageErrors.php)

* Adjusting height for PM post boxes as well. (PersonalMessage.php)

+ Added commas between voter names when polls allow to view them. (Display.template.php)

* Reverted the HTML validator to the good old URL, as they appear to have fixed their earlier issues. (index.template.php)

* Giving more breathing space to unordered lists. (index.css)

* Couple of bytes saved. (sbox.js)
Plugin revs »