New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1485, on March 19th, 2012, 12:49 PM »
rev 1485
(4 files, 5kb)

+ Added "Top liked posts" statistics to the Stats page. Yay. Nothing is cached for now, it's not out of complexity but because I'm not sure it's worth it. (Stats.php, Stats.template.php, Stats.language.php)

@NOTE: this was announced in rev 1481 but I forgot to check the files... Also, the icon won't show at all because it's linked to a CSS file change I have yet to document and commit. Sorry.
Re: New revs
« Reply #1486, on March 19th, 2012, 01:06 PM »
rev 1486
(3 files, 2kb)

! Fixed a few bugs in board modification with a Pretty URL set. There are still bugs left, but here are the fixes: Wedge was using id_cat instead of id_owner to determine the board owner (this was a leftover from the Noisen codebase), the URL generator was going through the topic generator codebase (meaning, mostly, that it accepted illegal characters), and board URLs containing an action name (such as /do or /admin) were being green-lit. (Subs-Boards.php, Subs-PrettyUrls.php)

! Don't accept any action in the board URL. Previously, it wouldn't accept direct action names, now it'll analyze any bit of the URL between potential slashes. (Subs-PrettyUrls.php)

* Added a safety to prevent people from creating a board URL that is a parent of a board owned by someone else, just like it currently prevents creating a child of these. Also, admins should be able to create whatever URL they want, regardless of board ownership. (Subs-PrettyUrls.php)

* Added space trimming in CSS selectors (dunno why I left these out?!), and slash trimming in board Pretty URLs. Y'never known. (Class-CSS.php, Subs-PrettyUrls.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1487, on March 20th, 2012, 02:33 AM »
(3 files, 1KB)

Revision: 1487
Author: arantor
Date: 20 March 2012 01:33:18
Message:
! Normally 'wrong password' errors are filed under 'user' but there's a bunch of other stuff that's also user errors which is really separate, so move 'failed password' errors to their own filter. (Errors.php, Login2.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Re: New revs
« Reply #1488, on March 20th, 2012, 04:35 PM »
(9 files, 14KB)

Revision: 1488
Author: arantor
Date: 20 March 2012 15:34:09
Message:
! Since we insist on a minimum of MySQL 5.1 on the server, we don't need 5.0.50/5.0.51 specific workarounds. (install.php, upgrade.php, Display.php, ScheduledTasks.php)
! Bit odd having a default of keeping error logs for 5 days but only clearing it out on a weekly basis. (ScheduledTasks.php)
! Mostly usable version of the BB log viewer. It's missing a few things but it works. It will also purge the BB log at the same time as purging the error log (and to a point I consider them both variations of 'error' anyway...) (Admin.php, ManageErrors.php, ScheduledTasks.php, Errors.template.php, Admin and ManageMaintenance language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/upgrade.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1489, on March 20th, 2012, 11:26 PM »
rev 1489
(9 files +2 -2, 15kb)

+ Added privacy icons. Yayz. And a Facebook link in the bottom, which is like the antithesis to privacy. Don't ask. (icons/privacy.png, other/images/privacy.png, Home.template.php, index.template.php, script.js, index.member.css)

+ Added an is_touch variable in JavaScript, which returns true for all devices with a touchscreen. Updated the select box to use that instead of is_iphone and is_tablet. (script.js, sbox.js)

* Non-mobile skins shouldn't force a viewport width on touch devices. So, instead of the browser detector, I'll be relying on the skin's mobile flag to change the viewport. Also, modified viewport values to zoom in a bit more. Seriously, it makes the pages even more readable, and without making look them too ugly. (index.template.php)

- Removed some old logos from the depository. (wedgelogo.png, wedgesight.png)

* 'Last auto saved' mention below textareas was a bit too large. (editor.css)

! Considering that if you import your site into Wedge, you will likely lose some images/icons that we don't use in Wedge, I'm removing Google Cache referrers from the list of 404 errors that should be logged. We should probably add a setting to disable 404 loggings entirely, or based on file extensions... Peeeete? :P (QueryString.php)

! Fixed a BBC parsing warning error that could be triggered in some situations, like the print-friendly page. (Subs-BBC.php)

! Fixed signatures getting lost outside of the page layout. Also moved moderatorbar and quick edit button CSS to member CSS, because I don't see why guests would need to access these. Would they? (sections.css, index.member.css)

@ Still have plenty of files to changelog. Coming tomorrow I think...
Re: New revs
« Reply #1490, on March 21st, 2012, 10:33 AM »
rev 1490
(2 files +3, 70kb) (including 69KB of image files ;))

! Google Cache and Tapatalk hits were being processed as PHP pages, instead of returning a 404 error and just being ignored in the log. (QueryString.php)

+ Added more exceptions to 404 error logging, mainly due to search bots spidering elements without revisiting HTML pages: cache folder files, and 'clear' avatar URLs. (QueryString.php)

+ Added protections to the Wireless skin folder. (Wireless/*)

+ Wuthering didn't have one of its fix files in the SVN. (Wuthering/index.member.css)

+ Added to the image attic what I believe are the original logos for webelow and webelowine. Also added webelow to the normal image folder. (other/images/webelow*.png, images/webelow.png)
Re: New revs
« Reply #1491, on March 21st, 2012, 11:07 AM »
rev 1491
(5 files, 3kb)

* Replaced $txt['reply_noun'] (even though this was added to the SMF codebase as per one of my bug reports ;)), because it's only used in one area, and replaced it with a $txt['reply_number'] entry that should be easier to customize (I'm still having Japanese in mind... but other languages might benefit from this.) (Display.template.php, index.language.php)

* Harmonized a bit more the PM template with topic posts. User box should no longer overflow inside the PM body, and some optimizations are also imported. (PersonalMessage.template.php)

* Because of the table to div switch, the birthday cake is no longer properly aligned with the age. And sure enough, had to wait until it was my birthday to notice that... So I just moved the cake below the age. Wait, wait... It's not a cake... It's a WEDGE of cake! (Profile.template.php)
Re: New revs
« Reply #1492, on March 21st, 2012, 11:19 AM »
rev 1492
(4 files +1, 5kb)

* The Quick Access select box can become crowded easily enough. Replaced the arrows by simple unbreakable spaces. Seriously, it's enough to differentiate between board levels... (script.js)

* French translation. (Admin.french.php, ManageMaintenance.french.php)

+ Yet another missing CSS file. (Wine/index.member.css)

! Forgot to commit updated Warm skin file, with the new name for the header macro ('banner', which makes more sense I think. We already have enough things called 'header' in Wedge.) (Warm/skin.xml)
Re: New revs
« Reply #1493, on March 21st, 2012, 03:02 PM »
rev 1493
(7 files -1, 4kb)

! Fixed postbg/windowbg confusion in several pages. Until we're ready to create a mini-skeleton for posts, the 'regular' post template will use postbg as its class, while 'mini' posts will use 'windowbg wrc core_posts' (Gesundheit!), which should fix most, if not all of the padding problems encountered on wedge.org since the beginning. (ModerationCenter.template.php, PersonalMessage.template.php, Post.template.php, Profile.template.php, Recent.template.php)

! The PM search feature's post list, perhaps because it is seldom viewed (you have to select Advanced search and tick a specific box?!), was an absolute mess that I had nothing to do with, ahah. Now it should be using something closer to the 'mini' post template. (PersonalMessage.template.php)

- Removed strong tags from create_button HTML. Not that this function is destined to stay (because it's barely even used any longer in Wedge), but at least it should be styled similarly to the rest of the forum... (Subs.php)

- Removed Worg empty folder, which I forgot to do. (skins/Worg)

* Detail. (index.french.php)
Re: New revs
« Reply #1494, on March 21st, 2012, 08:03 PM »
rev 1494
(9 files -1, 16kb)

! Fixed (hopefully!) no_board error that comes up in the error log when Bad Behavior catches someone trying to view a board. (Security.php)

* Changed my mind on main menu notifications. I figured that with the color code used, even a child would understand that the number is the amount of new items available. So, replaced $txt['new_short'] with numbers. (Subs.php)

* Saved a few bytes by optimizing select box background GIFs and replacing the arrow with a pure CSS triangle. (Interesting code to look at, I'd say.) It won't work in old IEs, and I don't care. (select_arrow_bg.gif, select_arrow_bg_hover.gif, select_arrow.gif, index.member.css)

* Updated Like buttons to make them narrower by one pixel. I'm a bit anal on these details. (quickbuttons-32bit.png, images/theme/quickbuttons.png)

! Reverted and fixed quick button icons. Used another method to access the Like icon for the Stats page. (sections.css)
Re: New revs
« Reply #1495, on March 22nd, 2012, 09:17 AM »
rev 1495
(3 files, 1kb)

! If the Media area is disabled, the Media menu in profiles should be disabled entirely. (Profile.php)

! Added a $section['id'] check in sidebar menus, just like in dropdown menus. This fixes the Media area bug we met on Wedge.org, although the fix above is cleaner. (GenericMenu.template.php)

* Translation tweak. (index.french.php)
Re: New revs
« Reply #1496, on March 22nd, 2012, 11:59 AM »
rev 1496
(1 file, 4kb)

+ Woohoo. Been wanting to do that one for a long time... Now, WeCSS will accept selector lists after the @remove command. Also accepts "@remove from ..." but you can skip the 'from', it's just for convenience. Will take comma-separated lists of selectors, surrounded by double quotes or not, or just a single selector, or even -- let's be crazy -- no selector at all, like before. Basically, if you don't specify a selector, the line will be removed everywhere it's found in the CSS files. If you specify a selector (or more), it will be removed everywhere the selector is declared, including places where the selector inherits or is inherited. Tested on a few items, works fine. I'm sure someone will find a way to break it soon enough, but give me some time to rejoice. Thank you. (Class-CSS.php)
Re: New revs
« Reply #1497, on March 22nd, 2012, 12:06 PM »
rev 1497
(2 files, 3kb)

* Added another exception to 404 errors: iOS requesting for an apple-touch-icon file, to use as a big icon if you ever bookmark a website to your 'desktop'. Since I don't think many people are providing that, it's best to just ignore it... (QueryString.php)

! Clicking the menu position's Toggle button would sometimes generate an error if Pretty URLs are enabled. (Subs-Menu.php)
Re: New revs
« Reply #1498, on March 22nd, 2012, 12:51 PM »
rev 1498
(10 files, 4kb) (that sounds small for such a large amount of changes to the CSS files...)

* Moved .two-columns and .upshrinks further up the CSS chain, so that it can safely be inherited. (index.css, sections.css)

* Slogan styling redone entirely. Instead of being shown on the right with some random font, it's now shown just after the website title, in the same font, slightly resized and recolored. Required quite a lot of CSS relative to what it does in the end, but it was required because #siteslogan was never really styled before in Wedge... Since I never used it. Oh, and inherited skins also use slightly different styles for slogans. Diversity is good. (index.css, Wine/index.css, Warm/index.css, Wuthering/index.css)

* Finally committing the CSS part of the select box arrow rewrite. As I said, it's pretty cool as it's a triangle. In CSS. (index.css)

* A few minor changes (at pixel level). (index.css)

* Changed windowbg colors in Warm because I always hated them. Reused those from Wine... (Warm/index.css)

* Wuthering looks best with the bright version of the logo. (Wuthering/index.css)

* Rewrote some variables. $menu_bg is renamed to $menu_gradient, IE 6/7/8 didn't need a fallback in the variable because long ago I restored it in the CSS itself to ensure the menu wouldn't be broken on obscure browsers. Cleaned up the variable list in Wine, because it was pretty much a duplicate of Weaving's... (index.css, Wine/index.css)

! Fixed margins when showing the auto-saved draft message. At least when you're using a larger resolution and can see the entire thing in a single line, it looks better now. (editor.css)

! Fixed .two-columns maximum width on IE 6/7/8/9. Can you spot the difference? Yeah, they all require different widths, ah ah... Gotta love IE. (index.ie*.css)

! Fixed thought list hovers in IE6. Hopefully. You want me to waste time checking that it works..?! (index.ie6.css)
Re: New revs
« Reply #1499, on March 22nd, 2012, 03:31 PM »
rev 1499
(3 files, 2kb)

* Added a post_shortcuts block to the Post template, which holds the list of keyboard shortcuts, and moved the post_buttons block before the options block, allowing for it to be properly aligned, since it's right-floated. (Post.php, Post.template.php)
* The main menu's admin menu should point to the Plugins page, rather than the (soon to be gone) Packages page. (Subs.php)