« User configurable CC email accounts
New revs
A new banning option? »

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1365 on February 19th, 07:51 PM »
rev 1365
(3 files, 6kb)

+ Added a new keyword for WeCSS. 'reset' will take the current select and remove it from earlier styles. It's different from '@remove' and 'unextends', and should be very helpful for inherited skins. This was a complicated implementation, too, one which could possibly be rewritten in a cleaner way if I parsed this before even building the CSS tree... I don't know what's best. Opinions?[1] (Class-CSS.php)

+ Added an unset_recursive function to quickly delete CSS selectors and their children. (Class-CSS.php)

* Made CSS tree parsing about 5 to 10% faster. (Class-CSS.php)

! Tahoma is not always installed on Linux. (index.css, Wine/index.css)
 1. Seriously, this is a feature I wanted to have from day one! Took me a whole day to get it right...
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1366 on February 20th, 12:23 AM »
rev 1366
(1 file, 1kb)

! Was a little too nice with Firefox and Safari... Firefox 12 still requires a prefix for box-sizing rules, and Safari did it until v5.0 (and iOS 4.3), which sort of warrants a de facto prefix for now. (Subs-Cache.php)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1367 on February 20th, 11:49 AM »
rev 1367
(4 files, 3kb)

* Moved thought list-related styles back to members-only CSS. I'm not sure I remember why I canceled that in the first place... (index.css, index.member.css, Wine/index.css, Wine/index.member.css)

* Thought buttons should no longer get in the way of those who will recognize themselves ;p (index.member.css, Wine/index.member.css)

* Started doing some CSS resets. Eventually, Wine will be an inherited skin again. It's already the case on my local install. (Wine/index.css)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1368 on February 20th, 02:55 PM »
rev 1368
(2 files, 2kb)

* WeCSS will now simply remove unsupported properties from old IE versions, because we can't expect them to add support for them in the future, so it's a waste of bandwidth... (Subs-Cache.php)

! Wedge wasn't correctly setting up attachment transparency, as I forgot to specify the path and filename. Oops. (Load.php)

:edit: A PHP+GD2 limitation is that due to lack of support for animated GIFs, these will always be treated as opaque. It's unfortunate, because Pete's avatar gets drop shadows around it. :(
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1369 on February 20th, 05:35 PM »
rev 1369
(4 files, 3kb)

! Sidebar positioning flag was incorrectly retrieved from the skin file by Wedge. (Subs-Cache.php)

! Forgot to commit a file for rev 1368's transparency fix. (Subs-Media.php)

* Made WeCSS's reset keyword a bit more productive by allowing it on selectors within a nested tree. (Class-CSS.php)

* Don't display the prev/next link container if it's empty to begin with. (Display.template.php)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1370 on February 20th, 05:38 PM »
rev 1370
(10 files -2, 9kb)

* Converted Wine to a child skin of Weaving. Oh my, was harder than I hoped... Also tweaked the search box color in Wine, and fixed a few issues in both Weaving and Wine, such as user boxes being incorrectly positioned. (index.css, index.member.css, Wine/*)

! Changed thought list buttons to use absolute positioning instead of floating. This ensures that thought cells no longer get resized on the fly. (index.member.css)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1371 on February 20th, 05:55 PM »
rev 1371
(2 files, 1kb)

* Cached CSS should give at least some breathing space to the copyright lines, they're supposed to be readable... (Subs-Cache.php)

! Fixed some minor glitches in auto-suggest object when suggestion list is empty and CSS adds some styling around a list, however empty it may be. (suggest.js)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1372 on February 21st, 06:27 PM »
rev 1372
(6 files, 3kb)

* Now vertically centering the thought action buttons. Yay. (index.member.css)

! Fixed whatever glitch I could find remaining in Warm and Wuthering. I'm not exactly sure why I was using an !important on .catbase, hopefully it really was no longer needed. (index.css, Warm/index.css)

! Minor tidbits, like the Wedge select box no longer requiring non-breakable spaces on long lists to avoid hiding their right side. (Themes.php, ManageMedia.template.php, Profile.template.php)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Online Arantor

  • Wedgeward
  • Posts: 10,364
  • The Twelve Tasks of Asterix is awesome.
    • View profile
    • Innovate, not Imitate
Re: New revs
« Reply #1373 on February 22nd, 02:04 AM »
(2 files, 2KB)

Revision: 1373
Author: arantor
Date: 22 February 2012 01:03:33
Message:
! Board and topic access was entirely broken, due to incorrect testing on the privacy rules where a board has an owner (if a board had no owner, no checking was done for guests - and no boards have owners by default). Phased out the old $board_info['groups'] variable, and updated a function to accept the newer board permissions setup (sans board owner rules for now). ManageBoards still needs updating to work with the newer allow/deny stuff. (Announce.php, Load.php)
----
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Load.php
   computer-aided
   community building		             

Other stuff:

Online Arantor

  • Wedgeward
  • Posts: 10,364
  • The Twelve Tasks of Asterix is awesome.
    • View profile
    • Innovate, not Imitate
Re: New revs
« Reply #1374 on February 22nd, 02:19 AM »
(1 file, 1KB)

Revision: 1374
Author: arantor
Date: 22 February 2012 01:19:01
Message:
! Forgot to remove some debugging code from Load.php (Load.php)
----
Modified : /trunk/Sources/Load.php
   computer-aided
   community building		             

Other stuff:

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1375 on February 22nd, 04:32 PM »
rev 1375
(4 files, 11kb)

+ Started implementing this dreaded feature of mine -- topic privacy. Please note that (1) query_see_topic is not set in stone yet. For instance, it doesn't make use of mod_cache (yet), for better or for worse. Also, (2) database structure is still being discussed. I'm just taking the longer way until we decide whether we simplify it or not. (install.sql, Display.php, Load.php)
* Updated thought privacy feature to use the same terminology as topic privacy. (install.sql)
* Implemented the no_prevnext variable that's used to determine whether to show the previous/next topic box. (Display.php)
! ssi_topPoster() needed a $settings global. (SSI.php)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1376 on February 23rd, 09:54 AM »
rev 1376
(7 files, 3kb)

+ Added support for mod_cache in query_see_topic, to be able to view topics from SSI or other non-board/non-topic-specific places. Hopefully it'll work. (Load.php)

- Removed $user_info['can_mod'], never used much. Replaced it with allowedTo('issue_warning') or allowedTo('access_mod_center') depending on what was required of it. (Display.php, Load.php, PersonalMessage.php, Security.php, Subs-Auth.php, Subs.php)

* This bq test for 0=1 is never executed, because it's caught a few lines before. (ModerationCenter.php)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1377 on February 23rd, 11:38 AM »
rev 1377
(16 files, 7kb)

+ The totally untested, yet probably flawless query_see_topic commit[1]. Every single topic approval test is now replaced. (Feed.php, MessageIndex.php, Profile-Modify.php, Profile-View.php, Search.php, Search2.php, Stats.php, Unread.php, UnreadReplies.php, Who.php)

! SMF 'bug': setting an is_approved to 0 is totally wrong semantically in ManageMaintenance and SplitTopics. Renamed variable to is_unapproved. Also renamed a few other variables which, although semantic, didn't fit the is_approved/approved_state grammar. (ManageMaintenance.php, Aeva-Gallery2.php, Subs-Media.php, SplitTopics.php, Subs-Post.php)
 1. And yes, it means that technically, the feature is supposedly implemented. Surprisingly it's a lot less entries than I thought it'd require... Unless it means that SMF's approval state is unsafe :P
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: New revs
« Reply #1378 on February 23rd, 11:56 AM »
rev 1378
(7 files, 3kb)

! updateLastMessages() should be accepting only a default privacy state for topics that will definitely be shown to everyone... (Subs-Post.php)

- Removed setupTopicPrivacy() function and integrated into loadUserSettings -- I hadn't noticed it was always called in SSI.php anyway. (Load.php, SSI.php)

* More semantic approved states and other minor fixes. (Load.php, ManageModeration.php, MoveTopic.php, Subs-Post.php)

! Fixed Search page's search icon not showing up in Wine. (Wine/index.css)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Online Arantor

  • Wedgeward
  • Posts: 10,364
  • The Twelve Tasks of Asterix is awesome.
    • View profile
    • Innovate, not Imitate
Re: New revs
« Reply #1379 on February 23rd, 01:47 PM »
(7 files, 5KB)

Revision: 1379
Author: arantor
Date: 23 February 2012 12:46:21
Message:
! Subscriptions should be able to be configured for lifetime access. It's a surprising amount of work but I think I got everything straightened out, needs more testing of course. (ManagePaid.php, Profile-Actions.php, ScheduledTasks.php, subscriptions.php, Subscriptions-PayPal.php, ManagePaid.template.php, ManagePaid language file)

! slideToggle() doesn't work the same as toggle(), can't use it to set the final state. (ManagePaid.template.php)

! Encoding fix (just ManagePaid.english.php - French file is fine)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/subscriptions.php
   computer-aided
   community building		             

Other stuff:
« User configurable CC email accounts
A new banning option? »