New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1290, on February 3rd, 2012, 07:13 PM »
rev 1290
(15 files, 5kb)

* Moved both Quick Access select boxes to the sidebar, where it'll sit forever and ever. At least until I add an option to turn it off... (index.php, Display.php, Display.template.php, index.template.php, MessageIndex.template.php, index.french.php, index.ie6.css, index.ie7.css, sections.css, Warm/index.css)

* Moved JumpTo array generation to script.js, even if currently we really only have one JumpTo -- the sidebar one -- but eventually we may start using JumpTo for quick mod as well, so I won't be removing the code. For now. (script.js)

- More weToggle variables removed, whenever they weren't used. (Admin.template.php, Display.template.php, ManagePermissions.template.php, Packages.template.php -- I know, we'll remove that file eventually, Post.template.php)
Re: New revs
« Reply #1291, on February 5th, 2012, 10:29 PM »
rev 1291
(3 files, 3kb)

! Made sure that our Atom feeds would pass the W3 Unicorn validator. This was done by setting a global id tag (I'm afraid this also means an extra entry in the settings table...), and being stricter about whether we should use CDATA. Also removed the icon tags because they're supported on the feed level, not on the entry level. And added a few todo comments about the unused getXmlProfile function. (Feed.php)

+ Added a link to the Atom feed for latest members in the Member List page. Can't believe it was never done... (Memberlist.template.php)

* Tweaked the HTML indentation level in non-main menus, so that it's similar to the main menu's. (GenericMenu.template.php)
Re: New revs
« Reply #1292, on February 5th, 2012, 11:29 PM »
rev 1292
(4 files, 3kb)

! Undefined index in WAP mode, due to a typo in the pin_topic permission. (Display.php)

! Undefined index in getXmlProfile... You know, the one I just said wasn't being used. (Feed.php)

! Verification question template's input boxes were too wide, breaking the layout. (Admin.template.php)

! Menu tabs weren't correctly generated if the menu itself was shown in the sidebar, and the sidebar was shown on the right (i.e. after the default layout). Had to move the tab list generation to the generic_tabs() function itself. Also, testing the area ID with a simple == could result in errors, had to go for a strict check. (GenericMenu.template.php)
Re: New revs
« Reply #1293, on February 7th, 2012, 11:16 AM »
rev 1293
(4 files, 2kb)

! Fixed Quick Reply box showing two editor areas instead of just the one. (editor.js)

* The wireless template really needed some extra padding... I don't care about how phones deal with it. I have the say in how they should render it really. (wireless.css)

* More Image() optimizations. (Load.php)

* Language file typo. (Themes.french.php)

@ I have tons more things to commit... Gonna be a long day.
Re: New revs
« Reply #1294, on February 7th, 2012, 05:07 PM »
rev 1294 -- ARGHHHhhh
(24 files, 15kb)

* Simplified JumpTo object -- a lot. Removed over 100 bytes of unneeded code. Basically, JumpTo accounts for multiple JumpTo boxes. Not only is this not the case right now -- only the sidebar has one -- but even if I added one to quick mod, it would still be unlikely that one would want to click one of the boxes, then cancel it, then click the other. (index.template.php, script.js)

* Simplified news fader object. Everything is now in a closure, saves about 60 bytes in the final gzipped file (which was short to begin with anyway). The calling code is also shorter, and there's no need for an Optimize section anymore. (Boards.template.php, fader.js)

* Search page will now offer two radio buttons (all boards/specific boards) instead of a single toggler with that confusing 'Check all' checkbox... The rest should behave exactly the same, it's just a UI thing. (Search.template.php, Search.languages.php)

* Per-page action ID is now moved to the html tag, rather than the body tag. (index.template.php)

* Removed global IDs from several files. They're now included directly in the html tag, so apart from a few renames, conversion is straightforward. (MoveTopic.template.php, PersonalMessage.template.php, Profile.template.php, SendTopic.template.php, Who.template.php, index.ie6.css, index.member.css, index.rtl.css, sections.css)

* Renamed quick_login_dec language entry to quick_login_desc. I suppose that's what was meant in the first place, right...? (index.template.php, index.language.php)

* Moved all delayed inline event handling code to script.js, because it didn't really make sense not to cache it... (index.template.php, script.js)

* Rewrote weres() function to remove the need for a global variable, and make it more logical to style responsive layouts. So, instead of the 'edge' div switching between 'edge' and 'edgehide' IDs, Wedge will now simply add a 'responsive' ID to the body tag. Plus, it's MUCH shorter. Starting from this revision, I think all pages are now about 200 bytes shorter. (index.template.php, index.css, index.gecko.css, index.iphone.css, Warm/index.css)

! Turns out that iOS still needs to bypass the weres() function in the original skins. Right now I have no plans to rewrite these skins' sidebar code to match the new skin's, so it'll have to stay this way. (index.template.php)

! Columns width were glitchy in IE6/7. (Who.template.php, index.css, index.ie6.css, index.ie7.css)

! The W3C HTML5 validator no longer validates HTML5+microdata pages, so I'm switching the validator link to validator.nu instead. Additionally, this new solution will validate pages for you even if you have an antivirus enabled. (index.template.php)

* Anything to save a couple of bytes in the gzipped JS files... (sbox.js, script.js)

* Indenazi. (index.template.php)
Re: New revs
« Reply #1295, on February 7th, 2012, 05:12 PM »
rev 1295
(3 files +11, 98kb)

+ As annoying as it is, I'm committing the skin for Wedge.org, because I'd really like to benefit from SVN features you know... The skin has no name for now, so it'll go by the codename 'Worg'. Also, it's a work in progress, so it's full of commented out code and things like that... Obviously it'll be reworked later. (skins/Worg/*)

! Fixed crash on WAP2 pages, due to template_page_index not being available. (Wireless.template.php)

* Commenazi. (Search.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1296, on February 8th, 2012, 03:24 PM »
My first in a while. Life is a bitch like that.

(2 added, 3 removed, 15 modified, 30KB)

Revision: 1296
Author: arantor
Date: 08 February 2012 14:22:29
Message:

& Typo that really irritated me in the search engines page. (Search language file)

! Remove file edits from the master copy of the plugin info specification. It isn't implemented currently and isn't going to be in future, so no need to document its format. (plugin-info.rng)

! Attempt to issue headers that cut back on the crap that gets sent out every page. May or may not make a huge difference depending on configuration but it can't hurt to do so. (QueryString.php)

+ Debug output now includes peak memory usage. Not a major thing but can be useful. (Subs-Template.php, index language file)

! Housekeeping of core features images we don't use any more (feature_ml.png, feature_sp.png, feature_w.png)

! Another item kicked off of Core Features and into its own page: Search Engines (now relabeled Search Engine Tracking to better fit with what it does). This resulted in a bit of fixing around how the pages themselves worked, and to make sure that spider_mode was checked, rather than checking any of the other parameters (which previously, Core Features would have done for us). (Admin.php, Load.php, ManageSearchEngines.php, ManageSettings.php, Subs-MembersOnline.php, Who.php, search_engines_*.png, language files: Admin, ManageSettings)

----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/images/admin/feature_ml.png
Deleted : /trunk/Themes/default/images/admin/feature_sp.png
Deleted : /trunk/Themes/default/images/admin/feature_w.png
Added : /trunk/Themes/default/images/admin/search_engines_off.png
Added : /trunk/Themes/default/images/admin/search_engines_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/plugin-info.rng
Re: New revs
« Reply #1297, on February 8th, 2012, 04:27 PM »
(2 modified, 1KB)

Revision: 1297
Author: arantor
Date: 08 February 2012 15:26:54
Message:
! Fix for broken bbcode change in the installer. Remember: if you want a literal \ in the table, you have to escape it in SQL, heh. (install.sql)

! Minor thing that always annoyed me: it shouldn't be possible, even accidentally, to give guests permission to send announcements or edit site-wide news. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #1298, on February 8th, 2012, 05:42 PM »
(3 modified, 11KB)

Revision: 1298
Author: arantor
Date: 08 February 2012 16:41:27
Message:
! The 'show how many people are viewing this...' option is no longer a theme option but now a general option (since it should logically apply consistently to all themes) (Display.php, ManageSettings.php, MessageIndex.php, Subs.php, Display.template.php, MessageIndex.template.php, Settings.template.php, ManageSettings and Themes language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php

(For those wondering, it's in Features and Options with the other 'who's online' type options.)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1299, on February 8th, 2012, 05:59 PM »
Yay, Pete is back... ;)

rev 1299
(16 files, forgot to watch the patch size, not much though.)

- Removed unused sSelf declarations and global JS variables. (Admin.php, Class-Editor.php, ManageMedia2.php, ManageBans/Boards/Maintenance/Membergroups/News/Paid.template.php, ModerationCenter.template.php, Profile.template.php)

* Replaced forum_index language string with board_index, and moved the forum name outside of it -- mostly so that one could use these strings without having to fill in the forum name. (Boards.php, index.language.php)

* Minor Worg tweaks. (Worg/index.css, Worg/sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1300, on February 8th, 2012, 06:09 PM »
(8 modified, 9KB)

Revision: 1300
Author: arantor
Date: 08 February 2012 17:08:47
Message:
! Move the 'enable collapsable post options' to post options, rather than in theme options. (install.sql, ManagePosts.php, Post.template.php, Settings.template.php, Admin and Themes language files)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1301, on February 8th, 2012, 06:23 PM »
rev 1301
(7 files, 3kb)

- While I was at it, I started removing unused globals ($settings, $options, $modSettings etc) from files, until I realized it required too much attention and was prone to errors, so I'm just going to leave it at that and commit whatever I've done... (ManageSettings.php, Subs.php, Display.template.php, ManageNews.template.php, ModerationCenter.template.php, Settings.template.php)
Re: New revs
« Reply #1302, on February 8th, 2012, 07:28 PM »
rev 1302
(3 files, 3kb)

! Fixed an issue in the JumpTo rewrite where having many boards would make it slow to fill. My bad. (script.js)

* Rewrote XML file sent by the jumpto action, to use less bandwidth, especially when pretty URLs are disabled. (Xml.template.php)

* Not that anyone cares, but a few optimizations here and there allowed me to keep script.js at the same gzipped size, even after adding the extra code for the new XML format. Most notably, there's no need to test for selectedIndex because our jumpto select box has a data-hide on its first entry, so it can be selected in any way. (script.js)

* Just a detail. (Admin.french.php)
Re: New revs
« Reply #1303, on February 9th, 2012, 09:56 AM »
rev 1303
(4 files, 2kb)

! Fixed JumpTo function when pretty URLs were disabled. It's also now one byte smaller... I'm mental. Don't go near me. (script.js)

! In some cases, at least on my local install, filesize() will sometimes fail even if file_exists() returns true. Added a @ to suppress the error. (Subs-Cache.php)

- Removed text-overflow from CSS exceptions. From what I could gather on caniuse.com, only older versions of Opera need a prefix, meaning it's a stabilized rule, so let's not waste time on this. I'm not exactly sure why I added it in the first place, so I may have to revert later. (Subs-Cache.php)

! Fixed icon positions in topic moderation bar. (Worg/index.member.css)

* Simplified button list styling. (Worg/sections.css)
Re: New revs
« Reply #1304, on February 9th, 2012, 11:11 AM »
rev 1304
(12 files -1, 5kb)

* Moved Media area's master setting back to the Media admin settings page. This means that the only Core Feature left is Post Moderation (and the associated feature_pm.png), which Pete will probably remove soon. Also fixed Media menu to always show up -- but only show the main settings page, so that you can re-enable the media area easily. (Admin.php, ManageSettings.php, feature_m.png, ManageSettings.language.php, Media.language.php)

- Removed anything related to welcoming users to the Core Features page... (ManageSettings.php, ManageSettings.language.php, Admin.template.php)

- Removed force_disable_tabs, which is no longer used. I could have used that on the media area when enabling/disabling the master setting, but that would only help to disable extra entries when unneeded, not to restore them when needed. (Admin.template.php, GenericMenu.template.php)

! The orphan menu separator fix wasn't strong enough, it needed to be applied again at the end of the process. (Subs-Menu.php)

* Language tweak. (Admin.french.php)

* Admin layout tweak. (admin.css)
Plugin revs »