New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1245, on January 11th, 2012, 08:58 AM »
rev 1245
(2 files, 5kb)

! Fixed select box internal paddings in IE 6/7, while making the HTML, CSS and JavaScript code even shorter (33 bytes for JS). (sbox.js, index.css)

* Select boxes will now inherit their original's ID. This should make it easier to manipulate the new select box without having to resort to .sb(). See example in quick mod boxes. (sbox.js)

- Removed aria-labelledby. It was using too much code for something that's pretty useless, given that the label tag does everything on its own. Or doesn't it? My problem is that NVDA sucks when it comes to providing accessibility for our select boxes (we'll need to work on that), but at the very least it can draw its information from the label and doesn't need Aria for that. (sbox.js)

@ Current sbox size: 2577. There are still some bugs left to fix, though...
Re: New revs
« Reply #1246, on January 11th, 2012, 09:09 AM »
rev 1246
(18 files, 5kb)

* Replaced these ugly ----- in select boxes with proper horizontal rules. I decided to go for a class, and instead of running extra JS on every single select box, I'm adding the class directly to the original HTML. Cleaner. (Groups.php, ManageMembers.php, ManageSmileys.php, ManageMaintenance.template.php, ManageMedia.template.php, ManageScheduledTasks.template.php, ModerationCenter.template.php, Profile.template.php, Search.template.php -- index.css already committed)

* Forgot to apply some jQuerification to the blog index. (MessageIndex.template.php)

! Generic form settings in Admin area would generate a label without associating it with the element. (Admin.template.php)

! Fixed button height and simplified CSS in select boxes in most instances. I wasn't sure that would even work... Turns out it works even in IE6. (editor.css, index.member.css -- index.css already committed)

* Spacinazi. (ManageMemberOptions.php, ModerationCenter.php, SplitTopics.php, GenericList.template.php)

! Translation error. (ManageSettings.french.php)
Re: New revs
« Reply #1247, on January 11th, 2012, 11:45 AM »
rev 1247 -- just to be clear ;)
(2 files, 1kb)

! Undefined index error (thanks John). (Admin.template.php)

! The footer logo was incorrect in Wuthering. (Wuthering/index.css)
Re: New revs
« Reply #1248, on January 12th, 2012, 10:05 AM »
rev 1248
(3 files +1, 6kb)

+ Added ability for users to add a Custom.template.php file to their theme, allowing them to override/add/prepend code to their index template without modifying it, which can be very useful if they want to customize any template in a minor way that doesn't require creating a new theme, and still be able to upgrade their copy of Wedge without re-editing the files every time. Heck, that's a long explanation for just one line of code...! (Load.php, attic/Custom.template.php)

* Repositioned select box styling in the WeCSS file to help with selector specificity and crap like that. (index.css)

* Just a minor if() rewrite for readability. (Subs-Template.php)
Re: New revs
« Reply #1249, on January 13th, 2012, 12:10 AM »
rev 1249
(2 files, 3kb)

! Fixed situation where de-focusing a select box by clicking somewhere else in the document, and then pressing a navigation keyboard shortcut, would actually trigger said shortcut in the blurred select box. Costs an extra byte at compression time. (sbox.js)

* Moved all drag'n'drop code inside the plugin itself, to avoid setting up a mousemove event on $(document) on all page loads, instead of when it's actually needed. I don't see any drawbacks to that...? And it saves half a dozen bytes. I like fixing bugs and shortening my gzipped files at the same time, if you didn't notice. You must be blind. And deaf. And if you really are, please tell me where you think I could improve accessibility. (script.js)
Re: New revs
« Reply #1250, on January 13th, 2012, 12:11 AM »
rev 1250
(1 file, 4kb)

* Rewrote add_css_file() to merge it with wedge_cache_css(). Should make the whole code cleaner this way... To do: merge it with add_plugin_css_file() as well. For now, I simply rewrote its webkit regex to use \b. (Subs-Cache.php)

! Fixed inherited skins where non-main files, such as admin.css, wouldn't properly inherit their parents' contents. Can't believe I finished working on this a year ago and never noticed any problem with it... (Subs-Cache.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1251, on January 13th, 2012, 02:52 AM »
Revision: 1251
Author: arantor
Date: 13 January 2012 01:52:07
Message:
! Happy New Year: updated visible copyright dates. Not brave enough to update every file in distribution so left it purely at the publicly visible dates. (install.php, upgrade.php, Credits.php, Who language file)
! bbcode can be added through the plugin manager. Seems to cover everything that should be supported at this point as well as enforcing the rules around what data goes with what bbcode. (install.sql, plugin-info.rng, ManagePlugins.php)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/plugin-info.rng
Modified : /trunk/other/upgrade.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1252, on January 13th, 2012, 09:50 AM »
rev 1252
(6 files +2, 4kb)

* It feels better to use monospaced fonts for regex input fields. (Admin.template.php, admin.css)

! Selecting a profile field template like Facebook etc. wouldn't properly update the select box selections. (Admin.template.php)

! Fixed CSS caching process failing at install time, hopefully. (Subs-Cache.php)

! Fixed Wuthering header styling in IE 6-10. (Wuthering/index.ie*.css)
Re: New revs
« Reply #1253, on January 13th, 2012, 03:19 PM »
rev 1253
(2 files, 2kb)

! Fixed select box glitch where long optgroups would sometimes generate an extra 15px whitespace on the right side. (sbox.js)

! Fixed select box glitch where the display area's width after selecting an item would be calculated incorrectly if display used different styles compared to the dropdown. (sbox.js)

! And a third select box bug fix I forgot to commit... Whatever that was, it was annoying. (index.css)

@ The first two fixes basically use the same technique (setting width to auto), and cost an extra 21 bytes. Well, at least it's still under 2600... Hello? Is anyone listening? Oh, I should have guessed... The rascals. Tomorrow's lottery numbers will be 3, 12, 21, 42 and... Oh, now everyone is listening uh? I'm telling you. Rascals.


@ Okay, I think I'm mostly done with select box fixes... Well, never say never. But it's all around very solid for now. And please, for the love of Carmack, don't try and modify sbox.js any longer!
Re: New revs
« Reply #1254, on January 14th, 2012, 11:24 AM »Last edited on January 14th, 2012, 07:53 PM by Nao
rev 1254
(3 files, 2kb)

! updateOnlineWithError() could be called before $user_info was set, thus generating silent errors. (Errors.php)

! sendmail() could be called before $context['server'] was set, thus generating silent errors. Thank you, copy and paste! (Subs-Post.php)

* Commenazi. (QueryString.php)
Re: New revs
« Reply #1255, on January 14th, 2012, 07:53 PM »Last edited on January 14th, 2012, 08:01 PM by Nao
rev 1255
(9 files -1 +13, 29kb) (mostly icons being moved around.)

* Rewrote input button styling to be more consistent across different browsers. As always, I started with Opera, and I fixed the CSS manually in Firefox 9, IE 8/9/10 (IE8 sucks because it renders text incorrectly), and Chrome 17. Won't bother with the rest. (index.css, index.firefox.css, index.ie*.css, index.webkit.css, other/images/buttons/*, images/buttons/*)

* Spacinazi. (theme.js)
Re: New revs
« Reply #1256, on January 14th, 2012, 08:01 PM »
rev 1256
(5 files, 4kb)

! Warm was broken in complex pages, due to the indentation code being too heavy, even while using atomic grouping... Bugger. (Subs-Template.php)

* Modified thought editor to use an indexed array for privacy levels. Used the totally arbitrary following numbers: 1 for public, 5 for members, 8 for self. Removed a couple of entries that I have yet to implement in Wedge. (index.template.php, index.language.php)

* Moved all script_in_head code to template_body_after(), it should be cleaner this way. Scripts are now added at the end of the head tag instead of the beginning, which is the recommended position. Decided that IE7 and IE8 aren't fast enough to justify moving script tags either. (index.template.php)

* Commenazi. (QueryString.php)
Re: New revs
« Reply #1257, on January 15th, 2012, 01:08 AM »
rev 1257
(2 files, 1kb)

! $context['skin_folders'] was filled in incorrectly when caching a replace-type skin. (Subs-Cache.php)

* Forgot to document the 'indent' parameter. (Warm/skin.xml)
Re: New revs
« Reply #1258, on January 15th, 2012, 10:15 AM »
rev 1258
(258 files, 13kb)

* Updated copyright year to 2012 in file headers.

@ 258 files in rev 1258...? Another funny coincidence ;)
Re: New revs
« Reply #1259, on January 17th, 2012, 02:04 PM »
rev 1259
(3 files, 4kb)

! It's more code than I'd have liked, but I fixed 'replace'-type skins so that skin authors don't have to import the entire list of files off the top-level skin. If you don't want to include admin.css for instance, so that you can safely get Wedge updates on that file without having to copy them manually, you no longer need to. Wedge will automatically import whatever it needs from the top-level folder. Documented in the Warm skin file, as usual. (Subs-Cache.php, Warm/skin.xml)

- Removed Andale Mono from possible editor font choices. The font is no longer shipped with modern Windows, and although it's still available in Mac OS X, there's really not much of a reason to use it over the tt tag, which in Wedge uses Consolas or Monaco, arguably better fonts for the same job. Plus, there's always Courier New in the list. (Class-Editor.php)
Plugin revs »