New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1065, on October 7th, 2011, 11:48 AM »
Revision: 1065
Author: arantor
Date: 10:43:48, 07 October 2011
Message:
! Integrate the fixes from SMF 2.0.1 patch, specifically:
 ! Disable the mod center putting the session into everything. (ModerationCenter.php)
 ! Fix version detection in the package manager, in case I ever reuse that function in the plugin manager. (Subs-Package.php)
 ! Maintenance not dealing with $_POST vars properly (ManageMaintenance.php)
 ! Entity fixes, namely being sure to exclude 0x202D and 0x202E which are LTR/RTL override characters, and making sure certain characters are entitified. (Class-String.php, Subs-Members.php)
----
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Package.php
Re: New revs
« Reply #1066, on October 7th, 2011, 11:54 AM »
Revision: 1066
Author: arantor
Date: 10:48:31, 07 October 2011
Message:
! Files flagged as not found in pretty URLs mode should indicate that fact when logging the error, rather than them being general errors. (Errors.php, QueryString.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Re: New revs
« Reply #1067, on October 7th, 2011, 01:08 PM »
Revision: 1067
Author: arantor
Date: 12:08:41, 07 October 2011
Message:
! Removed the database backup facility. It was a shade unreliable, especially in UTF-8 circumstances. There are better tools out there for this job, use them. (DumpDatabase.php, Class-DBExtra.php, ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Class-DBExtra.php
Deleted : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Re: New revs
« Reply #1068, on October 7th, 2011, 01:17 PM »
Revision: 1068
Author: arantor
Date: 12:17:02, 07 October 2011
Message:
! Oops, more legacy code from the DB dumper that I forgot I didn't need. Mind you, it does give potential for more cleanup later of the Extra class. (Class-DBExtra.php)
----
Modified : /trunk/Sources/Class-DBExtra.php
Re: New revs
« Reply #1069, on October 7th, 2011, 01:32 PM »
Revision: 1069
Author: arantor
Date: 12:31:48, 07 October 2011
Message:
! Any pages that use the default settings construct now display a 'Your settings have been saved' message at the top of the screen after pressing save. (ManageServer.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php


@ Of course, pages that don't use the standard settings context structure probably don't *need* this anyway because it should be fairly obvious as you head between different areas (e.g. from a summary to an edit page, back to summary) that something has been changed.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1070, on October 7th, 2011, 02:50 PM »
rev 1070
(5 files +1, 11kb)

* Forgot to restore page title in non-Ajax errorlog file viewer. (ManageErrors.php)

* Moved Go Up and Go Down JavaScript code to an external script. (Display.template.php, topic.js)

- Moved sJumpToTemplate from JumpTo object to the HTML itself, saving us a few bytes and the need to escape the text string (which, incidentally, wasn't escaped in the first place.) (Display.template.php, MessageIndex.template.php, script.js)

@ Oops... I committed /images/.htaccess by mistake. Will remove it from the trunk in my next commit. I can't afford to have it committed until I've decided whether these files really should be cached forever...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1071, on October 7th, 2011, 03:26 PM »
Revision: 1071
Author: arantor
Date: 14:24:27, 07 October 2011
Message:
! Removed time/date format from being generally declared and instead made it per-language. Users can, of course, still set their own preference, but system-wide is almost invariably more dependent on language than on anything else. There is, for example, a different default for English vs French because English date/time tends to use 12 hour plus AM/PM, while French tends to use 24 hour, and this is reflected as such. I *think* I hit all the places necessary to make it work as expected, but it's possible things may be slightly buggy, I haven't had time to test everything fully for this. (install.sql, wedge_api.php, upgrade.php, Load.php, ManageNews.php, ManageSettings.php, ScheduledTasks.php, Subs.php, Profile.template.php, Language files: index, Install, ManageSettings, Profile)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/other/upgrade.php


@ Incidentally I made sure to avoid an awkward situation that never actually caused a *problem* before but could have done. $txt['time_format'] was previously taken to be the language-dependent setting, but that very string is declared in the profile area. Fortunately, it was redeclared after $txt['time_format'] was used to determine date/time format, but as far as I'm concerned it shouldn't change both content and meaning during runtime like that, so I renamed the profile's string. (The help string has been left in because it is still used in the profile area)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1072, on October 7th, 2011, 05:16 PM »
rev 1072
(2 files -1, 5kb)

- Reverted an accidental commit. (images/.htaccess)

! Syntax error in rev 1063. (Security.php)

! Template blocks were always ignored if not found. This is okay, except for the actual main function. I suspect this is something I did during my testing phase and I forgot to restore it... (Subs-Template.php)

* Indenazi. (Subs-Template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1073, on October 9th, 2011, 01:36 AM »
(Oops meant to post this one earlier.)

Revision: 1073
Author: arantor
Date: 19:19:18, 08 October 2011
Message:
! Provide support for extending the visual verification system, including a hook for the relevant admin page. (ManagePlugins.php, ManageSettings.php, Subs-Editor.php, GenericControls.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Re: New revs
« Reply #1074, on October 9th, 2011, 01:42 AM »
Revision: 1074
Author: arantor
Date: 00:35:55, 09 October 2011
Message:
! Fixing a long-standing, much irritating (to me) grammatical error. (Errors language file)

! Display what the user is doing in their profile, assuming who's online is enabled and you have permission to view it. (Profile-View.php, Profile.template.php, Profile language file)

! Some language cleanups, converting some fatal_error to fatal_lang_error calls, plus especially cleaning up some cases where strings were bolted together before being sent to fatal_error, with the side benefit that they're actually more translatable now as a result. (Activate.php, ManageMaintenance.php, ManageServer.php, Memberlist.php, ModerationCenter.php, Packages.php, Profile-Actions.php, Reminder.php, SplitTopics.php, Profile language file)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Re: New revs
« Reply #1075, on October 9th, 2011, 02:05 AM »
Revision: 1075
Author: arantor
Date: 01:04:43, 09 October 2011
Message:
! More cleanups of fatal_error to fatal_lang_error (including a few I broke last time in error) and cleaned up a language string or two, hopefully without getting the French translations totally wrong. Note that there's a couple of interesting fixes in there in the process. (Activate.php, Aeva-Gallery.php, Packages.php, Post2.php, Security.php, index and Post language files)

! Fix for strange error I made porting one of the last SMF patches. (Subs-Boards.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Re: New revs
« Reply #1076, on October 9th, 2011, 03:04 AM »
Revision: 1076
Author: arantor
Date: 02:04:03, 09 October 2011
Message:
! Allow spoiler=content format to set the text displayed in the button itself. Quoting should be optional, bbc should not be parsed at all in the button's text (mostly because it's not supported by browsers anyway) (install.sql)
----
Modified : /trunk/other/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1077, on October 9th, 2011, 11:00 AM »
rev 1077
(7 files, 9kb)

! Potential empty delimiter error. (Errors.php)

! Another syntax error in fatal_lang_error. (Security.php)

* Don't show security warnings within Ajax pages. (Subs-Template.php)

* French translation. (Admin.language.php, index.french.php, ManageMaintenance.french.php)
Re: New revs
« Reply #1078, on October 9th, 2011, 03:06 PM »
rev 1078
(25 files, 19kb)

* Telling users their latest posts are going to disappear isn't very smart, especially if you're not going to delete them in the first place. Replaced default maintenance mode string with a more... suitable default. (other/Settings.php, other/Settings_bak.php)

* French translation fixes and minor grammar. (ManageSmileys.french.php, Post.french.php, Profile.language.php, Themes.french.php)

* Moved $security_file into the relevant language string. (Subs-Template.php, index.language.php)

* Micro-optimized westr_entity. A bit. As far as I know. I think. (Class-String.php)

* Indenazi, commenazi. (other/plugin-info.rng, ManageMaintenance.php, ManagePlugins.php, ManageServer.php, ManageMedia.php, Reminder.php)

- A few backup-related strings weren't removed entirely. (other/readme_up*.html, Admin.language.php, Errors.language.php)

- And some unused language strings. (index.language.php)

! Syntax error. (Activate.php)
Re: New revs
« Reply #1079, on October 9th, 2011, 10:58 PM »
rev 1079
(6 files, 10kb)

* Fixed/improved/tweaked main menu padding and notice handling in all browsers. (index.css, index.ie*.css)

* Not exactly sure why I used array_fill(0, count($blocks), true) instead of just $blocks... We don't care about the values in it, just about the number of items it has. (Subs-Template.php)
Plugin revs »