Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - live627
31
Bug reports / Re: add_plugin_css_file issues
« on March 29th, 2013, 09:34 PM »
Maybe merge functions, but keep add_plugin_css_file() as a shortcut of sorts?
32
Bug reports / Re: MedIa thumbnail does not update
« on November 10th, 2012, 07:06 PM »
Tried on here just now. All it does is get resized.
33
Bug reports / Delette member does not affectt the media area
« on November 5th, 2012, 12:52 AM »
Album owners and item creators should be set to guest
Logs should be appropriately pruned

and so on...
34
Bug reports / Nobbc
« on October 10th, 2012, 01:25 AM »
The following bbcodes do not respect nobbc: media and nb
35
Bug reports / MedIa thumbnail does not update
« on October 10th, 2012, 12:59 AM »
I just tried t update a media item with a new image (yes, I also uploaded a new thumbnail) and it didn't seem to update. ID is 113.
36
Bug reports / WebGet and open_basedir
« on August 1st, 2012, 06:31 AM »
On the last page of the installer, I see some of these errors:


Warning: curl_setopt() [function.curl-setopt]: CURLOPT_FOLLOWLOCATION cannot be activated when safe_mode is enabled or an open_basedir is set in ./Sources/Class-WebGet.php on line 150
37
Bug reports / Re: No error box on preview
« on June 7th, 2012, 05:25 PM »
IIRC, it broke because the error box isn't loaded right away as in SMF.
38
Bug reports / Re: No error box on preview
« on June 7th, 2012, 12:44 AM »
Try it in SMF...
39
Bug reports / No error box on preview
« on June 6th, 2012, 12:05 AM »
No error box appears when previewing a new topic without a subject, even though the subject label turns red, indicating an error.
40
Bug reports / My fixes to Subs-Boards
« on May 11th, 2012, 09:22 AM »

@@ -649,6 +649,18 @@
       $boardUpdateParameters['language'] = $boardOptions['language'];
    }
 
+   if (isset($boardOptions['board_type']))
+   {
+      $boardUpdates[] = 'board_type = {string:board_type}';
+      $boardUpdateParameters['board_type'] = $boardOptions['board_type'];
+   }
+
+   if (isset($boardOptions['id_owner']))
+   {
+      $boardUpdates[] = 'id_owner = {int:id_owner}';
+      $boardUpdateParameters['id_owner'] = $boardOptions['id_owner'];
+   }
+
    // Do the updates (if any).
    if (!empty($boardUpdates))
       wesql::query('
@@ -1100,12 +1112,12 @@
 
 // Load a lot of useful information regarding the boards and categories.
 // Restrict to their own boards anyone who's not an admin
-function getBoardTree($restrict = false)
+function getBoardTree($restrict = false, $id_owner = null)
 {
-   global $cat_tree, $boards, $boardList, $txt, $settings, $user_info;
+   global $cat_tree, $boards, $boardList, $txt, $settings;
 
-   $restriction = $user_info['is_admin'] || !$restrict ? '' : '
-            AND b.id_owner = ' . (int) $user_info['id'];
+   $restriction = $id_owner && $restrict ? '
+            AND b.id_owner = ' . (int) $id_owner : '';
 
    // Getting all the board and category information you'd ever wanted.
    $request = wesql::query('
@@ -1115,7 +1127,7 @@
          b.redirect_newtab, b.num_posts, b.language, b.num_topics, c.id_cat, c.name AS cat_name, c.cat_order, c.can_collapse
       FROM {db_prefix}categories AS c
          LEFT JOIN {db_prefix}boards AS b ON (b.id_cat = c.id_cat)' . $restriction . '
-      ORDER BY c.cat_order, b.child_level, b.board_order',
+      ORDER BY c.cat_order, b.board_order, b.child_level',
       array()
    );
    $cat_tree = array();
@@ -1170,7 +1182,7 @@
          $prevBoard = $row['id_board'];
          $last_board_order = $row['board_order'];
 
-         if (empty($row['child_level']))
+         if (empty($row['child_level']) || !$boards[$row['id_parent']])
          {
             $cat_tree[$row['id_cat']]['children'][$row['id_board']] = array(
                'node' => &$boards[$row['id_board']],

  • Add to modifyBoard()
  • Change how a board owner is defined: what if a moderator decides to modify a user's board in their behalf? Also, in the future profile boards section, I think an admin should only see the boards with a defined owner. (I should note that this will affect the existing boards management; at least one said area imposes the restriction.
  • Change the sorting order of the query. I had a second-level board appear appear after a first-level board when they were supposed too be flipped. After changing the code, I played with moving some boards around and all appears to work as expected.
  • A second-level board had no parent according to the function because its parent had a different owner. This would trigger an error. The changed code doesn't feel right, but prevents the error.
41
Bug reports / Re: Recent posts does not honor topic privacy
« on April 5th, 2012, 08:09 AM »
Yes
Posted: April 5th, 2012, 08:05 AM

Create a topic, set privacy to author, login as another user, look in recent posts, still there. It's hidden in message index.
42
Bug reports / Recent posts does not honor topic privacy
« on April 5th, 2012, 03:53 AM »
Title says it all.

Didn't write down current rev this is on; it's from yesterday.
43
Quote
Not even necessary to shorten it (javascript will take care of this aspect :P).
What if they have JS off?
44
It follows MySQL's AUTO_INCREMENT value, no?
45
Bug reports / Re: Possible incorrect behaviour in fatal error handling?
« on February 29th, 2012, 05:20 AM »
I got that behavior as well when working on my post-related plugin.
Posted: February 29th, 2012, 05:16 AM

(Topic  #1,000!)