« [Bug] Unable to reply a post
SMorg
Topic Cache Triggers IDM »

billy2

  • We-Gen
  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 348
SMorg
« on April 18th, 2012, 03:56 PM » Last edited on April 18th, 2012, 04:14 PM
SMorg topic with fix

Same on Wedge - seem to be able to type forever

Cheers

Where are all these bbc url tags coming from??
<br /><br />cough, cough.

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,596
Re: SMorg
« Reply #1 on April 18th, 2012, 04:36 PM »
The bbc url tags keep appearing as a result of a known bug in Wedge that we have narrowed down from thousands upon thousands of lines of code to a few dozen - but not yet figured out exactly *where*.

As for this one, the profile fields do need going back over, and as discussed, size should be used anyway (which will do more than just fix the maxlength of the HTML textbox)
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

billy2

  • We-Gen
  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 348
Re: SMorg
« Reply #2 on April 18th, 2012, 04:58 PM »
I knew you would be on the case
 :cool:
Cheers
<br /><br />cough, cough.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,893
Re: SMorg
« Reply #3 on April 18th, 2012, 05:09 PM »
Title fixed locally. And here. I think.

The url bug... Well, it's probably a case of "I don't want to fix it before I understand why it works in SMF and not in Wedge..." :P
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,596
Re: SMorg
« Reply #4 on April 18th, 2012, 07:11 PM »
Quote
The url bug... Well, it's probably a case of "I don't want to fix it before I understand why it works in SMF and not in Wedge..."
It works in SMF because SMF doesn't have the extra changes that we've made plus what was in Aeva. Comment out the call from aeva_on_posting() to aeva_autolink_urls() and it should work fine.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,893
Re: SMorg
« Reply #5 on April 18th, 2012, 07:34 PM »
Instead of doing that (again -- I don't know why it works in SMF and not here?), I've changed onposting to be stricter (i.e. refuse anything that starts with [url]). Can you test it in the Test board? :)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,596
Re: SMorg
« Reply #6 on April 18th, 2012, 07:38 PM »
Looking at it, it appears to work :)

My test case: (i.e. bare URL, url tagged, url tagged with separate caption, then all three repeated for a YT URL)

Code: [Select]
http://example.com/

[url]http://example.com/[/url]

[url=http://example.com/]example.com[/url]

http://www.youtube.com/watch?v=OBGOQ7SsJrw

[url]http://www.youtube.com/watch?v=OBGOQ7SsJrw[/url]

[url=http://www.youtube.com/watch?v=OBGOQ7SsJrw]Conan The Barbarian: The Musical[/url]

Notice that in the latter two cases, it's made widescreen while the bare URL case is not.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,893
Re: SMorg
« Reply #7 on April 19th, 2012, 06:55 PM »
So, is anyone getting more issues with url tags now? No? Good :)

I think it's worth pointing out that I was going to copy my newly rewritten url auto-linker into Wedge's parse_bbc() code, until I noticed that, ahem.... SMF 2.0 had already done exactly the same... :lol:
Well, I know that I'm not the first SMF-related coder who's actually capable of doing complex regexes (lookarounds aren't exactly the most complex of all, they're just not for your average dev), but it's kinda upsetting not to be first on that piece of code, ahah. I just don't like reinventing the wheel!
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,596
Re: SMorg
« Reply #8 on April 19th, 2012, 07:16 PM »
Remember that Karl was actually an SMF dev at one point ;)
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,893
Re: SMorg
« Reply #9 on April 19th, 2012, 07:35 PM »
Yep, but not for long... Only a few months I think? And Karl is the one who wrote the autolink code for Aeva, and IIRC he took whatever was in SMF at the time... So basically, maybe he was the one who changed that in SMF but I'd need to be able to access their old SVN to be sure... (And use that wonderful little tool called Blame...)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)
« [Bug] Unable to reply a post
Topic Cache Triggers IDM »