Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - live627
1
Bug reports / Re: Possible bug with custom fields
« on January 10th, 2020, 11:58 PM »
Eh, the code is what I did to keep the logs quiet.

And I did not send anything to the repo. This was on AeMe on SMF, so I have no idea if the code is even valid for Wedge.
2
Bug reports / Possible bug with custom fields
« on February 1st, 2019, 12:54 AM »
  • Create a custom field in the gallery
  • Make it a checklist
  • Make it required
  • Make it searchable
  • Edit an item, don't fill that field
  • Observe errors when saving
Code: [Select]
// Add them to the form
  foreach ($fields as $field)
  {
- if ($field['type'] == 'checkbox')
+ if ($field['type'] == 'checkbox' && empty($field['searchable']))
  $field['value'] = explode(', ', $field['value']);
 
  // Options...
  $value = isset($_POST['custom_field'][$field['id']]) && (is_array($_POST['custom_field'][$field['id']]) || trim($_POST['custom_field'][$field['id']]) != '') ? $_POST['custom_field'][$field['id']] : '';
 
+ // JTR: preparsecode() corrupts the array by converting it to a string.
+ if (isset($_POST['custom_field'][$field['id']]) && !is_array($_POST['custom_field'][$field['id']]))
- preparsecode($value);
+ preparsecode($value);
 
  // Do the value checks
  if ($field['type'] == 'checkbox')
  {
- foreach ($value as $val)
- if (!in_array($val, $field['options']))
- fatal_error(sprintf($txt['aeva_cf_invalid'], $field['name']));
-
  // Nothing set?
  if (empty($value) && $field['required'])
  fatal_error(sprintf($txt['aeva_cf_empty'], $field['name']));
  elseif (empty($value))
  continue;
 
+ foreach ($value as $val)
+ if (!in_array($val, $field['options']))
+ fatal_error(sprintf($txt['aeva_cf_invalid'], $field['name']));
+
  // Set the proper value
  $value = implode(', ', $value);
  }
3
Bug reports / Re: From Order... Chaos
« on July 29th, 2014, 07:29 AM »
MySQL and PHP version? Any board moderators?
4
Bug reports / SMF bug 4940: sending pm to user with quotes in name
« on April 29th, 2014, 10:24 AM »
Ref: http://dev.simplemachines.org/mantis/view.php?id=4940

How to reproduce;
1) Change your display name to user0 "first" blablabla
2a) Try to send pm to user0 "first" blablabla
2b) Do not use the auto suggest
3) Click send
5
Bug reports / Re : Re: Where should I put up the source code?
« on October 25th, 2013, 01:51 AM »
I think it was started on, but was never finished.
6
Bug reports / Re: Periodic notifications don't seem to work
« on September 23rd, 2013, 01:47 AM »
Quote from Nao on September 21st, 2013, 01:35 AM
How about triggering scheduled tasks only if the current user's language is the default..? Then at least we can avoid what happened last time.
I don't know what to say, sorry.
7
Bug reports / Re: Periodic notifications don't seem to work
« on September 19th, 2013, 09:18 PM »
Well, the email strings need to be moved to the EmailTemplate language file anyway, which loadEmailTemplate() loads anyway.
8
Bug reports / Re: Periodic notifications don't seem to work
« on September 19th, 2013, 05:15 PM »
Quote
Well, there's a part that got repeated twice in the original code (including SMF), now it's no longer the case.
You removed the hotmaill fix?
Quote
I'm thinking of loading the users per language file, and then re-loading all language files, but... Well, how am I supposed to do that..?!
$needed_language = empty($row['lngfile']) || empty($settings['userLanguage']) ? $settings['language'] : $row['lngfile'];
$emaildata = loadEmailTemplate($message_type, $replacements, $needed_language);
sendmail($row['email_address'], $emaildata['subject'], $emaildata['body']);;
9
Bug reports / Re: Periodic notifications don't seem to work
« on September 19th, 2013, 04:59 AM »
So I got the email this morning, but it was in French, and had no line breaks.
10
Bug reports / Re: Cleaning up duplicate language strings
« on August 26th, 2013, 02:12 AM »
up
11
Bug reports / Re: req_win bug
« on August 24th, 2013, 02:43 PM »
Code: [Select]
ask(tmp.innerHTML, null, function (answer)
{
// do stuff

if (answer)
// they hit OK
});

Is that 200 bytes?

tmp is a DOM element with an input, a select, a textarea, and some labels.

The callback is fired when the textual input is clicked.
12
Bug reports / Re: req_win bug
« on August 23rd, 2013, 09:57 PM »
@Nao> You wrote it ages ago. Now it's high time to use it.
13
Bug reports / req_win bug
« on August 23rd, 2013, 04:29 PM »
Suppose ask() is abused slightly to show a small form for input from the user. All <input> elements inside the popup get a click event and are populated with text.

Code: [Select]
/Themes/default/scripts/script.js (working copy)
@@ -189,7 +189,7 @@
  .html('<section class="nodrag confirm">' + string + '</section><footer><input type="button" class="submit'
  + (modal_type == 1 ? ' floatleft" /><input type="button" class="delete floatright" />' : '" />') + '</footer>')
  .each(animate_popup)
- .find('input')
+ .find('footer input')
  .val(we_cancel)
  .click(function () {
  close_window();
14
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:52 PM »
Example: some of the get***() methods are present in both Notification and Notifier.
15
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:27 PM »
Commit it and I will test it.
Quote
If you get that, you're already halfway through the system.
Oh, that's the easy part. What's confusing for me is the presence of same-name methods across multiple objects.