SMF reaction to 'unused, useless globals'

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: SMF reaction to 'unused, useless globals'
« Reply #15, on November 18th, 2013, 11:14 PM »
Quote from emanuele on November 18th, 2013, 10:58 PM
Until a while ago that board was open to friends as well, apparently now
It had been for years. I had access to it even for the whole time I was post-banned at sm.org... And until recently, was still the case. Basically, I think they removed access for Friends after I picked up a topic where Arantor was criticizing me, and thought he was safe in a 'private' area. After I debunked his lies (still in private!), I guess the SMF team figured that they didn't want to piss Arantor off, and decided to kick me (and all Friends) out of that board.

I haven't checked, but I don't see any other plausible explanation.

So, now Pete can safely lash out at me, when he used to always agree that if we were to lash out at someone, it should be *in a place where they could defend themselves*. Because neither he nor I appreciated being the object of criticism behind our backs.

I guess his 'morals' and 'intellectual honesty', of which he used to be so proud, are solvable in vinegar. ::)
Quote from emanuele on November 18th, 2013, 10:58 PM
the board has been closed down[1].
 1. I can just assume in order to avoid that a competitor would be able to read the development secrets...sorry guys, I may have spoiled you the fun... :(
Well, fact is, I don't read that board, so it doesn't change anything for me. Simply, as it was part of my 'readable boards', it would come up in search results when I did a search on recent posts mentioning 'wedge' or 'nao', as I do from time to time. (Now that I've made it clear what my search keywords were, I've also noticed Pete started to avoid using them, presumably to make it harder for me to find posts where he lashes out at me. Fine by me, that's less time to waste on futile flame wars.)
Posted: November 18th, 2013, 11:12 PM

Split into its own topic. It has little to do with optimizing code, at this point, more like optimizing relationships, or the lack thereof. ;)

runic

  • To be or not to be that is the question ....
  • Posts: 54
Re: SMF reaction to 'unused, useless globals'
« Reply #16, on December 10th, 2013, 02:55 AM »
if its Dev (private) you shouldnt have access unless you are listed as Dev Consultant, I could tell you more if I got the exact board though I cant see permission changing that much since I left.

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: SMF reaction to 'unused, useless globals'
« Reply #17, on December 10th, 2013, 01:01 PM »
I don't really care at this point.
Seriously... If the SMF team had wanted to be 'nice' to me, they would have done at least a few of these, in any order:
- ensured my access to any boards wasn't changed AFTER Pete rejoined them,
- offered me to join as well (I would have said no, but it would have been a show of good faith, and at no cost to them),
- told Pete that since he's part of the SMF team, anything bad he's saying about Wedge is in contradiction with the frigging SMF Team Member Agreement,
- and generally, done anything to show me they didn't see me as the miserable bastard they like to think of me.

Come to think of it, I don't know why I keep Aeva Media online over there. Dunno why they'd deserve a quality gallery mod which took years of work to complete. :-/

Or maybe it's simply because I don't care at all about SMF, in the end. What Pete does with their outdated software, as long as it doesn't involve taking my code and innovations to their codebase (because, WTF!), I really couldn't care less about.


Nao

  • Dadman with a boy
  • Posts: 16,078
Re: SMF reaction to 'unused, useless globals'
« Reply #19, on January 8th, 2014, 11:26 PM »
Yeah... But of course, he'd never admit that it was thanks to the very script he dismissed as silly, would he now...? :whistle:
There's still tons (hundreds?) of unneeded globals left, though. A huge difference compared to the 3 left in Elk (not counting the ones in install.php), and the zero in Wedge[1].
 1. One, actually... I committed an unneeded global today. Lulz. I'll fix that in the next commit.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,668
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: SMF reaction to 'unused, useless globals'
« Reply #21, on January 16th, 2014, 11:25 PM »
Fixing manually, yes, that's what I did on many on my files too.
But *finding* them manually? No way... Nobody's a psychic. So, the only tools at his disposals were: (1) any IDE that has that feature (e.g. Eclipse or NetBeans, one of these two, can't remember, provides small icons next to lines with unneeded globals), (2) fix-globals.php...

Hey John, I thought you were gone back to SMF forever. Or maybe you really are? Two months without a post... :^^;:

emanuele

  • Posts: 125
Re: SMF reaction to 'unused, useless globals'
« Reply #22, on January 17th, 2014, 10:39 AM »
Quote from Nao on January 16th, 2014, 11:25 PM
But *finding* them manually? No way... Nobody's a psychic. So, the only tools at his disposals were: (1) any IDE that has that feature (e.g. Eclipse or NetBeans, one of these two, can't remember, provides small icons next to lines with unneeded globals), (2) fix-globals.php...
Technically you *can* find and fix anything manually, IDE and fix-globals are a way to automate the task.

For example, I'm currently scanning the whole code looking for input or selects without a label:
https://github.com/emanuele45/Dialogo/tree/labels
and I'm doing it manually... 1572 input tags.
There are two drawbacks with that method:
1) it takes a shitload of time,
2) every time you start something like that on an SMF-like codebase you end up rewriting small or large parts of the code you encounter (in that branch I already did it twice and I almost just started LOL).

That said, automation FTW!! :D

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: SMF reaction to 'unused, useless globals'
« Reply #23, on January 17th, 2014, 10:44 AM »
Quote from emanuele on January 17th, 2014, 10:39 AM
Technically you *can* find and fix anything manually, IDE and fix-globals are a way to automate the task.
Something like 1500 unneeded globals..? I don't think so. ;)
Quote from emanuele on January 17th, 2014, 10:39 AM
For example, I'm currently scanning the whole code looking for input or selects without a label:
https://github.com/emanuele45/Dialogo/tree/labels
and I'm doing it manually... 1572 input tags.
There are two drawbacks with that method:
1) it takes a shitload of time,
Which is why I wrote the script in the first place. I figured it'd be faster than even going through my files with Netbeans or something. (It was.)
Quote from emanuele on January 17th, 2014, 10:39 AM
2) every time you start something like that on an SMF-like codebase you end up rewriting small or large parts of the code you encounter (in that branch I already did it twice and I almost just started LOL).
Yeah, it's one of my 'minor' character issues, too... :P
I did that for the calendar plugin, for instance. Was fixing some CSS, ended up rewriting something else.