« Plugin server
The whole "core feature" thing
[Plugin] Improved attachments upload »

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #15, on March 11th, 2013, 06:38 PM »
Here's a third option (for real). The entire thing goes into Sources, Themes, languages folder with each file going in there respective places. But it still uses hooks. I can see this working, this way it cannot be disabled easily, still uses hooks, require no crappy rewrites (barring a couple of changes in the core plugin itself). I do loose my GitHub repository :P...
The way it's meant to be

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #17, on March 11th, 2013, 06:46 PM »Last edited on March 11th, 2013, 06:53 PM
Quote from Arantor on March 11th, 2013, 06:42 PM
I don't want to make you lose your repository if it's at all possible :(
There are a couple of ways to avoid that

1) Let it be a pure plugin (and we're back to square one), now that I think about it, a special "core plugin" isn't a great idea. It's either fully plugin or fully core
2) This is something I'm taking from how Android gets built, that thing is distributed to atleast 50 repositories. Make a separate script that'll automatically fetch external dependencies and compile them into the core build. Notifications and other plugins being some of them. It shouldn't be too hard, I can perhaps do it if everyone's on board the idea. It probably does complicate things a bit (perhaps unnecessarily).

I can't honestly think of a way that'll work for all of us. Perhaps leave it as a plugin for now and re-visit this when Wedge's beta or something? Then we'd have more input, especially from active users

kimikelku

  • Posts: 61
Re: The whole "core feature" thing
« Reply #18, on March 11th, 2013, 06:57 PM »
It could be done like, when we are installing wedge, it could ask if we want to install those plugins, something like they do with toolbars when we install some programs :niark:

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: The whole "core feature" thing
« Reply #19, on March 12th, 2013, 12:52 AM »
Quote from kimikelku on March 11th, 2013, 06:57 PM
It could be done like, when we are installing wedge, it could ask if we want to install those plugins, something like they do with toolbars when we install some programs :niark:
I'd assume from that smiley that you jest, but if that were implemented (!!), the installer would also ask for FTP access.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: The whole "core feature" thing
« Reply #20, on March 12th, 2013, 12:55 AM »
Nah, the smiley is related to the whole 'here's a free program, would you like to install some crappy toolbar while you're installing this free program?' Like various of the torrent software trying to foist Ask toolbars on you.

If I were seriously going down that road, I'd actually write a system to prepare builds on the server and let people build packages together if it's optional.

But something like notifications is not something I'd want as an 'optional' feature if that makes sense.

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #21, on March 13th, 2013, 10:11 PM »
What if the notification core goes into Wedge's core completely and most of the notifiers remain as plugins?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: The whole "core feature" thing
« Reply #22, on March 13th, 2013, 10:11 PM »
That seems logical, though it might confuse people as to why they aren't getting notifications. At the very least I think replies to posts would need to be a core feature if the notification innards becomes core.

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #23, on March 13th, 2013, 10:13 PM »
No, some essential ones will also be in the core along with notifications and the subscriptions core. But the less important ones remains as plugins.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #25, on March 13th, 2013, 10:19 PM »
Okay, so how do they go in? I guess the two core plugins will be directly into the sources. Will the essential notifiers also be embedded into sources?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: The whole "core feature" thing
« Reply #26, on March 13th, 2013, 10:29 PM »
Ideally, they'd go in directly to the sources, including loadSource calls etc. as necessary with direct function calls as and when appropriate.

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: The whole "core feature" thing
« Reply #27, on March 13th, 2013, 10:32 PM »Last edited on March 14th, 2013, 08:01 AM
Quote from Arantor on March 13th, 2013, 10:29 PM
Ideally, they'd go in directly to the sources, including loadSource calls etc. as necessary with direct function calls as and when appropriate.
Okay....last thing, who's gonna do this? :P

EDIT: I merely ask because I cannot commit to Wedge's repository, so will you or Nao do it or should I make a diff patch?
Re: The whole "core feature" thing
« Reply #28, on March 14th, 2013, 10:16 AM »
And yeah, I'd like to get this in the repository ASAP. After that we can start stripping out the existing subscription stuff and re-implement any missing features.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: The whole "core feature" thing
« Reply #29, on March 14th, 2013, 04:26 PM »
Well, the problem with stripping the existing subscription stuff is that you're still going to get people who want email notifications of crap >_<

XenForo does the same thing, though in XF's case they call it 'Watched Threads' so while you'd get an 'alert' (or notification) of a reply, if you've watched the thread, you'll also get an email about it.

I left a message with Nao about what to do regarding repo access, but I get the feeling a diff might be easier.
« Plugin server
[Plugin] Improved attachments upload »