« Converting WedgeDesk
Active Members
[Plugin Screenshots] Invitation Only Topics »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #15, on October 14th, 2012, 12:17 AM »
There's also a problem with the URL for the admin icon, but I haven't looked into it yet.

Yeah my to-do list isn't public, but I posted some of it a few months ago... ;)
Maybe I should clean it up and post the entirety of it. Plenty of ideas for people to exploit!

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #17, on October 14th, 2012, 07:27 AM »
Quote from live627 on October 14th, 2012, 12:24 AM
Wait, ideas can be exploited now? :lol:
So many little things that wouldn't take more than a day to implement, and yet I haven't been working on because, well, I just lack motivation for them...
Quote
Also, I clicked the (more) link here and nothing happened. Firebug did not show a data-eve on it. Or onclick. Or whatever.
What 'more' link..?! Where?

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Active Members
« Reply #18, on October 14th, 2012, 09:01 AM »
I already sent a link  in my last post. I am talking, of course, of the more link when in excess of 10 active members are found...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #19, on October 15th, 2012, 03:32 PM »
Quote from live627 on October 14th, 2012, 09:01 AM
I already sent a link  in my last post. I am talking, of course, of the more link when in excess of 10 active members are found...
Alrighty.

Clicked link.

Opened a popup for me...

Using Firefox 17 (Aurora).

agent47

  • Now I see the changes you're talking about.
  • Posts: 115
Re: Active Members
« Reply #20, on October 15th, 2012, 04:08 PM »Last edited on October 15th, 2012, 04:49 PM
I'm using Chrome Version 22.0.1229.94 m and Firefox 15.0.1. When I click the 'more' that you guys are talking about, the screens just fades and that's it. No popup box or anything.

And also just out of curiosity I know it displays member names in the order of the number posts made on that topic but how does it choose between two members who've made the equal number of posts on that topic? 'cause I noticed that the member "Antes" was literally the second poster on that thread and yet his name has been pushed into the "more" list. Is it based on a member's overall post count because it can't be alphabetical either as I see the member "Zootalaws" who's made one post himself among the ten displayed members.

Edit: no wait it can't be based on a member's overall post count either. Confused... Random order?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Active Members
« Reply #21, on October 15th, 2012, 04:13 PM »
The popup throws a 'unable to find the main template' error. (As in looking up the URL the popup requests, that's the problem)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #22, on October 15th, 2012, 04:16 PM »
action=activemembers;t=6998 returns an error 403 for me when I'm logged out, resulting in a popup never showing...
So it's probably down to a wrong permission out there.

:edit: Ninja'd...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Active Members
« Reply #23, on October 15th, 2012, 04:17 PM »
Yup. The 403 is because fatal_lang_error always pushes out HTTP 403 by default, though you can override that to whatever error code you like.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #24, on October 15th, 2012, 04:18 PM »
Hmm, there IS an active_members permission out there.
I didn't notice in the first place.

Maybe the plugin area should indicate whether a plugin is associated with permissions, and give a link to them...? Maybe..?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Active Members
« Reply #25, on October 15th, 2012, 04:29 PM »
Or better still, do what I always intended should be done and use the settings-page to do it.

Firstly, use the correct type for <text name="activemembers_num" /> - it should be an int (which also allows setting min, max, step, size), it's a number, not a text string.

Secondly, adding the permission to the settings page. <permissions name="view_active_members_own" /> and <permissions name="view_active_members_any" /> though you'll need to make strings for them too. (And the <newperms> block still has to be left present too.)

The reason for that is because so many people got confused that they have to set permissions in somewhere other than the plugin's own area. So instead, put the permissions in the plugin's settings page.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #26, on October 15th, 2012, 04:48 PM »
Does it work with per-board perms..?
Posted: October 15th, 2012, 04:46 PM

Hmpf... I've enabled the permission for guests and members alike. It still doesn't seem to work...

Have no time to work on this further for now, though.

Oh, and while I'm at it... I guess the #1 thing to do with the plugin is to ensure the word 'more' isn't linkable when the user doesn't have permission to view that popup... Would have saved me some debugging time ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Active Members
« Reply #27, on October 15th, 2012, 04:56 PM »
Quote
Does it work with per-board perms..?
No, but mostly because there's simply no sane way to handle that permission in a UI that is designed to be constrained inside the confines of a simple settings page.
Quote
Hmpf... I've enabled the permission for guests and members alike. It still doesn't seem to work...
Mostly because it's actually buggy. The permission is defined in the permissions as an own/any pair (and that relates to my comments above) but it's used in active_members_action as a simple permission, as allowedTo('view_active_members')

It needs to be one or the other.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Active Members
« Reply #28, on October 15th, 2012, 08:18 PM »
I'm guessing the line should be something like that...?

Code: [Select]
if (allowedTo('view_active_members_any') || ($topicinfo['id_member'] == $user_info['id'] && allowedTo('view_active_members_own')))
Posted: October 15th, 2012, 08:17 PM

Hmm, not working... :-/

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Active Members
« Reply #29, on October 15th, 2012, 08:18 PM »
Define 'not working'...
« Converting WedgeDesk
[Plugin Screenshots] Invitation Only Topics »