« Light URL Plugin Maybe?
Which next? [Poll]
[Plugin Screenshots] To Do List »
Poll

What should I write next?

A shoutbox/AJAX chat system
3 (15.8%)
An ad manager
7 (36.8%)
Something like vBookie (which will require a points/currency system to be written first)
0 (0%)
Something else (please reply, note I might add it as an option later)
1 (5.3%)
A tournament system
3 (15.8%)
Treasury/donation manager
5 (26.3%)
Total Members Voted: 16

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Which next? [Poll]
« Reply #45, on April 3rd, 2012, 05:56 PM »
Quote from Arantor on April 3rd, 2012, 04:50 PM
Of that list...
* nofollow bbcode - what exactly should it do? There's a lot more to it than simply adding the base bbcode, it is essentially duplicating the url bbcode including all the preparsing and calls to fixTags.
I was thinking of a tag that would turn all links *inside* its contents to nofollow... Should be rather easy to take the body, and do a regexp on it... (Although it would have to be done last. And I'm not sure whether Wedge converts tags as it finds them, or by nesting level, and even then, top-level or low-level first..?)
Quote
* merging likes - yeah, I forgot about that. I'll look at that shortly, should be relatively quick to implement.
Yep ;)
Quote
* smartphone/tablet icons should be doable enough; the user agent is stored in the log_online table when the action is also logged, so it's not as if it's a huge ask to figure that out, really. Might be nice, actually.
Yeah, sometimes I have nice little ideas like that... :eheh:
It's the kind of thing that could help socially... "Okay I've sent this guy a PM, he's online but why isn't he replying...?"
---- Because it sucks to answer a PM or anything with quotes on a smartphone :P
Quote
* A-Z keystrokes, yeah, that's bitten me when I've set a different privacy and forgotten to click on the textbox again, heh.
Yes, and in iOS mode it's worse -- if you select a privacy and then type a thought, it'll reopen the select box. This is because Wedge doesn't remove focus from the select box when it's closed. It was actually a personal preference -- I thought that in terms of UI, it behaved more logically for people who used a keyboard. And indeed it works when you use tab to get out of the box. But if you click, it doesn't always focus it out... Maybe it's ONLY an iOS bug, I don't know.
Quote
But it needs to be 0-9 plus A-Z, since I can well imagine numeric entries as well as textual ones
Any key > 0x20, really...
Quote
* resize JS... that does depend on whether Zoomedia is used or not, really, since it may or may not be applicable then.
Indeed. It was more of a... transition before doing the Zoomedia stuff.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Which next? [Poll]
« Reply #46, on April 3rd, 2012, 06:01 PM »
Quote
I was thinking of a tag that would turn all links *inside* its contents to nofollow... Should be rather easy to take the body, and do a regexp on it... (Although it would have to be done last. And I'm not sure whether Wedge converts tags as it finds them, or by nesting level, and even then, top-level or low-level first..?)
As it finds them. It steps through the post, looking for each instance of a ], and parses as it finds, with the exception of code tags which are handled separately - first.
Quote
Yeah, sometimes I have nice little ideas like that... :eheh:
It's a good idea, but I think it should also be an option too.
Quote
if you select a privacy and then type a thought, it'll reopen the select box. This is because Wedge doesn't remove focus from the select box when it's closed. It was actually a personal preference -- I thought that in terms of UI, it behaved more logically for people who used a keyboard.
But of course if you're normally using a keyboard/mouse combo, you'll click, but the selectbox still has focus even when it seems like it shouldn't have.
Quote
Any key > 0x20, really...
There aren't that many keys you really need to worry about, 0-9 and A-Z are really it, rather than any printable character.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Which next? [Poll]
« Reply #47, on April 3rd, 2012, 06:06 PM »
Quote from Arantor on April 3rd, 2012, 06:01 PM
As it finds them. It steps through the post, looking for each instance of a ], and parses as it finds, with the exception of code tags which are handled separately - first.
So, I guess it could be done only by parsing nofollow tags after all other tags, like for the footnote tag...
Quote
It's a good idea, but I think it should also be an option too.
Of course. And you know how I hate manipulating UI stuff... :P

Oh, speaking of UI... The Media area's menu is pretty fucked up when it comes to doing contextual tabs. Because it's made up of various sections that aren't physically linked, it's not possible to automatically generate the contextual tabs through template_generic_tabs or whatever. I had to add a 'force_tabs' option to 'skip' looking through the menu array and just use whatever data force_tabs provides instead. Still, it's broken... I don't know if there's much of a point in doing that.
My main concern was that AeMe uses template_button_strip to basically show what is a contextual tab strip of related areas in the menu... Meh.
Any opinion?
Quote
There aren't that many keys you really need to worry about, 0-9 and A-Z are really it, rather than any printable character.
Maybe "=", too... Things like that...
Anyway, I think I should just remove focus, like a regular sbox.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Which next? [Poll]
« Reply #48, on April 3rd, 2012, 06:32 PM »
Quote
So, I guess it could be done only by parsing nofollow tags after all other tags, like for the footnote tag...
It depends how much inelegance you'd be prepared to put up with, and possible performance issues. It would be possible to add a flag in when the tag is detected to be 'nofollow' and reset it when closed, and use that flag in conjunction with the validate function for URL tags. But not the best way it could be handled.
Quote
Of course. And you know how I hate manipulating UI stuff...
I like writing interesting UI, I hate writing dull UI - like the ad management one.
Quote
My main concern was that AeMe uses template_button_strip to basically show what is a contextual tab strip of related areas in the menu... Meh.
Any opinion?
I'd personally rather it be rewritten to be the same structure and style as other uses of the generic menus, which also means it would be possible to cleanly extend it with hooks etc. if authors want to do so. But it's ultimately your baby and I'd rather let you make that call.
Quote
Maybe "=", too... Things like that...
Anyway, I think I should just remove focus, like a regular sbox.
I can't see = ever being used properly in a selectbox (outside the admin panel in which case people are almost certainly not using the keyboard). But yeah, I agree that removing focus would be better.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Which next? [Poll]
« Reply #49, on April 3rd, 2012, 11:00 PM »
Quote from Arantor on April 3rd, 2012, 06:32 PM
It depends how much inelegance you'd be prepared to put up with, and possible performance issues. It would be possible to add a flag in when the tag is detected to be 'nofollow' and reset it when closed, and use that flag in conjunction with the validate function for URL tags. But not the best way it could be handled.
Scratch that.
Could be done through a post-group permission... (Easiest example.)
When showing a post, if they don't have permission to get rid of nofollow, go through the anchor tags in the post and add a nofollow.
I'm not sure it's the best option (especially, where do we determine the permission for the *author* rather than the current user...?), but it's better than a nofollow tag which itself is unlikely to be used by anyone... (If you don't want to give PR juice to someone, then just don't link to them. Or use a code tag around the link...)
Quote
I'd personally rather it be rewritten to be the same structure and style as other uses of the generic menus,
Let me explain. There are two menus in AeMe, basically.
- The admin area's menu, which basically does things the same way as other areas do,
- And the media area's menu, which itself is built entirely on custom URLs and won't show contextual tabs for that reason.

I rewrote the media area menu to show said tabs, but it's not working perfectly. You can already have a look here (only works on the Moderate section, though, as Admin redirects to the admin area, Albums only show one tab, and Home doesn't show anything.)
I still need to replace the 'Media' we:cat's with a we:cat that says the actual section name (it used to, it just won't for now...)

Now, the question would be: is there a point in offering contextual tabs in the media area...? I think there is, but OTOH, perhaps it takes space in the upper area that would be better used by something else... (And if I start adding a 'description' for each entry, they'll take even more space I guess. But a description would be nice for some areas like Add Album...)
Quote
which also means it would be possible to cleanly extend it with hooks etc. if authors want to do so.
Well, I suppose it's all automated even in the current SVN version...?
It's just that the contextual tab code is a bit messy. I think it's because Dragooon wrote it back when he wanted to support SMF1 as well... And I've always hated the code for contextual tabs (you need a PhD to decrypt it), so no one bothered to change it again.
Quote
I can't see = ever being used properly in a selectbox
No, but using it in an input box could lead Wedge to open a list of boards in a select box to a section that says "===> Board"... Although I don't think there should be any case of this happening.
Quote
(outside the admin panel in which case people are almost certainly not using the keyboard). But yeah, I agree that removing focus would be better.
Oh oh... This means I'll have to look into my sbox code again... :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Which next? [Poll]
« Reply #50, on April 5th, 2012, 02:48 AM »
Quote
Scratch that.
Could be done through a post-group permission... (Easiest example.)
When showing a post, if they don't have permission to get rid of nofollow, go through the anchor tags in the post and add a nofollow.
I'm not sure it's the best option (especially, where do we determine the permission for the *author* rather than the current user...?), but it's better than a nofollow tag which itself is unlikely to be used by anyone... (If you don't want to give PR juice to someone, then just don't link to them. Or use a code tag around the link...)
Don't make it a post count *permission* but make it based on post count separately. Karl wrote a mod for sm.org which was later turned into a public mod that works on this basis (Anti Spam Links) So it's certainly feasible to approach and doing it in core would be neat.
Quote
Now, the question would be: is there a point in offering contextual tabs in the media area...? I think there is, but OTOH, perhaps it takes space in the upper area that would be better used by something else... (And if I start adding a 'description' for each entry, they'll take even more space I guess. But a description would be nice for some areas like Add Album...)
I see what you mean. The way I see it, if the tabs are going to be used, it should be cleaned up and set up much as the others are set up, for consistency and it will make it extensible through plugins should folks want to.

But that's not to say the tabs have to be used. Whatever makes the most sense UI-wise; considering that the post layout for example has contextual UI.
Quote
Well, I suppose it's all automated even in the current SVN version...?
No, but if it's set up much as the others are, adding it in then becomes a matter of just adding a hook which receives the menu structure, but if it's a lot more complex, setting it up requires more thought and work.

You're right that the tab code is a mess generally, and it would be nice to properly harmonise things, since the profile and admin menus are set up differently (as there's pre-processing to handle permissions, as opposed to passing them to the menu handler)
Quote
No, but using it in an input box could lead Wedge to open a list of boards in a select box to a section that says "===> Board"... Although I don't think there should be any case of this happening.
I don't imagine it would really be used that way, as such I have no qualms about restricting = from being used in the SB as a keyboard shortcut.
« Light URL Plugin Maybe?
[Plugin Screenshots] To Do List »