Should we be careful to namespace the hooks? (Yes of course but...)
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Language hooks are, they're all prefixed with lang_ for that reason after I inadvertently created it with the same name as the determining-actions hook later in Who's Online during testing.
The others, the namespacing only needs to go as far as broad area though I haven't even done that with what I've added - we could have profile_, admin_ and similar prefixes. The more we add, the more important it is that we have namespaces.
Any add-on that adds its own probably should get into the habit of namespacing its own anyway (as WedgeDesk does)
The others, the namespacing only needs to go as far as broad area though I haven't even done that with what I've added - we could have profile_, admin_ and similar prefixes. The more we add, the more important it is that we have namespaces.
Any add-on that adds its own probably should get into the habit of namespacing its own anyway (as WedgeDesk does)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Yup.
We should also check for consistency in current hooks.
We should also check for consistency in current hooks.
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
I already have a list of all the hooks currently in Wedge. They're consistent in as far as they have short, descriptive names.
Code: [Select]
<?php
function knownHooks()
{
return array(
'language' => array(
'lang_who',
),
'function' => array(
// Cornerstone items
'pre_load',
'determine_location',
'detect_browser',
'load_theme',
'menu_items',
'actions',
'behavior',
// Threads and posts display
'display_prepare_post',
'display_post_done',
'messageindex_buttons',
'display_buttons',
'mod_buttons',
// Admin
'admin_areas',
'admin_search',
'modify_modifications',
'core_features',
'addon_settings',
'output_error',
// User related
'login',
'validate_login',
'logout',
'change_member_data',
'verify_password',
'reset_pass',
'activate',
'delete_member',
'track_ip',
// User permissions
'load_permissions',
'illegal_perms',
'illegal_guest_perms',
// Content creation
'personal_message',
'create_post_before',
'create_post_after',
'modify_post_before',
'modify_post_after',
// Process flow and execution
'buffer',
'redirect',
'exit',
'dynamic_rewrite',
// Miscellaneous
'css_color',
'buddy',
'bbc_buttons',
'place_credit',
'media_areas',
'profile_areas',
'ssi',
'whos_online',
),
);
}tfs
-
-
- Wow! You guys have been busy beavers. :)
- Posts: 78
There isn't really the room which is why it isn't there already, but more configurable should fix that.Quote If you decide to keep them separate grids, at least put the assigned column in the Awaiting User Response grid.
And the ones which I've assigned to our accountant, which are waiting for her to close them, I can ignore those ones completely for now, but I can't really tell them apart from an important open ticket.
You mean, put the results of the tally plugin into the grid? Eeek, could get expensive, but I already have an idea for fixing that...Quote Tie a column in the grid to the tally plugin.
"God is dead." -Nietzsche 1883
"Nietzsche is dead." -God 1900
"Nietzsche is dead." -God 1900
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
But there's no way for me to know which ones belong to my boss, and which ones belong to a tech of ours whom I'd like to monitor.
Our accountant asked me if we could do it so that she could see which tickets were adding up big, and it seemed like a reasonable thing to want to know, though some filtering or reporting ability could do that also.
Right now, though, it's totally broken because I've removed the old install process and been converting it to Wedge's add-on format, which is no small job - in between writing the new installer ;)
There is a part of me that wants to go set up wedgedesk.com right now and start laying out all the plans I have for the future, but I'd rather wait until 1) WedgeDesk actually installs on Wedge cleanly (i.e. that Wedge can support it natively rather than how it's been done so far) and that 2) the permissions overhaul is complete so I have a single permissions area that everything's managed by.
tfs
-
-
- Wow! You guys have been busy beavers. :)
- Posts: 78
Let me know when and where it's appropriate, and I'll fire up the ol' feeback-o-matic. :)
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Can always PM me, I do already have a tracker set up for stuff to be done that I can add to, I just can't make that accessible to anyone else yet.
tfs
-
-
- Wow! You guys have been busy beavers. :)
- Posts: 78
Will do... though PM can't attach a file. I wanted to jog your memory of something that we touched on re email from a ticket, and I have a visual aide. :)
Email from the ticket is extremely nice BTW. Has worked without a hitch. Ticket monitoring is beautiful also. My only complaint is that I can't ping messages back and forth with another staff member without also pinging the client. Last night I worked late, and commented on a ticket several times back and forth with another staff, but we wished we didn't need to fill the client's email inbox with the discussion. Which reminded me of this possible alternate email checklist.
Email from the ticket is extremely nice BTW. Has worked without a hitch. Ticket monitoring is beautiful also. My only complaint is that I can't ping messages back and forth with another staff member without also pinging the client. Last night I worked late, and commented on a ticket several times back and forth with another staff, but we wished we didn't need to fill the client's email inbox with the discussion. Which reminded me of this possible alternate email checklist.
📎 EmailByDefault.PNG - 30.05 kB, 640x500, viewed 268 times.
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
In other news, I couldn't get my brain in gear to do some of the add-on manager stuff (been ill the last few days) so instead I fired up WedgeDesk and started adding one of the new layouts that it'll contain. (There are plans for four layouts for tickets. This is the second one.)
Look familiar, much? :lol:
Look familiar, much? :lol:
📎 wedgedesk_tracker_preview2.png - 27.4 kB, 640x368, viewed 252 times.
Dismal Shadow
- Madman in a Box
-
-
- Me: Who is Arantor? Cleverbot: It stands for time and relative dimensions in space.
- Posts: 1,185
Changes are good. Me like. :)
EXECUTE! |
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Look familiar, much? :lol:
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
So it looks nothing at all like Mantis :whistle:
Maybe if I put the colouring in...
Maybe if I put the colouring in...
PantsManUK
-
-
- [me=PantsManUK]would dearly love to dump SMF 1.X at this juncture...[/me]
- Posts: 174
I knew I'd seen that layout before... ;)
We use MantisBT at work (for the software we write), but I've been playing with RT recently for a personal project, so I couldn't be sure.
We use MantisBT at work (for the software we write), but I've been playing with RT recently for a personal project, so I couldn't be sure.
📎 Screenshot-My View - MantisBT - GGP Systems - Google Chrome.png - 38.5 kB, 640x388, viewed 246 times.
« What is this thing you hoomans call "Facebook"? »
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
RT is something I was made aware of but I really can't be arsed going through the steps to actually install it to play with, seeing how it uses Perl and I don't have Perl handy and don't really want to make yet another virtual machine to work on.
Mantis has a lot of things about it that I dislike and a few things I really like that may well migrate to WD in the future.
Mantis has a lot of things about it that I dislike and a few things I really like that may well migrate to WD in the future.