« Gotta share this, it's honestly too funny.
Already fixed SMF bug
MySQL Optimization question »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Already fixed SMF bug
« on September 8th, 2011, 03:52 PM »
Someone PM'd me about http://www.simplemachines.org/community/index.php?topic=451766.0 and the incorrect header being sent.

It's a valid bug, actually, in SMF, where the header varies depending on browser. I'm happy to report that we don't really do that, and that the rogue header isn't sent like that in Wedge.

We actually modified this behaviour months ago to send one header for IE because IE needs a slightly different header, and one for everyone else - which works, and isn't in the format that causes FF nightlies to fail.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Already fixed SMF bug
« Reply #1, on September 8th, 2011, 04:12 PM »
I don't remember ever touching that... Did you? (Maybe when we removed the non-utf8 code or something?)

I don't even know what it does :P
It's present in the Media download code though... Can you make sure it works there as well?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Already fixed SMF bug
« Reply #2, on September 8th, 2011, 04:15 PM »
Quote
I don't remember ever touching that... Did you?
Yes, I did, a long, long time. The idea was to harmonise the headers being sent because there were different headers being sent in the hopes of sanitising the filename into UTF-8 even if it wasn't already, for browsers to cope with. We're UTF-8 only, and have been for a long ol' time, so it ceased to be an issue.

Certainly it predates Media being integrated, and it may even predate Dlattach.php becoming its own file, that's how far back it was.

And IIRC you were the one who asked me to look into it at the time because you thought we didn't need multiple lines of headers...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Already fixed SMF bug
« Reply #3, on September 8th, 2011, 04:47 PM »
Oh well... I really don't remember a thing of it. We've manipulated dozens of thousands of lines of code, it's nothing surprised that my memory banks have reached their natural limit... :lol:

Still, since you seem to remember how it works, please have a look at the content-disposition headers for me in AeMe :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Already fixed SMF bug
« Reply #4, on September 8th, 2011, 04:50 PM »
Will do when I finish breaking WedgeDesk for this afternoon. ;)
« Gotta share this, it's honestly too funny.
MySQL Optimization question »