This topic was marked solved by its starter, on October 16th, 2016, 12:42 PM
Low flood/spam limits are ignored

CerealGuy

  • Posts: 343
Low flood/spam limits are ignored
«  »
spamProtection does not handle low limits correctly.

Example #1: If $settings['search_floodcontrol_time'] is 0 (disabled, not null/undefined) this setting will be ignored and a limit of 1 will be used instead.

Example #2: If user has moderator permissions, every limit will be overridden by 2. This does trouble if the set limit is lower than 2 (for example disabled).

PR: https://github.com/Wedge/wedge/pull/40

EDIT: Merged

Nao

  • Dadman with a boy
  • Posts: 16,029
Re: Low flood/spam limits are ignored
« Reply #2,  »
Dunno why I didn't get a github notification for that...
I've moved up the lines a bit, to avoid a useless permission check as well. Please tell me if I did it incorrectly. I was busy fixing another complex bug ;)

CerealGuy

  • Posts: 343