This topic was marked solved by Nao, on October 3rd, 2014, 01:28 AM

CerealGuy

  • Posts: 343
Input #userspec
« on September 26th, 2014, 07:24 PM »
Needs a "width: 100%", otherwise it's too big.
Tested on Firefox & Chrome (latest Ubuntu version).

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Input #userspec
« Reply #1, on September 27th, 2014, 12:51 PM »
Err... Where, exactly? Never seen any problems...

CerealGuy

  • Posts: 343

Jurien

  • All i want is a couple days off
  • Posts: 132
Re: Input #userspec
« Reply #3, on September 27th, 2014, 05:02 PM »
debugger shows size is out of range
<dd><input id="userspec" name="userspec" value="*" size="40"></dd>

Re: Input #userspec
« Reply #4, on September 27th, 2014, 07:59 PM »
It is not a width issue, it is a size of input field issue:


core/html/Search.template.php

Find:
Code: [Select]
<dd><input id="userspec" name="userspec" value="', empty($context['search_params']['userspec']) ? '*' : $context['search_params']['userspec'], '" size="30"></dd>

Replace with:
Code: [Select]
<dd><input id="userspec" name="userspec" value="', empty($context['search_params']['userspec']) ? '*' : $context['search_params']['userspec'], '" size="20"></dd>

Jurien

  • All i want is a couple days off
  • Posts: 132
Re: Input #userspec
« Reply #5, on September 27th, 2014, 08:20 PM »
Thanks BurkeKnight that's the solution.



Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Input #userspec
« Reply #7, on September 27th, 2014, 10:51 PM »
I think one of the reasons I don't like pull requests is that they force me to pull from the remote repo even on my personal copy and I always forget to do that...

Anyway done. But I still don't know which browser this affected because it works fine even on chrome mobile and Firefox for me...

Re: Input #userspec
« Reply #8, on September 27th, 2014, 10:54 PM »
No idea, but on all 3, was way too long for me.
Maybe different screen resolutions play a part in it?

As can see, I have the issue even here. As arrow shows...
However, before I reloaded my pc the other day, I did not notice it here.

 Wedge.png - 75.93 kB, 1242x563, viewed 60 times.


Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Input #userspec
« Reply #9, on October 3rd, 2014, 01:31 AM »
The bulk of the problem comes down to the fact that I was testing on a reduced window size, and it didn't use the same responsive behavior as what you guys tested on.
However, after I applied my fix, I realized mobile rendering wasn't great either, because it would cut off the popup on its left. So I made and pushed a patch to fix that, which actually makes things worse.

I hate this popup... It's a great feature, but it's horrible to develop.

Then again, most of the features I'm working on these days are horribly hard to do, which is why I'm taking so long to complete them... (I've been doing a rewrite of the Likes system that started easy, and ended up requiring unexpected database changes, you know the drill...)