This topic was marked solved by Nao, on September 27th, 2014, 12:51 PM
Contacts in profiles not saving
« on June 19th, 2014, 07:25 PM »
When check mark and submit query on selecting a contact option, it goes from the person's profile to mine, and if go look at their profile again, it's not selected.

Looks like it's not saving it, and just redirecting back to own profile.

Using copy downloaded from github this morning.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Contacts in profiles not saving
« Reply #1, on June 20th, 2014, 12:12 PM »
It's not a bug; as per my January 18 commit, I disabled the edit contacts feature (without actually removing the contact list for those who already had one built...), but forgot that the Save button was linked to said feature, so... Well, let's settle on half a bug!

Honestly, contact lists are a mess. I wanted to import my code from Noisen.com's feature, which is nicely made. I basically started using the UltimateProfile mod many years ago over there, then added my own customizations, and figured that I wanted it in Wedge. Only, I couldn't reuse the UP code, so I started to rewrite it, then linked it to privacy settings (which IIRC isn't as well done in Noisen), and then got killed by the UI.

You could say that admin UIs are my very own personal nightmare. I can write any kind of code you want, but admin UIs are a clusterfuck of bad ideas linked together by generations of developers who thought they knew better, and reinvented the wheel. So, basically, the admin area has many items that are built 'in a certain way', but not very flexible, and can't be used for situations not thought of by the original developers[1]. If it were up to me, I'd have replaced the admin area entirely with a new system, but it would have taken me months of work, and I thought that Pete was up to it... Only he didn't really work on that, he worked on changing the basic, functional admin homepage into a sad sad list of big icons. Every time I'm adding new pages to the admin area, I go through Hell and back. There are so many useless things to take into account! Admin pages have menu items! Page titles! Page <title>s! Descriptions! Sub-tabs or whatever! Permissions! And every time you want to change something, you have to make sure you update the Admin language file, AND the whatever-people-have-been-using other admin file that holds other language items! YAYZ!

No, seriously, this is quite disappointing. Every time I want to add a cool feature, the admin area gets in my way. The only way I managed to finally write the homepage builder in the admin area was that I used a simple textarea and, somehow, "stuck" to the SMF way of thinking... Heck, someone else can improve on that later. I just wanted to be done with that.
Now, I guess it's the contact list feature's turn...
 1. The Aeva Media situation is a bit special. It doesn't use much of the admin UI system, because the admin area was originally built by Dragooon to be usable on both SMF 1 and SMF 2, forcing him to reuse many SMF 2 blocks of code into his own work. Which, BTW, was probably legally uncertain at the time he worked on it..?!

Re: Contacts in profiles not saving
« Reply #2, on June 21st, 2014, 03:13 PM »
Ahhhh.... Okay... Just did not know if it was one or not, as testing things on the site. :)