This topic was marked solved by Nao, on September 24th, 2013, 10:26 PM
« Header issues
Random patch
User box screwing up post height in quick edit mode »

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Random patch
« on September 23rd, 2013, 06:29 AM »
Let's remove duplicate code!

Code: [Select]
/Sources/Post.php (working copy)
@@ -243,8 +243,6 @@
  );
  }
 
- $context['post_error'] = array('messages' => array());
-
  // See if any new replies have come along.
  if (empty($_REQUEST['msg']) && !empty($topic))
  {
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Random patch
« Reply #1, on September 23rd, 2013, 07:29 PM »
Good find!
Isn't it better to remove the second one, though..? The second one is included Inside a test, and there's another access to 'post_error' within another code block outside of it; while it's unlikely that it'll be touched, I'd rather we take this one outside the code block, and thus leave the one at line 243 in, and remove the one at line 360 or so.

Agreed, disagreed..? :^^;:

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Random patch
« Reply #3, on September 24th, 2013, 10:26 PM »
Thanks, done then.. ;) (Well, you might have seen it, latest rev :P)

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Random patch
« Reply #4, on September 25th, 2013, 12:54 AM »
Nope, not in the logs.
« Header issues
User box screwing up post height in quick edit mode »