This topic was marked solved by Nao, on August 31st, 2013, 04:46 PM
« Thoughts: Context not working
Language search fouls up with plugins with subfolders
PM bug: receive from administrators only doesn't work »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Language search fouls up with plugins with subfolders
« on August 23rd, 2013, 09:17 PM »
If you try to search in the language editor, plugins whose language files aren't in their top level folder (where plugin-info.xml is) throw errors as well as not being added to the results list.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,079

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

Nao

  • Dadman with a boy
  • Posts: 16,079

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Language search fouls up with plugins with subfolders
« Reply #5, on September 3rd, 2013, 02:24 AM »
Quote
I'm not well acquainted with the plugin codebase yet
Are you going to learn it, or rely on others to maintain it? I need to know what is expected of me.

Code: [Select]
/Sources/ManageLanguages.php Mon Sep  2 17:15:09 2013
@@ -447,7 +447,7 @@
  foreach ($objects as $name => $object)
  if (is_dir($name))
  {
- $local_path = str_replace($plugin_path, '', $name) . '|';
+ $local_path = str_replace($plugin_path, '', $name) . '/';
  $lang_dirs[$plugin_id][$local_path] = $name;
  }
 

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Language search fouls up with plugins with subfolders
« Reply #6, on September 3rd, 2013, 04:50 PM »
Okay, applied your fix to the file. (And made it all into one line... No need to use a temp variable for that, is there...?)
Thanks!

I'll learn the system if nobody steps up to maintain it and it turns out that I absolutely need to fix things. Otherwise, frankly, I have too much on my plate right now to start looking into learning things that Pete left hanging. I believe he fixed 99% of what he needed to fix everywhere, so I think I can safely leave these things aside until needed. Right now... Nope.

What I'm expecting of you? I'm expecting nothing of you. If I were expecting something of you, that might influence you to work on things, and then get upset with me for some reason. I only want you to do what you're willing to do for Wedge. So, basically, if you want to take over whatever Pete was working on and that you know better than I do, by all means, please do it. If you're not willing to, then it's just fine as well. I'm certainly not going to put the pressure on anyone; it is up to me, and me alone, to carry the Weight of Wedge until it gets released.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
« Thoughts: Context not working
PM bug: receive from administrators only doesn't work »