« Plugin execution
Something is screwy with the main menu
2 responses to this message are sent..? »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Something is screwy with the main menu
« on April 15th, 2013, 04:50 PM »
I don't know why this is but it's seriously messed up right now.

I was clicking on the Home button repeatedly (here, just now) and some page loads it would show I had a PM outstanding, some it would show no PMs outstanding, some it would show a dropdown for the Home menu, some it wouldn't.

Oh. It just occurred to me. SMF bug strikes again.


Why are we caching the menu again? This is why it's messed up - caching at level 2 (which is what we're set to) stores the menu for the groups the user is in with the language. It's entirely possible that you have multiple members with the same groups with different information.

I don't really think we need to cache it...?
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Something is screwy with the main menu
« Reply #1, on April 15th, 2013, 05:12 PM »
The reason cache level 2 was activated is, I guess, because this morning I tried to flush the non-file cache (mentioned that in the thoughts area), and I figured it might work if I switched to level 2 and then back to level 1... I guess either there's a bug with switching between levels, or I simply forgot to switch back to level 1.

Anyway, if level 2 is broken... It should be fixed, I guess ;)
Switched back to level 1 for now...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Something is screwy with the main menu
« Reply #3, on April 15th, 2013, 05:29 PM »
Hmm... Didn't even remember a single post of this conversation.... :whistle:

Yes, I think caching the menus isn't going to improve performance enough to justify the problems it creates.
And I'm the one saying that... So, do whatever you feel you have to do, eh ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Something is screwy with the main menu
« Reply #4, on April 15th, 2013, 05:39 PM »
Already removed ;)

It only even comes into effect on level 2 and to be honest the load of the menu is really not that big a deal.

spoogs

  • Posts: 417
Stick a fork in it SMF

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Something is screwy with the main menu
« Reply #7, on April 15th, 2013, 08:50 PM »
I just realised I only took part of it out (the important bit) though in my last commit, I'll tackle the rest in my next commit.
« Plugin execution
2 responses to this message are sent..? »