Wedge

I'm sorry I can't reproduce this.. I tried with different skins, different topics/boards but I always see the rev..

Just reproduced on refresh #3 of this very page. Using Safari 5.1 on regular Display page (not Post page.)

And again after posting this... Three refreshes in a row! Refresh #4 had the rev number, and refresh #5 didn't.
I'll just stop here, I won't spend the day reloading :P

I refreshed 6 times, nothing :P

Anyone else..?

:edit: Had rev number on reading this page. Quick replied. Page refreshed with my post, and with no rev in it. Can you check what it does after posting..?

:edit: Did another quick reply, Wedge didn't hide it this time though.

:edit: It hid it after I pressed Merge Posts :P

That is truly strange. But it sounds to me more like it's a bug of the plugin than of execution as such. Need to double check - but I wasn't able to get it to misbehave myself locally when I wrote it.

Wait... actually... I can imagine one case where it might - if it ever has to play switcheroo on languages, which it can do under certain circumstances of merging. The plugin is a bit cheeky, it just fudges the language strings.

Merging what..? Posts? As I was saying, this happens from time to time, just by refreshing a page...
I'm at a loss too, though. I've never, ever seen the Skin Selector disappear for instance. Maybe it's the exact hook that's to blame..?

Not merging, moving. The move topics stuff does a strange switch of languages.

I still haven't seen it fail yet...

Try to switch to French.
It seems to happen only in French, actually... That may be a clue?

Only seems to happen on topic pages after a refresh with the French language being used.

After switching languages and browsing around, it happened to me the grand total of once where it didn't show up.

That would imply that under some set of circumstances, the hook isn't being called for some reason, but it's not clear why or why not that might be the case.

As I said, it also happens to me on Post pages... Not only Display. But it's true that I haven't been able to reproduce it anywhere else (although I haven't tested much.)
Last time I tried on a topic page, I got it to 'omit' the rev plugin *four* times in a row. Then it showed it twice, then hid it again... See what I mean.
I think it should be fixed. There's no telling whether or not another plugin will go through the same hassles. Maybe it's due to the hook being loaded too soon...?

So... Display.php + hook in loadTheme() + French language =...?

It's not Display.php, loadTheme is called long before Display.php even loads.

It means loadTheme is ending earlier than expected - and if so that would imply it is originally an SMF bug ;)

Okay, I've managed to work it out.
It's a Wedge bug, all I can say ;)
Also: the plugin is always executed, even if it doesn't show up.
It's due to the way languages are loaded: English first, then French second... Sometimes it'll execute the plugin on English, then rewrite with the French version, and thus the rev number doesn't show up. It has to execute on the second run...

Hmm, nope, sorry it's always applied to the French file... I misread the string. So -> English loaded -> French loaded -> plugin executed -> at this point it's all fine -> then the French language is loaded again..?!
If you'll look at the admin log below the page, here's the loading order:

index.english (default), index.french (default), index.english (default), index.french (default),

So, plugin gets executed in the middle of these. Not at the end though. And I'm not sure why languages are loaded twice..? Isn't this something we worked on fixing at some point?

We have to find out why loadTheme() is called twice, to begin with.
Does Wedge have a protection to prevent hooks from executing twice? That would explain everything... (I mean, it'd prove that it's due to loadTheme being called twice.)

O RLY

OK, so yeah, I suggested there might be issues with language juggling ;)

I know we fixed it to load English first all the time, but I don't know why it's loading them twice. What I'd be inclined to do is try and dump the backtrace upon hitting loadLanguage where it's called to load 'index' to see why it's loading them twice.