This topic was marked solved by Arantor, on November 27th, 2012, 04:25 AM
« Modify group does not show correct UI for board access
Moderation filters "function" param wroong
Undefined: ex_string in Class-CSS »

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Moderation filters "function" param wroong
« on November 25th, 2012, 01:00 AM »
Index: I:/repos/arantor_wedge/trunk/Themes/default/ManageModeration.template.php
===================================================================
@@ -117,7 +117,7 @@
                   break;
                default:
                   if (!empty($rules['function']))
-                     $print_criteria[] = $rules['function']($criteria);
+                     $print_criteria[] = $criteria['function']($criteria);
                   else
                      $print_criteria[] = $txt['modfilter_cond_unknownrule'] . ' ' . $criteria['name'];
             }

Posted: November 25th, 2012, 12:58 AM

http://wedge.org/pub/plugins/7711/maximum-images-per-post/msg283603/#msg283603
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Moderation filters "function" param wroong
« Reply #2, on November 25th, 2012, 01:40 AM »
No. They are all inside a switch statement, all the built in rules are defined in cases, and none use that specific parameter.

The only occurrence of the param I'm seeing is in the default block.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Moderation filters "function" param wroong
« Reply #7, on November 26th, 2012, 03:08 PM »
Yup, it should definitely be $critieria in both the call and the if before-hand. I'll commit it once I have some other stuff to commit, but need to head out now.
« Modify group does not show correct UI for board access
Undefined: ex_string in Class-CSS »