This topic was marked solved by Nao, on January 24th, 2013, 11:04 PM
Viewing an unread media item does not mark it as read

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,082

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Viewing an unread media item does not mark it as read
« Reply #4, on January 18th, 2013, 05:29 PM »
So... Went to the Unseen page, clicked on an image thumbnail, it launched the preview (not the full image, mind you), reloaded page, had everything except for that item.

So yeah, it's working I'm afraid...!

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Thank you,
Boko

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Viewing an unread media item does not mark it as read
« Reply #7, on January 19th, 2013, 03:56 PM »
Okay, now I see it... I didn't open the page for non-images because I thought it'd work. It works in AeMe for SMF... :-/

I've looked into the source code, and can't find the reason for it.
Basically, $item_data['is_new'] is set to 0 when on an item page, so it doesn't attempt to mark it as seen, but set to 1 on the unseen page.
Need more time to find the culprit... -_-

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Viewing an unread media item does not mark it as read
« Reply #9, on January 24th, 2013, 11:07 PM »
Just as a side note, I'd add that no-one who reads the Aeva thread seems to be aware that you're not posting in it. Perhaps next time it comes up I should give them a reminder...
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Viewing an unread media item does not mark it as read
« Reply #10, on January 24th, 2013, 11:11 PM »
Not surprised. Last time I checked it, a year ago at least, people acted like it was part of SMF and thus the team knew everything about it.
Mehh.

Still. I pretty much abandoned aeme even in Wedge and that's a shame. I so wanted it to be the first stone in my building: having any type of content available as floating topics.

Sob.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Viewing an unread media item does not mark it as read
« Reply #13, on January 24th, 2013, 11:24 PM »
And it's one of the reasons Drupal is an architectural mess.

However, it's not that big a deal for us to implement, really. We already have some structure around boards being different types. If we extend that to include albums, a topic in an album board by definition is a topic about a media item. We just need to ensure there is proper logic around allowing/disallowing items to be moved between them inappropriately.

There are a lot more issues that we need to deal with, though it's something that I can do some work on tonight rather than banging my head off the ban UI, I guess.