Farjo

  • "a valuable asset to the community"
  • Posts: 492
Membergroup settings
« on November 4th, 2012, 08:59 PM »
If I go into this screen I get three entries in the error log:
Code: [Select]
http://bla.bla/index.php?action=admin;area=membergroups;sa=sett…
 8: Undefined index: group_show_normal
 File: /bla/Sources/ManageMembergroups.php
 Line: 1062
Entries 2 and 3 are ditto bar:
Code: [Select]
8: Undefined index: group_show_post
Line: 1063
and
Code: [Select]
8: Undefined index: group_show_cond
Line: 1064

Presumably related: the "Show group titles under user names?" dropdown has 'Nothing' and 'No groups' and then blank entries for the other groups. (Pity, because it looks like a really cool feature that I'd love to set up :))

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Membergroup settings
« Reply #1, on November 5th, 2012, 12:35 AM »
This is more of a 'thing that needs more work', i.e. something we forgot we had still to do, I think...
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Farjo

  • "a valuable asset to the community"
  • Posts: 492

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Membergroup settings
« Reply #3, on November 5th, 2012, 08:58 AM »
Actually I mentioned that in my more general post there -- http://wedge.org/pub/7664/a-few-things-about-the-alpha-and-its-bugs/

Also, while we're talking about membergroups... I'm thinking that one of the things that could help admins set up group permissions is something like this.

- have a $settings['override_groups'] variable under the hand
- allow the admin to set up a list of groups in that variable
- at Load time, determine whether the user is an admin. (When $user_info['is_admin'] is being filled in.)
- if yes, discard their $user_info['groups'] and replace it with the contents of $settings['override_groups'], and add a $context['groups_overridden'] variable.
- in the index template, check for $context['groups_overridden'], and if set, add a button on the page which the user can click to simply delete the $settings['override_groups'] variable.

It seems a bit silly, and overall it's rather easy to implement (except for the UI, as usual for me..........), but what it gives the admin, is the ability to browse their website using another set of groups, and be able to go back to admin mode at any time.

What do you think...?

Farjo

  • "a valuable asset to the community"
  • Posts: 492
Re: Membergroup settings
« Reply #4, on November 5th, 2012, 11:30 AM »
I don't understand the code stuff but this bit "what it gives the admin, is the ability to browse their website using another set of groups, and be able to go back to admin mode at any time." sounds useful. Having said that I'm long in the tooth enough to distrust anything apart from signing in as a test user.

MultiformeIngegno

  • Posts: 1,337
Re: Membergroup settings
« Reply #5, on November 5th, 2012, 12:13 PM »
Quote from Farjo on November 5th, 2012, 11:30 AM
I don't understand the code stuff but this bit "what it gives the admin, is the ability to browse their website using another set of groups, and be able to go back to admin mode at any time." sounds useful.
+1

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Membergroup settings
« Reply #6, on November 5th, 2012, 03:39 PM »
Essentially it's a hacked up version of 'Switch Permissions'. What would be better is if this wasn't in the core but implemented as a plugin.
Re: Membergroup settings
« Reply #7, on November 26th, 2012, 03:55 AM »
Also, I'd note that I have about 75% of this but I stopped it for now because it made me realise that topic privacy is broken because of the ways permissions are currently handled internally.
Re: Membergroup settings
« Reply #8, on February 20th, 2013, 01:57 AM »
I'm going to bump this to remind myself that while I fixed the original bug (undef indexes), I didn't implement the underlying logic to go with it in the aftermath of badge support.