« Session writing
Modify group does not show correct UI for board access
Moderation filters "function" param wroong »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Modify group does not show correct UI for board access
« on October 4th, 2012, 06:10 PM »
Some time ago I modified the way board access is handled, so that it is possible to exclude people from boards, as well as separating board visibility from board access.

I also updated the UI in manage boards to cover this, but the reverse option - setting what boards a given group can see - has not yet been updated, mostly because I haven't figured out a nice way to display it given the way board hierarchy can be handled and thus you need the ability to provide indentation and stuff...
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Modify group does not show correct UI for board access
« Reply #4, on October 27th, 2012, 01:51 PM »
Because when you're doing it from boards, you're doing groups, which is a single dimensional list (though even as it stands it might not always fit properly side by side!)

But when you're doing it from groups, you have to cope with a list that has nested items of arbitrary depth - and still fit in 3 columns per row - and then do the whole thing twice.

Then, remember that I rewrote group access, the boards UI uses the newer stuff, the groups/board access uses the older stuff.
Re: Modify group does not show correct UI for board access
« Reply #6, on November 13th, 2012, 01:32 AM »
Anyone have any trouble with this?

I think it could be made more usable by putting in category headers and making them have selectors too (which would select all the boards in that category) but it seems to work...
Posted: November 13th, 2012, 01:29 AM

Also, thought of the day: this should mean the old member_groups field could be removed. Except it can't because there's some old stuff related to privacy that this field still drives, though I have no idea if any of it works or what it does if it does work.

spoogs

  • Posts: 417
Stick a fork in it SMF

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Modify group does not show correct UI for board access
« Reply #9, on November 27th, 2012, 11:17 PM »
member_groups is the old method of storing which groups can see a board. In theory it's supposed to be gone, but there's some old legacy code that we've added that uses it to infer something related to topic privacy, and I want to know if 1) it works or not and 2) whether it should be removed so we can remove that from the DB.

spoogs

  • Posts: 417

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

spoogs

  • Posts: 417
« Session writing
Moderation filters "function" param wroong »