This topic was marked solved by Arantor, on October 7th, 2012, 07:18 PM
« Large images jut out of post area
Admin search issues
DNS lookup can sometimes throw errors »

Nao

  • Dadman with a boy
  • Posts: 16,082
Admin search issues
« on June 11th, 2012, 12:52 PM »
Here's the list of language files that admin search will work its magic on:

'Help', 'ManageMail', 'ManageSettings', 'ManageBoards', 'ManagePaid', 'ManagePermissions', 'Search',
'Login', 'ManageSmileys', 'ManageMaintenance',

As you can see, it doesn't have Profile in it...

However, if I do a search on 'minposts' (signature_minposts), it returns to me the string from the Profile page, instead of the one from the Admin page. The profile page one is multilingual-ready, so it would return an error but I fixed that one in my local install (I'll commit it later, it's actually pretty big compared to the relevance of that bug...)

But I don't see Profile in that list. So I enabled debugging locally, and looked at the language list... Wow, what a load of fun.

Fichiers de langue (42) : index.english (default), index.french (default), Admin.english (default), Admin.french (default), Help.english (default), ManageMail.english (default), ManageSettings.english (default), ManageBoards.english (default), ManagePaid.english (default), ManagePermissions.english (default), Search.english (default), Login.english (default), ManageSmileys.english (default), ManageMaintenance.english (default), Help.french (default), ManageMail.french (default), ManageSettings.french (default), ManageBoards.french (default), ManagePaid.french (default), ManagePermissions.french (default), Search.french (default), Login.french (default), ManageSmileys.french (default), ManageMaintenance.french (default), Help.english (default), Help.french (default), ManageSettings.english (default), ManageSettings.french (default), Help.english (default), Help.french (default), ManageSettings.english (default), ManageSettings.french (default), ManageSettings.english (default), ManageSettings.french (default), ManageSettings.english (default), ManageSettings.french (default), ManageSettings.english (default), ManageSettings.french (default), ManageSettings.english (default), ManageSettings.french (default), Profile.english (default), Profile.french (default).

There are two issues in this:
- The Profile language is loaded at the very end. I don't see where it's coming from...?! This call needs to be removed.
- The other files are loaded multiple times. It's likely that they're stopped at the gates before they're loaded one time too many (?), but it seems to happen on a lot of pages... For instance on a topic page with media items, it'll load Media.english, Media.french, Media.english and Media.french in sequence. Here, it's done in that order: (Whole lot).english, then (Whole lot).french, then (Help.english, Help.french...) * count(Whole lot). (Or Whole lot.length, depending on your language of choice.)

The latter is definitely a 'bug' to me, as the language files are only listed if they're actually included. Because it's an array we're sending, the first two Whole lot loops are as expected. It's the last one that doesn't make sense. And the Profile calls. Any ideas...?
Re: Admin search issues
« Reply #1, on June 11th, 2012, 05:32 PM »
The later strings are loaded through an obscure loop in the admin search that actually executes every single function it finds in the admin... Not exactly very smart I'd say?!
There are certainly more ways to do that properly...?!

Anyway, I think I'm "simply" going to force a reload of the original language files after that... Meh!!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Admin search issues
« Reply #2, on June 11th, 2012, 06:08 PM »
Well... the admin search has to execute every function, that's how it gets the list of settings to work with, and all the main language files should be loaded first. It's loading both sets of languages because loadLanguage has done that for a while but there's no need for it to go through all that twice.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Admin search issues
« Reply #3, on June 11th, 2012, 06:13 PM »
So, how do you manage the case where a matching setting is found, but another language file already overwrote it from the text strings..?
Search for "visible" and it'll match signature_minposts but you'll get some contents that doesn't have "visible" in it... :-/

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Admin search issues
« Reply #4, on June 11th, 2012, 08:42 PM »
Because what it matches on is what it's supposed to use >_>

I never said it was perfectly written. If it's being overwritten that suggests that the other string should be changed so that it has a different language string - and that we shouldn't be reloading lots more strings.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Admin search issues
« Reply #5, on June 12th, 2012, 02:49 PM »
Quote from Arantor on June 11th, 2012, 08:42 PM
Because what it matches on is what it's supposed to use >_>

I never said it was perfectly written.
I don't know what you wrote in it -- I think the feature was there already in SMF, right...? I know you touched it, but I don't know where. I only know that it needed some fixes as noticed yesterday. Now, of course, feel free to rewrite my fix from rev 1612 (or so), and make it better! I didn't actually change anything regarding the loading order for language files... I only fixed the array stuff.
Quote
If it's being overwritten that suggests that the other string should be changed so that it has a different language string - and that we shouldn't be reloading lots more strings.
Reloading, I don't know. It's an admin thing and not used much, so I guess it *can* use a lot of resources without being a problem. When it comes to string names, though, it's hard to rename them all. Some are also associated with database settings and would need some further rewrites if we were to rename one of the entries...

Regarding that, yesterday I posted a topic with a list of all intersecting entries in the language files. Feel free to have a look and hack away at the language files... :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Admin search issues
« Reply #6, on June 12th, 2012, 07:30 PM »
My contributions to the admin search are primarily configuration related, I fixed a bug about it being case sensitive and I've added changes to differentiate types of settings available but that's about it.
Re: Admin search issues
« Reply #7, on July 23rd, 2012, 02:56 AM »
So, aside from the internal mess of the admin search (and, sadly, I don't see a better way to deal with it!), is there anything about it that doesn't work as expected?

From my perspective, there's a few minor areas that could be cleaned up and made sure to be added to it - but I'm thinking that's almost into overkill territory at this point. (E.g. we could make all the possible custom field templates into searchable items.)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Admin search issues
« Reply #8, on July 24th, 2012, 06:44 PM »
I guess there aren't too many places where it breaks. Maybe we could just take the one I mentioned, and rename the option... Would be simpler.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Admin search issues
« Reply #11, on July 24th, 2012, 08:33 PM »
Take the one you mentioned and rename one or the other of the strings so that there isn't a clash.

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Admin search issues
« Reply #13, on October 7th, 2012, 07:17 PM »
The mass extra loading should be fixed in r1736.
« Large images jut out of post area
DNS lookup can sometimes throw errors »