This topic was marked solved by its starter, on November 4th, 2012, 12:20 AM
Not sure what to make of this

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

billy2

  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 350
<br /><br />cough, cough.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Not sure what to make of this
« Reply #3, on March 28th, 2012, 11:53 AM »
That's curious.

For those wondering, that means there's an entry in the log-online table that isn't represented in the session table, which I guess could happen if an entry happens to somehow fall foul of the GC. I wasn't sure that should be possible, but it's also code that's mostly not modified from SMF's (I would have only modified it to cope with wider columns with IPv6 support)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Not sure what to make of this
« Reply #4, on March 28th, 2012, 01:02 PM »
Ah, sorry. I fixe that this morning but forgot to report it. Didn't see this topic.
Problem happened when someone was viewing a gallery item because it postponed an action that needed to be determined earlier.
Anyway.
Re: Not sure what to make of this
« Reply #5, on March 28th, 2012, 07:59 PM »
Okay, let's reuse that topic for another bug... :P

Post this in a message:
[media id=65]

It works.

Now post this (add any parameters, any will do):
[media id=65 type=full]

It adds a closing [ /me] automatically. Not even a [ /media], no... a [ /me].
[ /media] is still wrong because it's a self-closing tag anyway, but 'me'...? Something tells me that it's a bug in the way the me tag is implemented.

Gotta go. Anyone got any idea where I could look to spot this bug...? It can be reproduced simply with the Preview button, or with a Quick Edit.

PS: added spaces before closer slashes because Wedge wouldn't allow me to post otherwise... Gotta love this mismatched tag detector though, even if it 'failed' here, normally it would be in its right to complain ;)

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Not sure what to make of this
« Reply #6, on March 28th, 2012, 08:16 PM »
funny :)
Bug is a bit different for me :)
When typing:
Code: [Select]
[media id=65 type=full]


it will end up in:


Code: [Select]
[/s][media id=65 type=full][/color] [/color]
# dpkg-reconfigure brain
error: brain is not installed or configured

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Not sure what to make of this
« Reply #7, on March 28th, 2012, 08:51 PM »
The me tag is implemented through work in the preparser, amongst other things.

Tomorrow I'm out, but Friday I'm going to sit down and start unpicking the current issues with the preparser. The first thing I need to do with both the preparser and the parser are to write test units for them, to validate what correct functionality should be (and then I can automate whether it's behaving as it should)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Not sure what to make of this
« Reply #8, on March 28th, 2012, 09:14 PM »
Pandos -- that doesn't make any sense as a bug. I believe you but can you confirm
 The code you posted above...?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Not sure what to make of this
« Reply #11, on March 28th, 2012, 09:37 PM »
Not superficially, no, but it's entirely possible that something will make sense once it's picked apart.

As I said, Friday, I have nothing on, so I'm going to sit down, write some test cases and start making sense of how both the preparser and main parser work. This has more repercussions than being able to nail down some of the ongoing bugs, but identifying where, potentially, some of the enhancements to performance can be made.

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Not sure what to make of this
« Reply #12, on March 28th, 2012, 09:37 PM »
Code: [Select]
[/s][media id=65 type=full][/color][/font][/color]
That's the output from preview with QuickReply.

In WYSISYG Mode it looks like this:
Code: [Select]
[media id=65 type=full][/color]
Re: Not sure what to make of this
« Reply #13, on March 28th, 2012, 09:44 PM »Last edited on March 28th, 2012, 09:50 PM
Above tested with Chrome.

Just tested it in IE 9 in WYSIWYG Mode.

After pressing the preview button the following error occurs:
Quote
The following error or errors occurred while posting this message:
  • The message body was left empty.
Edit:
With Firefox in QuickReply AND WYSIWYG mode it will have the mentioned /me Tag from you


Nao

  • Dadman with a boy
  • Posts: 16,082