It's all gone horribly French!

Aaron

  • Posts: 356
Re: It's all gone horribly French!
« Reply #15, on March 21st, 2012, 11:21 PM »
Quote from Nao on March 21st, 2012, 07:23 PM
Logo image URL: ----> default material. If theme doesn't want to use it, they can add a theme option to ask for another logo that fits their needs.
Hmm, I disagree on this one... Most of the team, you're likely to switch images per theme anyway, because your logo is just not in the right dimensions or (background) colours.
Quote from Nao on March 21st, 2012, 07:23 PM
Forum width: --> completely default stuff... (heck, I'd be tempted to remove this entirely, and leave it up to custom.css...)
I'm aboard the discard boat, myself.
Quote from Nao on March 21st, 2012, 07:23 PM
Okay, seriously... I see absolutely no 'logical' theme option in this.
Well, they're all theme-related options ... If they're not consistent throughout all themes, they have no place in $settings, if you ask me. But I gather you're planning to change all that.
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: It's all gone horribly French!
« Reply #16, on March 21st, 2012, 11:30 PM »
Quote
Hmm, I disagree on this one... Most of the team, you're likely to switch images per theme anyway, because your logo is just not in the right dimensions or (background) colours.
That's the thing, most sites don't run multiple themes, and of those that do, most of the time the admins don't really seem to care anyway and just use whatever logo they have.

A lot of themes don't even adhere to this one anyway, especially ones that come with their own logo, because people end up being told to replace the image rather than update this setting - because it's set in the theme's CSS more often than not. Certainly this is true of a bunch of Crip's themes, most of the DzinerStudio themes and some of Bloc's themes.
Quote
I'm aboard the discard boat, myself.
I have no qualms about removal really.
Quote
Well, they're all theme-related options ... If they're not consistent throughout all themes, they have no place in $settings, if you ask me. But I gather you're planning to change all that.
That's the thing. You and I might see them having per-theme use but experience of what 'real users' do (since I doubt you and I are particularly representative of the bulk of users) seems to suggest that themes don't tend to worry about these things much, doing what they do their own way, and dealing with it later, assuming of course that users 1) run multiple themes and 2) want to have different settings for each theme. The first is uncommon, the second rare at best.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial