Wedge

I definitely think the link should not be visible if registration is disabled, at best maybe admin can choose to display a message stating that registration is disabled at this time.

Well, it's not just the menu, there's all sorts of links that don't differentiate between enabled or not. But if there's nowhere to register, it should be fairly obvious (and if you go to action=register it does give you a message about it)

Thing is, I don't know where such a warning would really go otherwise...

Hmmm good point, I just too a  nice long stare with registration disabled and not seeing a good place for such a message either. I just remember being annoyed in the past by having clicked the register button only to find out registration is disabled. It's not really a big deal though I suppose.

But now at least there isn't a registration button, nor is there the 'Please login or register' message (it's now just 'Please login' for registration disabled)

That works, Would it make sense to put such a message on the login page in the event someone assumes clicking login would give them registration options?

The login page just asks them to login (I also took away the 'please register' link from there too) - but I suppose I could add a message telling them that registration is disabled.

What I'm inclined to do is leave it how it is right now (without the extra hint) and see how people feel about it in a practical environment.

 :hmm: makes sense  :cool:

Yup, all good!