Fixed SMF bugs
it keeps giving me this error in Error Log »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
SMF bug 4388 (sort members pending deletion by last login, not registered date)
« Reply #15, on March 1st, 2012, 12:12 PM »
In the approve deletion screen, members are listed by registration date (like they are for approving new accounts), but we should rework that to order by last login, as stated it is likely to be more useful to decide whether to approve the deletion or not.
Posted: February 29th, 2012, 01:52 PM

Fixed in Wedge r1412.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Fixed SMF bugs
« Reply #16, on March 1st, 2012, 01:03 PM »
Good work!
You'll reach 9k posts by tomorrow at this rhythm, BTW :lol:

OT

I'm still groggy from my evening. Totally unable to deal with coding. And it really, really doesn't happen to me often...
Definitely not a day to convert Wedge.org to use Wedge.
I will, however, at the very least release screenshots of Weaving. If the importer bugs are fixed today, I'll also publish a version running Wedge.org (but NOT on wedge.org, and possibly with posting disabled), otherwise I'll just publish a bare-bones version.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Fixed SMF bugs
« Reply #17, on March 1st, 2012, 01:13 PM »
Quote
You'll reach 9k posts by tomorrow at this rhythm, BTW
What, just so I can go 'IT'S OVER 9000!' ?
Quote
I'm still groggy from my evening. Totally unable to deal with coding. And it really, really doesn't happen to me often...
It happens to the very best of us. Just take your time and deal with it when you feel ready.

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Fixed SMF bugs
« Reply #18, on March 1st, 2012, 01:34 PM »
Yeah I'll take it slow today.

I meant rate not rhythm. Direct french translation ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Fixed SMF bugs
« Reply #19, on March 1st, 2012, 01:36 PM »
Well, rhythm/rate can be used interchangeably here ;)

I'm going through page 2 of their bugs now, and just as before, some don't apply to us due to obsolete features, some already got fixed in passing for other reasons and the rest... >_< But no worries, we'll get through everything in due course! Slow and steady wins the race, as they say.
SMF bug 4902 (SSI does not issue a header including charset)
« Reply #20, on March 1st, 2012, 01:55 PM »
In our case, everything is UTF-8, so we don't even need to wait to know what the character set is, we can just issue the header directly from SSI.php - if a different header is required, user code can replace it, but it should default to UTF-8 with text/html as a MIME type (because that's, principally, what SSI.php pages do)
Posted: March 1st, 2012, 01:44 PM

Fixed in Wedge r1413.
SMF bug 4896 (paid subs, and search, can fail if a backup file is present)
« Reply #22, on March 1st, 2012, 01:55 PM »
These do detection based on matching the style of filename, but never detect for ~ endings. While this isn't really a problem for us, because we're not doing backups etc, I think it would be good practice to actually validate that it is a .php file and not anything else. It isn't harmful for what we're doing.
Posted: March 1st, 2012, 01:31 PM

Fixed in Wedge r1413.
SMF bug 4836: linktree_inline is missing
« Reply #23, on March 1st, 2012, 03:54 PM »
This is a quirky one. Back in the mists of time, you used to be able to get a linktree that looked like a folder tree (each line was a new row, with folders and branches and stuff) but it was removed in 2.0 - but there was some legacy code attached to it.

Now, RC4 removed the actual UI option for it but left the lang string and a few related bits, but they can all go as well.
Posted: March 1st, 2012, 03:17 PM

Fixed in Wedge r1414.
SMF bug 4742 (forum stats disabled but still accessible)
« Reply #24, on March 1st, 2012, 03:54 PM »
I'm inclined to agree - if the forum stats aren't being tracked, there's not really a lot of point leaving the page available.
Posted: March 1st, 2012, 03:48 PM

Fixed in Wedge r1414.

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: SMF bug 4936 (disabling certain bbc in signatures accidentally stops others)
« Reply #25, on March 1st, 2012, 03:59 PM »
Quote from Arantor on March 1st, 2012, 01:55 PM
If i bbcode is disabled in signatures, img is as well due to the way string matching occurs.

And I even helped fix this one originally >_>
A quick note.. I looked at the fix, and it looked like a situation where simply adding a \b would have fixed it...? What you're looking for, is a way to prevent an "i" tag from stopping an "img" tag, right...? Then \b should be enough (i.e. match a word boundary.) Not sure it'd be faster, though. Just safer.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Fixed SMF bugs
« Reply #26, on March 1st, 2012, 04:03 PM »
Yes, that is what it is ultimately about, however at the time (and now, really), I figured it was only about stopping those characters rather than \b, though \b should work just fine.

And actually, theoretically, there could be a bbcode that contains a character that matches \b... it would be ugly of course but not impossible.

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Fixed SMF bugs
« Reply #27, on March 1st, 2012, 05:39 PM »
You mean a BBC like "[hello,world=foobar]"...? Sounds silly to me... ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Fixed SMF bugs
« Reply #28, on March 1st, 2012, 05:45 PM »
Well, yeah, but doesn't prevent it being possible. I have encountered people doing numbers in bbcode in the past, doesn't seem to me as it would take much in the way of imagination for them to go one step further and use symbols given half a chance.

I have no idea if it would work or not, though ;)

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Fixed SMF bugs
« Reply #29, on March 1st, 2012, 05:51 PM »
I doubt it would :P

Well, even accented characters would be accepted... It's just an equivalent of (?!\w), anyway. (But I'd rather use \b because I'm not sure it'd work at the end of a string.)
it keeps giving me this error in Error Log »