Poll

Should Wedge remove theme support, if it provides an equivalent feature set through skins?

Yes! Focus on what you know best, and let us break it or make it.
17 (73.9%)
No! I'm too familiar with the theme system, I don't want to re-learn it all.
0 (0%)
I don't really care. I never played with themes, or skins for that matter.
1 (4.3%)
I don't know enough about it all to have anything interesting to say.
5 (21.7%)
Total Members Voted: 22

Drunken Clam

  • Drool, drool, drool....!
  • Posts: 154

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: One theme to rule them all?
« Reply #46, on January 5th, 2014, 07:53 PM »
Yeah, I *think* I remember SMF having a reason for capitalization, but I really can't remember it.
I'll go for all lowercase in the final version.

A more radical structure (and naming scheme) for the src folder could be:

/src       <-- empty
  /php     <-- Sources
  /css     <-- skins
  /js      <-- scripts
  /lng_fr  <-- languages/French
  /lng_en  <-- languages/English
  /tpl     <-- Themes/default


Probably a bit scary, though... :lol:
Re: One theme to rule them all?
« Reply #47, on January 5th, 2014, 07:55 PM »
Quote from Wanchope on January 5th, 2014, 03:44 PM
I think it will be better to split this thread (add a poll?)
No polls, because it's not something you can determine with a limited selection of folder names. I'm about to release the codebase on github, I'd like for the folder structure to be 100% final before I do that, I don't want to screw up, I want something that's easy to understand, and easy to update by FTP. I'm listening to any opinions. :thanks:

Drunken Clam

  • Drool, drool, drool....!
  • Posts: 154
Re: One theme to rule them all?
« Reply #48, on January 5th, 2014, 08:51 PM »
Quote from Nao on January 5th, 2014, 07:53 PM
A more radical structure (and naming scheme) for the src folder could be:

/src       <-- empty
  /php     <-- Sources
  /css     <-- skins
  /js      <-- scripts
  /lng_fr  <-- languages/French
  /lng_en  <-- languages/English
  /tpl     <-- Themes/default


Probably a bit scary, though... :lol:
I'm actually liking that a lot! It seems very logical.

kimikelku

  • Posts: 61
Re: One theme to rule them all?
« Reply #49, on January 5th, 2014, 10:29 PM »
Quote from Nao on January 5th, 2014, 07:53 PM
Yeah, I *think* I remember SMF having a reason for capitalization, but I really can't remember it.
I'll go for all lowercase in the final version.

A more radical structure (and naming scheme) for the src folder could be:

/src       <-- empty
  /php     <-- Sources
  /css     <-- skins
  /js      <-- scripts
  /lng_fr  <-- languages/French
  /lng_en  <-- languages/English
  /tpl     <-- Themes/default


Probably a bit scary, though... :lol:
It reminds me of phpbb2 dunno why :hmm:

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: One theme to rule them all?
« Reply #50, on January 5th, 2014, 11:21 PM »
Downloaded it, and I think you've got the wrong idea... ;)

Anyway, I'm still unsure where to go, right now. Should languages/ be a parent folder to all language sub-folders, or should these sub-folders be directly in the root? Should the parent folder for all things css/js/templates, hold the source files directly, or have them in another sub-folder? If not in a sub-folder, then should we have multiple sub-folders for php sources? (currently it's the case, we have media/, notifiers/ and captcha/, and I'm worried that these would 'conflict' with other top-level folders such as templates.)

PS: I fixed bbcode buttons, BTW. Sorry for the delay!

Wanchope

  • Posts: 234
Re: One theme to rule them all?
« Reply #51, on January 6th, 2014, 12:16 AM »
Quote from Nao on January 5th, 2014, 07:53 PM
Yeah, I *think* I remember SMF having a reason for capitalization, but I really can't remember it.
I'll go for all lowercase in the final version.

A more radical structure (and naming scheme) for the src folder could be:

/src       <-- empty
  /php     <-- Sources
  /css     <-- skins
  /js      <-- scripts
  /lng_fr  <-- languages/French
  /lng_en  <-- languages/English
  /tpl     <-- Themes/default


Probably a bit scary, though... :lol:
Will you marry my sister? :cool:

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: One theme to rule them all?
« Reply #52, on January 6th, 2014, 08:28 AM »
I'm more into brunettes, but thanks :P

Need more opinions!
Well, today I'll be spending most of my day watching GamesDoneQuick.com anyway, like every year at the same date now, but I'm still listening eheh.

MultiformeIngegno

  • Posts: 1,337

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: One theme to rule them all?
« Reply #55, on January 8th, 2014, 12:13 AM »
Today I've flattened the skin system, so this last question of mine is preeeetty much the last hurdle before I can publish the source code. (Well, I'll also do a test-run of the install process, of course. I'm 66.67% sure it's broken again.)

Thus, I'd like to make sure we all agree on a 'best of the worst' solution for the general folder structure. I think we all agree[1] we can gather most PHP/CSS/JS files in src, but we need to determine the folder names, mostly (src? sources? code? Something else? What about the JS files? js, or scripts? etc.), and whether or not the Sources/*.php files should be in /src/php/ or in the /src/ root[2].
 1. Although I'm very open to discussing other possibilities, of course.
 2. Pros of having them in /src/php: easy to create new sub-folders, as is the case in SMF, Elk or current Wedge. Clean structure. Cons of having them: it takes one extra step to update the website by FTP. I don't like the idea of an extra step, hmm...
Re: One theme to rule them all?
« Reply #56, on January 8th, 2014, 11:51 PM »
Site is updated with the latest revision. It was broken for about 10 minutes (completely for a minute or two; partially for the rest.) If you find any problems, please report them. I also tested the session-based cache, and I'm getting slightly better results, just like on my local install, but so far, my page load record for shortest time is held by the file-based cache (.06s on New Revs page 1), followed by session-based cache (.07s at best). I only tested about a dozen page refreshes per cache type, so your mileage may vary. Also, session-based seems to be more consistent, so I'll probably eventually use it.

...

Still waiting on more feedback for the folder structure..?
Re: One theme to rule them all?
« Reply #57, on January 9th, 2014, 06:48 PM »
I'm getting plenty of likes on my latest thought, but no actually feedback, so I guess I'll have to choose by myself...

My current structure is thus:

Code: [Select]
/core
  /javascript
  /languages
  /plugins
  /skins
  /sources
  /templates

I thought 'core' made sense as the root folder. 'javascript' is a conscious choice to make it clearer that 'scripts' are 'JavaScript', not 'PHP scripts'.
languages will have French and English US at its root, and German and English UK in sub-folders, to match the future official languages repo. You'll probably need to move the folder contents to the languages folder though, if you want to have them enabled. Not sure yet.
Plugins are part of the rest, because that makes it easier to update them, and they're most likely to be uploaded by FTP, so I'm *hoping* we won't be getting problems with file permissions. (At worst, I could simply create that folder at runtime, so that Wedge can be sure it can manipulate its contents without filesystem problems.)
skins are the CSS folders, sources is the original Sources folder (meaning core is technically empty, which I'm not too happy with, but the alternative would be to have /core/media and /core/notifiers and /core/captcha in addition to the files above, and I'm not sure I want that), and templates are /Themes/default.

Everyone happy with this..?

Aaron Smith

  • The mini menus on Thoughts... Damn Sexy!
  • Posts: 39
Re: One theme to rule them all?
« Reply #58, on January 9th, 2014, 07:04 PM »
I'm good with it. It's straightforward and logical. Uncluttered too which is a bonus.

Drunken Clam

  • Drool, drool, drool....!
  • Posts: 154
Re: One theme to rule them all?
« Reply #59, on January 9th, 2014, 07:37 PM »
Quote from Aaron Smith on January 9th, 2014, 07:04 PM
I'm good with it. It's straightforward and logical. Uncluttered too which is a bonus.
Couldn't have put it better myself. :)  (Logical and uncluttered are two of my favourite things!) :cool: