« Session Managment
CSS inheritance issue
Mail entities and stuff. »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: CSS inheritance issue
« Reply #15, on April 15th, 2013, 04:38 PM »
Not really any point, it'll probably go over my head like it has done for months.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: CSS inheritance issue
« Reply #18, on April 15th, 2013, 05:49 PM »
Sometimes, when I read through my codebase and scratch my head at it, I feel like a noob too... :lol:

Oracle

  • Posts: 78

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: CSS inheritance issue
« Reply #20, on April 15th, 2013, 11:37 PM »
Quote from Nao on April 15th, 2013, 12:12 AM
Add a 'final' keyword to all of these windowbg-related selectors, and please tell me how many bytes this saves in your gzipped CSS, if any ;)
So, apparently you forgot to do it... :whistle:
Your CSS adds over 140 bytes (ouch).
Adding the 'final' keywords saved a total of 54 bytes.
That is -- nearly half of it.
As I said: please use final keywords when you're playing with anything that's used as an extend anywhere else...

Also, you forgot to add commas after your new .warn_* classes. I'm surprised you didn't catch it at commit time..?
Fixed locally.
Re: CSS inheritance issue
« Reply #21, on April 15th, 2013, 11:39 PM »
Also, I'd like to know if these .inf_* entries will show up for admins only? If yes, you can enclose them in @if admin tests...
If it depends upon a permission, well... I have yet to add any ability to restrict a CSS block to a certain permission... :^^;: I guess I could do it, but that would make for longer filenames, eh... Unless, hmm.... Unless I stored permissions under their ID..?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: CSS inheritance issue
« Reply #22, on April 15th, 2013, 11:53 PM »
Quote
Also, I'd like to know if these .inf_* entries will show up for admins only?
No, they will show up for anyone who can see warnings or issue warnings. Which will be members who can see their own warning history. So member without any extra tests is appropriate.
Quote
Also, you forgot to add commas after your new .warn_* classes. I'm surprised you didn't catch it at commit time..?
I managed to miss a *much* bigger thing in r2060 than that. I would have spotted it when I actually got to testing the places where the style will be applied, which right now isn't anywhere.

Next time I'll just wait until I'm completely done before committing, I guess, and I'll go through it again with a fine tooth comb to make sure it's perfect.
Quote
As I said: please use final keywords when you're playing with anything that's used as an extend anywhere else...
And as I said, most of this stuff went over my head. In any case I haven't decided if this is the final code yet or not, it might change and I really don't see any point in worrying about optimising until it's actually done. Pre-emptive optimisation can actually make it very hard to get anything done.

I also said before I'm having a real hard time trying to keep all this straight in my head. Not including a comma at this point in time is a... minor omission.
Re: CSS inheritance issue
« Reply #23, on April 16th, 2013, 11:13 PM »
Oh, and just to point out, .button_class is broken. Some of the buttons do not have a proper padding-left, and before there's any debate about 'I'm not using SVN', this occurs here too with Chrome 27.

📎 button_class_bug.png - 28.18 kB, 930x440, viewed 156 times.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: CSS inheritance issue
« Reply #24, on April 16th, 2013, 11:19 PM »
Nope, doesn't happen...
Only happened here because I forgot to remove the extra.webkit.css file when uploading rev 2060. This is fixed now. But AFAIK, the file was removed from SVN, so you shouldn't be having the problem locally...?

Also, it's .button-padding, not .button_class, although I'm thinking of renaming it to .button-with-icon, so that it's more self-explained...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: CSS inheritance issue
« Reply #25, on April 16th, 2013, 11:28 PM »
I don't work out of my own SVN folder. So when it was removed, it didn't magically get removed from the test installation. So, just like here then.

Having removed the extra.webkit.css file here, it does work as expected.

Nao

  • Dadman with a boy
  • Posts: 16,082
« Session Managment
Mail entities and stuff. »