There are a goodly number of things wrong with message icons and I want to get some feedback on them and what to do with them.
1. Single set of icons, not multiple sets
They're actually changeable per physical theme at this point in time. I don't know any theme that ever actually shipped *its own* as such; all the ones I ever saw just shipped whatever the default icons were in SMF at the time.[1] I'd like to propose we make it a single set of icons.
2. Get rid of this 'enable customised icons' nonsense.
There is really no need for this nonsense. There is, yes, the argument to be made about performance, but caching would fix that anyway. We'd get a simpler and better to use UI out of it.
3. Drop the enforcement of it being .gif
There's really no reason why it must be .gif, other than having a standard format to work with. But that's solvable through another thing.
Then we can get a bit more exotic if we wanted.
4. Stop storing it as a textual item.
If we're already storing them in the database anyway, we will already have numeric ids for them. I see no reason why we can't make proper use of them and just store a numeric id in the messages table and be done with it (yes that would SAVE space!)
This isn't without its issues, because it would mean that all the silent-forced changes that occur (for iPod/iPhone/tablets/Android etc. not to mention moved notices, deleted posts at present and posts with attachments) would also have to be in that table. This raises other issues (what happens if the user deletes them? what happens with migrating existing SMF stuff including this site?)
I'm not exactly dead set on this one, but it is certainly an option to explore and not without its caveats. Though it could also mean the user doesn't want those things set, e.g. if they delete the tablet one, don't use that replacement later.
5. Topic filtering
Assuming we make it a numeric id, we could store that numeric id in the topics table (first post's)... it would allow us to stick an index on it and then filter topics on it. Of course, any plugin that adds its own would be rather awkward but it's not insurmountable.
/discuss
1. Single set of icons, not multiple sets
They're actually changeable per physical theme at this point in time. I don't know any theme that ever actually shipped *its own* as such; all the ones I ever saw just shipped whatever the default icons were in SMF at the time.[1] I'd like to propose we make it a single set of icons.
2. Get rid of this 'enable customised icons' nonsense.
There is really no need for this nonsense. There is, yes, the argument to be made about performance, but caching would fix that anyway. We'd get a simpler and better to use UI out of it.
3. Drop the enforcement of it being .gif
There's really no reason why it must be .gif, other than having a standard format to work with. But that's solvable through another thing.
Then we can get a bit more exotic if we wanted.
4. Stop storing it as a textual item.
If we're already storing them in the database anyway, we will already have numeric ids for them. I see no reason why we can't make proper use of them and just store a numeric id in the messages table and be done with it (yes that would SAVE space!)
This isn't without its issues, because it would mean that all the silent-forced changes that occur (for iPod/iPhone/tablets/Android etc. not to mention moved notices, deleted posts at present and posts with attachments) would also have to be in that table. This raises other issues (what happens if the user deletes them? what happens with migrating existing SMF stuff including this site?)
I'm not exactly dead set on this one, but it is certainly an option to explore and not without its caveats. Though it could also mean the user doesn't want those things set, e.g. if they delete the tablet one, don't use that replacement later.
5. Topic filtering
Assuming we make it a numeric id, we could store that numeric id in the topics table (first post's)... it would allow us to stick an index on it and then filter topics on it. Of course, any plugin that adds its own would be rather awkward but it's not insurmountable.
/discuss
| 1. | This is most notable in the Bloc themes where they were upgraded from 1.1.x to 2.0 themes but kept the 1.1.x message icons. |






