« Quote to PM
Guess the Feature
Rewriting the skin file parser... »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Guess the Feature
« on February 19th, 2013, 06:05 AM »
So I'm working on a new feature and as ever this means new UI, and I suck at UI.

But here's the WIP as it stands. I'm sure you'll have no difficulty guessing what feature this is (first picture is older than second, it's still evolving and nothing is set yet)

📎 email_template_editing.png - 51.52 kB, 946x922, viewed 252 times.

📎 email_template_editing2.png - 52.19 kB, 932x868, viewed 233 times.

When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Farjo

  • "a valuable asset to the community"
  • Posts: 492
Re: Guess the Feature
« Reply #1, on February 19th, 2013, 11:32 AM »
That will be an excellent feature to have (and the UI looks good to me).

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Guess the Feature
« Reply #2, on February 19th, 2013, 09:38 PM »
For those wondering what the 'doing it properly' comment was all about... hopefully this will explain it, when I mention that there are something like 48 email templates (including 1 I removed today because I cannot find anywhere in the code it is triggered)

Yes, I did go through every email template (including in some cases tracing back through the code) to figure out what variables could be used in that template. The result is worth it, though. Don't ask me why some of those variables are present, I have no idea.

📎 email_template_editing3.png - 49.96 kB, 954x696, viewed 222 times.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Guess the Feature
« Reply #3, on February 19th, 2013, 09:41 PM »
It's one of the most frightening language files there are.......

Okay, it's THE most frightening one... ;)
I actually always refused to touch it when I took over the task of overviewing the translation. It's the only file I didn't touch (along with the Manual, because it was to be gone soon after anyway...)

Oh my, I just noticed there are several more unread topics for me here from last night...... Oops :^^;:
Busy with stuff.

Oh, can't bother to find the proper topic for this quick one: I'm currently reviewing the various icon files for Wedge, and noticed there's still msntalk.gif in there... Shouldn't we move it to a skype.gif icon..? Also update ManageMemberOptions.php for that, I guess..? I don't know much about MSN, but I heard they'd switched over completely to Skype...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Guess the Feature
« Reply #4, on February 19th, 2013, 09:53 PM »
Quote
It's one of the most frightening language files there are.......
And it's much nicer now. Or it will be when it's committed. I ripped out the secondary layer of arrays, plus all the random documentation blocks and it's looking much friendlier (bad news: there's an extra line of language per email template as the one-line description, sorry about that)

But that's sort of the point of this feature - so that people who want to customise it never have to touch the file manually.
Quote
Oh, can't bother to find the proper topic for this quick one: I'm currently reviewing the various icon files for Wedge, and noticed there's still msntalk.gif in there... Shouldn't we move it to a skype.gif icon..? Also update ManageMemberOptions.php for that, I guess..? I don't know much about MSN, but I heard they'd switched over completely to Skype...
Removing it is easy enough. Switching over, not so much. I couldn't find out with any reliability what the Skype user name would be or what the rules are, or for that matter what to put as the link (with any reliability) so it sort of fizzled out on that score.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Guess the Feature
« Reply #5, on February 20th, 2013, 02:14 AM »
I didn't realise there was so much mail :o
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Guess the Feature
« Reply #6, on February 20th, 2013, 02:15 AM »
Yeah, it's pretty horrendous actually. I know I've added one template to Wedge since we started and I've removed one today. It is possible others were removed in the meantime but I can't put my finger on if/when that happened.

The file is much tidier now.
« Quote to PM
Rewriting the skin file parser... »