Nao

  • Dadman with a boy
  • Posts: 16,079

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Auto_increment madness...
« Reply #16, on July 12th, 2012, 08:44 PM »
I envision that it isn't really a problem if we end up avoiding making rows we don't need - right now there are phantom rows being introduced that leak ids even faster. If we reduce that from happening, we reduce the problem anyway.

But even as I've typed this, I can see we're only onto #8556 out of how many thousands of millions...?
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Auto_increment madness...
« Reply #17, on July 12th, 2012, 09:33 PM »
I dont remember this story about phantom rows.
Really.

8500+ is a lot for a basically temp table.
We could add a maintenance task to flush the cache though. Like, "okay the forum is quiet these days, I can do that..."

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Auto_increment madness...
« Reply #18, on July 12th, 2012, 10:03 PM »
Quote
I dont remember this story about phantom rows.
You're the one who reported it - where drafts get saved even when they shouldn't be - the result is phantom rows that shouldn't really be saved in the first place.
Quote
We could add a maintenance task to flush the cache though. Like, "okay the forum is quiet these days, I can do that..."
If you mean the regular cache, there should be no need to do that automatically most of the time, it should just work with older data just being purged over time.

If you mean cases like this, I'd suggest not doing that on an automatic fashion. I'm not sure it's ever going to be a problem.

As per http://stackoverflow.com/questions/6130672/mysql-auto-increment-primary-key-running-out there are notes about keeping the primary key as small as possible (especially on InnoDB), and that's important as that's now the default in MySQL. Let's leave it as is and we can deal with it if and when we actually get near to those limits.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Auto_increment madness...
« Reply #19, on July 13th, 2012, 12:02 AM »
Quote from Arantor on July 12th, 2012, 10:03 PM
Quote
I dont remember this story about phantom rows.
You're the one who reported it - where drafts get saved even when they shouldn't be - the result is phantom rows that shouldn't really be saved in the first place.
Well, err... I thought you'd fixed that one...?
Once I find a bug of mine, I tend not to let go until it's fixed. (Just spent 3 hours on a stupid JS bug in playlist pages... My dear Opera, it was your fault... You failed to report that it was a declaration error.... -_-)
Quote
Quote
We could add a maintenance task to flush the cache though. Like, "okay the forum is quiet these days, I can do that..."
If you mean the regular cache,
No, I mean the draft table (the draft cache).
Quote
If you mean cases like this, I'd suggest not doing that on an automatic fashion. I'm not sure it's ever going to be a problem.
Well, if the table is filled, I guess we can always tell them to do a TRUNCATE on it...
Quote
As per http://stackoverflow.com/questions/6130672/mysql-auto-increment-primary-key-running-out there are notes about keeping the primary key as small as possible (especially on InnoDB), and that's important as that's now the default in MySQL. Let's leave it as is and we can deal with it if and when we actually get near to those limits.
Interesting.

Yeah, I just don't wanna be accused of thinking on the short term. But we've got a long way to go until Wedge is run on a billion-post forum!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Auto_increment madness...
« Reply #20, on July 13th, 2012, 12:09 AM »
Quote
Well, err... I thought you'd fixed that one...?
I fixed most of it but you since showed me that there are edge cases where it still happens which haven't yet been fixed.
Quote
Well, if the table is filled, I guess we can always tell them to do a TRUNCATE on it...
*nods*
Quote
Yeah, I just don't wanna be accused of thinking on the short term. But we've got a long way to go until Wedge is run on a billion-post forum!
I'll be happy with running it on a multi-million post forum. I've only seen one billion-post forum in the past and they started out on phpBB2 some years back (and have since rewritten it - that's Gaia Online), everyone else of that sort of scale (the likes of Slashdot et al) wrote their own.

Biggest SMF forum I've seen is 22m posts and growing daily.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Auto_increment madness...
« Reply #21, on July 13th, 2012, 01:25 AM »
Quote
Biggest SMF forum I've seen is 22m posts and growing daily
WCRPG? It regularly gets around 50,000 posts PER DAY!
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Auto_increment madness...
« Reply #22, on July 13th, 2012, 01:32 AM »
Yeah, that's the one, it's pretty insane and holds together by miracles I'm sure. It's still running on Apache for example >_> (Liroy needs to move that to nginx ASAP)

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Auto_increment madness...
« Reply #23, on July 13th, 2012, 07:52 AM »
Quote from Arantor on July 13th, 2012, 12:09 AM
Quote
Well, err... I thought you'd fixed that one...?
I fixed most of it but you since showed me that there are edge cases where it still happens which haven't yet been fixed.
Oh... The iPod thing...?
Crap... :(
I'd moved on. Never really had another opportunity to look at my drafts. I just looked at them now and sure thing, I have some drafts from this week that are quite obviously from iPod posts... :-/
Quote
I'll be happy with running it on a multi-million post forum. I've only seen one billion-post forum in the past and they started out on phpBB2 some years back (and have since rewritten it - that's Gaia Online), everyone else of that sort of scale (the likes of Slashdot et al) wrote their own.
It's been years, and I have yet to understand the point in Gaia Online...
Well, to each their own! If I could create my very own Gaia Online I wouldn't care what others think of it :P
Quote
Biggest SMF forum I've seen is 22m posts and growing daily.
And I don't understand its point, either...