« Multiple default skins?
Moving topics, you can now send a PM
"Select" code on iPhone »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Moving topics, you can now send a PM
« Reply #15, on April 27th, 2012, 05:23 PM »
That's the thing... The more custom code we add to 'ignore' a meta-board like this, the more complicated it gets.
Maybe we should have a flag for boards, like 'meta', which when set will add them automatically to ignored boards... Dunno.
Or just ensure boards in query_see_board are in ('blog', 'board', 'site') or something... Which I don't like.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Moving topics, you can now send a PM
« Reply #16, on April 27th, 2012, 05:26 PM »
I'd go with the meta implementation, but I'd do it based on just hiding the board generally rather than using it for ignore boards.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Moving topics, you can now send a PM
« Reply #17, on April 27th, 2012, 05:30 PM »
Well, it's in query_see_board that we'll have to set this up, so it's not going to be a straight 'ignore' which is handled by query_wanna_see_board IIRC...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Moving topics, you can now send a PM
« Reply #19, on April 27th, 2012, 05:35 PM »
I guess I'll deal with that.

Hopefully it won't break performance to add another test. Then again, the boards table is never gonna be TOO big... Or could it? Well, with custom boards like blogs and so on... I dunno. Even Noisen has no more than a hundred boards IIRC.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Moving topics, you can now send a PM
« Reply #20, on April 27th, 2012, 05:37 PM »
I know sites that have hundreds of boards, though it is certainly rare.

But if the test is integrated into the underlying list of boards to exclude before it's turned into SQL, it should be OK.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Moving topics, you can now send a PM
« Reply #21, on April 27th, 2012, 05:42 PM »
Oh... I see what you mean. Instead of doing a test on the meta field, we'd simply cache the list of meta boards somewhere, and then simply add AND id_board NOT IN (..., ...) to query_see_board..?

Makes more sense, actually. :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Moving topics, you can now send a PM
« Reply #22, on April 27th, 2012, 05:43 PM »
Well, mostly. There's already a list of boards built for id_board IN (...) that makes query_see_board. That array of boards itself is actually cached too in Load.php, meaning that you only need to update that array so that it's never allowed in the first place in that list, if that makes sense.

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Moving topics, you can now send a PM
« Reply #24, on April 27th, 2012, 05:59 PM »
I actually didn't implement it with floating boards in mind, it was mostly to support the changes to how board access was evaluated.
« Multiple default skins?
"Select" code on iPhone »