« Requiring JS in the admin panel
Selectbox
Some admin menu changes »

MultiformeIngegno

  • Posts: 1,337
Re: Selectbox
« Reply #90, on January 8th, 2012, 05:49 PM »
Quote from Nao on January 8th, 2012, 05:27 PM
DEMO UPDATED TO 1242!
Posted: January 8th, 2012, 05:15 PM

BTW -- quickest way to see the awesomeness of the select box in action: menu > PM > Send message.
Just play with the three select boxes in the post/pm editor. They're HTML, two of them have a scrollbar (with the small hover effect), and it just works flawlessly. :)
Scrollbars work really well!! And they're... sexy!! :lol: :yahoo:
The only "glitch" I noticed is for the "Quick access" scrollbar. It lags 1 second the first time you click on it, then it's ok as the others. :-/

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Selectbox
« Reply #91, on January 8th, 2012, 05:50 PM »
Quote
The only "glitch" I noticed is for the "Quick access" scrollbar.
By design. The first time you click it, it gets all the list of boards you can see, to populate the box. Just like SMF does.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

MultiformeIngegno

  • Posts: 1,337
Re: Selectbox
« Reply #92, on January 8th, 2012, 06:00 PM »
Uhm.. and if it retrieved all the boards at page load? So it wouldn't "lag" when you click the scrollbar. Yes this will add some bytes to be loaded but I don't think that will be much..

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Selectbox
« Reply #93, on January 8th, 2012, 06:02 PM »
It will add some bytes and an entire query *every single page*. Considering the frequency that goes with usage of the quick access/jumpto, it's really not worth the processing overhead every single page for it.

MultiformeIngegno

  • Posts: 1,337
Re: Selectbox
« Reply #94, on January 8th, 2012, 06:06 PM »
Uhm yes you're probably right.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Selectbox
« Reply #95, on January 8th, 2012, 06:22 PM »
If it were used far, far more (like every other page or so by every other user or so) then it might be worth it but as it stands, it's probably not worth it. Even going through the whole cache thing isn't really worth it, IMHO.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Selectbox
« Reply #96, on January 8th, 2012, 07:38 PM »
Quote from Lurker on January 8th, 2012, 05:36 PM
Quote
changelog.txt's first line, SMF?
Updated manually by the team. The amount of times they forgot to update it...
No, what I mean is that when they updated the changelog.txt file, the SVN server would automatically update the rev number in the first line. They *do* have to update that file to add the changelog themselves, but the first line is modified by the server itself, thanks to a magic variable. I remember being a bit surprised when I got my files fucked up after making a couple of commits on the SMF SVN ;)
(Ahh... Good times.)

Demo updated to rev 1243!

Regarding the Quick Access, yes, I for one wouldn't fill it directly with the board data. I actually think that we should even use that for the quick mod select box, where the board list is filled in at page generation time --- grrrrr.
Just have a look at Noisen... It has dozens of boards, if not hundreds (I don't think it shows boards that are created but not filled.)
Now imagine loading that list on every single board page... :-/
It's 'doable', especially with today's bandwidth availabilities, but it's still a waste.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Selectbox
« Reply #97, on January 8th, 2012, 11:13 PM »
In which case their SVN server does some magic in the post_commit hook. One of the perks of hosting your own SVN at least.

There's no hook for on-checkout or on-update, the hooks are things triggered by a commit, either pre-commit or post-commit, and unless you fancy the core code having the SVN rev in it and milestone/release builds handled manually (compared to the actual core, e.g. actually manually or at least through some kind of script) there's no good way to deal with it.


Re the board listing, I wouldn't have a problem making the quick moderation adhere to that. In fact, I've been wondering about whether that needs changing; the fact that so many people ask where it went makes me think we should make it on by default - or even making it the *only* option, so if you can't moderate, you don't see it at all but if you can, that's the only view you get.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Selectbox
« Reply #98, on January 8th, 2012, 11:35 PM »
Quote from Lurker on January 8th, 2012, 11:13 PM
In which case their SVN server does some magic in the post_commit hook. One of the perks of hosting your own SVN at least.
It's all in here...
http://svnbook.red-bean.com/en/1.4/svn.advanced.props.special.keywords.html
Quote
Re the board listing, I wouldn't have a problem making the quick moderation adhere to that. In fact, I've been wondering about whether that needs changing; the fact that so many people ask where it went makes me think we should make it on by default - or even making it the *only* option, so if you can't moderate, you don't see it at all but if you can, that's the only view you get.
Agreed...

Wanna do it?

And for the jumpto on this field? You or me? Can add to my to-do (although it's a bit crowded...), as you like.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Selectbox
« Reply #99, on January 8th, 2012, 11:38 PM »
Quote
It's all in here...
Hmm, did they introduce that into the core software somewhere so that it would be added to index.php and shown in the footer, or was that only on their dev server for daily builds? I can't remember now.
Quote
Agreed...

Wanna do it?

And for the jumpto on this field? You or me? Can add to my to-do (although it's a bit crowded...), as you like.
There's two things here? I think jumpto should be extended to that field too, I just don't know when it'll be done :/ I really need to get back into the swing of PHP dev, spent a lot of the last few weeks doing all sorts of nice non-PHP dev.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Selectbox
« Reply #100, on January 8th, 2012, 11:59 PM »
Quote from Lurker on January 8th, 2012, 11:38 PM
Hmm, did they introduce that into the core software somewhere so that it would be added to index.php and shown in the footer, or was that only on their dev server for daily builds? I can't remember now.
No, it's just the basic $Rev$ var or something, that updates the changelog.txt file and only that file, when it's being modified.
Quote
There's two things here? I think jumpto should be extended to that field too, I just don't know when it'll be done :/ I really need to get back into the swing of PHP dev, spent a lot of the last few weeks doing all sorts of nice non-PHP dev.
So... Does that mean I add it to my to-do? :P

Oh, here's what I was working on tonight... Was trying to find some kind of solution to make the userbox column into a nice monolithic thing without modifying the current HTML structure. Here's the result...
Is it worth exploring? Maybe not for Wine, but for one of the other stock skins..?
PS: right-click image and choose to view/open it, otherwise you won't see the bit that matters :P
PPS: we really, REALLY need to remove these icons in the userbox... They're pointless now, at least for JS users.

Dr. Deejay

  • Happy new year all!
  • Posts: 118
Re: Selectbox
« Reply #101, on January 9th, 2012, 12:29 AM »
Wow that looks nice :D

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Selectbox
« Reply #102, on January 9th, 2012, 07:25 AM »
The overall screenshot or the effect I asked about? :P
Re: Selectbox
« Reply #103, on January 10th, 2012, 11:31 AM »
Bump for messages above... (?)

In other news.
Looked into many Wedge pages, and it turns out, many select boxes are broken by the new code... Yay.

For instance, if I hide a select box only to have it show up later (e.g. board list in quick mod on MessageIndex), it'll fill in the entire width of the container and be generally buggy.
Also, similarly, if you select a quick mod option, the select box will enlarge... Meh, an obvious bug.

My, why didn't anyone see that one? I always assume that people tend to test my stuff when I upload them on the demo site. Will I have to check every single select box in the entire codebase then...?

The only good news today is that I've found an extra couple of tricks to reduce the size -- it's now at 2577, down from 2669 which I already considered to be as short as it could be...

billy2

  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 350
Re: Selectbox
« Reply #104, on January 10th, 2012, 12:33 PM »
On the demo site,
I Started a new p-message and in the "To" box I typed "bil".
"Billy2" dropped down as expected, I selected Billy2.

The "To" box remained as "bil" even though I selected "Billy2" and wouldnt obviously send as "bil" as it was not a user account.
It seems the same for a couple of other users I tried.





<br /><br />cough, cough.
« Requiring JS in the admin panel
Some admin menu changes »