« Modify Own Post
Thought system
Shole's List »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Thought system
« Reply #75, on November 16th, 2011, 11:19 PM »
I'll take a look in a bit; Safari was the one main system I hadn't tested it on.

I opined elsewhere that part of the problem with SMF's fixes to this problem is that they didn't have a battery of tests to work on, meaning that they were fumbling around in the dark trying to find directions. In the same discussion, I noted that the list of tests to be carried out is:
Quote
* A filename with no special characters or symbols other than file delimiter (file.txt)
* A filename with 7-bit symbols characters, but no spaces and no + (file_test.txt, file-test.txt)
* A filename with 7 bit characters, and a space (file test.txt)
* A filename with 7 bit characters, and a + (file+test.txt)
* A filename with 7 bit characters, and a space and a + (file test+results.txt)
* A filename with high bit characters (any ISO encoding, on ISO encoded forum) (file™.txt)
* A filename with high bit characters and a space (ISO encoding) (file name™.txt)
* A filename with high bit characters and + (ISO) (file+test™.txt)
* A filename with high bit characters and a space and + (ISO) (file test+results™.txt)

All of the high bit character tests will then need to be repeated on a UTF-8 forum with UTF-8 encoded filenames, and if any of the 7 bit tests fail, there is no point with the high bit tests until the 7 bit tests pass.
In fact I realise I missed single and double quotes off the list but " is not valid in most systems' filenames anyway. (And in the code I wrote, it would be safely rawurlencode'd anyway)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #76, on December 12th, 2011, 06:03 PM »
Oh my... It would appear the little f*cker is dead.

I don't know why or how. It just doesn't register when I edit or type in a new thought.

Can anyone who tested the thought system (on a local copy) so far give me some feedback on this...? Did you ALWAYS see that issue? Send a thought -> the return copy is empty and nothing is entered into the DB. No errors either...
I really don't want to bother with Ajax debugging right now :(
Posted: December 12th, 2011, 06:01 PM

Oh, and I also messed up rev 1179... It was last month already -- and I committed a file that wasn't supposed to be (index.css), with selectbox styling for a feature that wasn't even in...

Pete or anyone, when you see that kind of file and it's NOT documented, can you report it please...? It usually means I forgot to uncheck a file that's not ready for consumption... (And yes I do have a fair share of files I have to uncheck every time. Pretty annoying really. But if I start putting them on Ignore, I'll just forget to deal with them in the future...)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Thought system
« Reply #77, on December 12th, 2011, 06:06 PM »
Quote
Oh my... It would appear the little f*cker is dead.

I don't know why or how. It just doesn't register when I edit or type in a new thought.
Hmm, I thought this was fixed? It's worked for me though I haven't tested it recently.
Quote
Pete or anyone, when you see that kind of file and it's NOT documented, can you report it please...?
See, I didn't realise it wasn't supposed to be in there, knowing that the selectbox was coming up...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #78, on December 12th, 2011, 07:39 PM »
- It was fixed and working great, at least when I last dealt with it... i.e. it must have broken after that, while fixing something else in an unrelated place. Can you confirm and look into it?

- Just to be clear: if I ever commit "work in progress" code with shitty commented out stuff, it is NOT as planned, unless I'm clearly specifying it in the changelog (I usually apologize for this kind of thing.) I also found out that rev 1186 has my work-in-progress script.js committed... Just the same: it's shitty and not as planned. And again, it's not mentioned in the changelog.

Every time you commit something, I'll make sure to ensure you haven't committed any 'weird' stuff that's not in the changelog, and if there is, I'll ask you about it... I can do that kind of mistake, too, so I was kinda hoping someone was checking on my commits...
Re: Thought system
« Reply #79, on December 13th, 2011, 03:25 PM »
Found the culprit... In Ajax.php, rev 1184, I added a wedit::preparsecode($text) on the thought. Uh...

So... It doesn't generate an error in the database. Hard to trace. I simply removed the line from my current rev and it works. And it's not related to my fixNesting stuff because it wasn't already there in rev 1184... :-/

TE

  • Posts: 286
Re: Thought system
« Reply #81, on February 15th, 2012, 08:31 AM »
question: is there an option to enable / disable the thoughts system inside the admin area? Maybe I'm blind but I can't fine one   :angel:
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #82, on February 16th, 2012, 03:49 PM »
Nope... It's obviously something I'll add later on. But it's not my priority, honestly. I want to give it a chance to get known... :P (Obviously, at the very least it'll be enabled by default...)
Re: Thought system
« Reply #83, on May 24th, 2012, 11:32 PM »
Okay, so it's not ready for use on Wedge.org but I decided to throw away the thought list on profile pages -- never intended to keep this because it created huge pages and was a bit buggy.

So, here's how it'll be done now:

- The homepage lists the latest thoughts, like now.
- The author link will point to their actual profile, not their profile page's thought list
- There's a new mini-icon next to the thought date. Follow it to reach the thought thread page.

The thought thread is basically all thoughts gathered under the same id_master, i.e. any thought that sprang as a reply to a single thought.
It can create a page with one thought, or a page with several dozens -- although it's very unlikely.

The profile pages will now list only the author's thoughts -- without any contextual thoughts around them, split by pages, and accompanied by a link to the corresponding thought thread.

Although it makes it a bit 'harder' to follow someone's thoughts in context, I think it's definitely the better way to show thought lists. Really... (Plus, it makes the code a bit simpler.)

PS: I also fixed several minor bugs today, in case you didn't notice on wedge.org, eheh...
PPS: that quick edit animation looks really neat... I think it'll take more than a week for me to get bored of it :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Thought system
« Reply #84, on May 25th, 2012, 06:56 PM »
It certainly covers viewing a single conversation, which is the ideal IMO.

What you seem to lose is an easy way to view everything off a single person but I'm not sure that's a great loss at this time. I think it's going to be something we need to let run and let people play with and get to use. That said, I have a feeling your instinct is right on this one, it's usually pretty good.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #85, on May 25th, 2012, 07:47 PM »
Actually, Wedge.org still shows thoughts by a single user...? It's in the same place as always: profile > show thoughts.
The difference now is that they're shown just like on the main page. There's a link to the thread for each thought, as well as a "(...)" in case there are replies to a particular thought. (I know, it may not be very intuitive...)
I still need to add paging to these, though...

Re: what I said on the skin topic, how are we going to manage 'walls'?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Thought system
« Reply #86, on May 25th, 2012, 07:54 PM »
* Arantor is tired, was not sure (hence the 'what you seem to lose...' comment)

Managing walls in what respect?

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #87, on May 25th, 2012, 08:19 PM »
I think I'm done with the thought rewrite... Phew.
Not perfect, but good enough.

Walls ==> well, at one point we're going to offer user streams, right...? We already discussed doing them like some of the admin logs, to help with translations. So, what about the thought system? Do we use thoughts for the streams, or do we copy any thoughts into the stream, assuming that a stream may have a shorter or longer 'expiry date' than thoughts...?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Thought system
« Reply #88, on May 25th, 2012, 08:23 PM »
Oh, I see what you mean.

Since it's not a wall, per se, but a stream of notifications (at least that's what I want to do), you only need to worry about notifying replies up the chain, and really that's only necessary up to the immediate parent IMO.

The stream by definition has a shorter life (I'm thinking 3-5 days for notifications you've seen before, no limit on unread notifications, for now at least)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Thought system
« Reply #89, on May 25th, 2012, 08:34 PM »
Quote from Arantor on May 25th, 2012, 08:23 PM
Since it's not a wall, per se, but a stream of notifications (at least that's what I want to do), you only need to worry about notifying replies up the chain, and really that's only necessary up to the immediate parent IMO.
Eh..?
Quote
The stream by definition has a shorter life (I'm thinking 3-5 days for notifications you've seen before, no limit on unread notifications, for now at least)
So, I take it you don't want to do something like FB, right..?

And what about wall comments? The thought system is well suited for that, too... (Of course, we could also consider these to be part of the 'profile' type of board, and create a new topic on each notification being commented... Uh... Then that means multiple topics per user...? How do we store that... Meta field eh?)
« Modify Own Post
Shole's List »