These two bytes may not matter to you...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #45, on August 16th, 2011, 06:08 PM »
Quote
So far so good, but apparently sessions are named smf_sess_*. Do you think it's still okay to replace them? I mean, at the worst it'll reset the session, right...?
It's fine. Yes, it will reset the session. As long as the same name is consistently used after replacing, it's absolutely fine.
Quote
Oh, and I know it means we can take even less code verbatim from other versions of SMF... But do we really need to?
Other than the base is there anything we'd actually want to take verbatim from SMF anyway? Seems to me as though it's something we neither want or need to worry about.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: These two bytes may not matter to you...
« Reply #46, on August 17th, 2011, 10:30 AM »
Quote from Arantor on August 16th, 2011, 06:08 PM
It's fine. Yes, it will reset the session.
Yeah it's not a bad thing per se...
Quote
Other than the base is there anything we'd actually want to take verbatim from SMF anyway? Seems to me as though it's something we neither want or need to worry about.
Agreed.
I mean, it would be a bit dishonest of us to take code from SMF when we're preventing them to use ours...
I guess bug fixes don't fall into this -- if only because I've myself pointed out bug fixes to them for years, and even made the changelog accessible with the list of fixable bugs...

Also. I'm changing define('SMF') to something else. I could use WE: it's shorter. But it would only save ~200 bytes across the entire project, so... Well. As for WEDGE, it's longer, makes us waste an extra 400 bytes, but OTOH I'd rather have the full software name in here. So I'm changing to WEDGE, please tell me if you disagree. Otherwise, no need to reply ;)
Re: These two bytes may not matter to you...
« Reply #47, on August 17th, 2011, 01:28 PM »
Pete, just wondering... Did you make sure to remove corresponding $txt variables when you removed tons of features, mainly at the beginning...? Because I still found another unused variable... And I'm starting to wonder if you made the check at all...? Rule of thumb: always check for dependencies when I remove something... :whistle:

Maybe we could, hmm, build some tool that would take all of the $txt variable names and check whether they're used in any template or source file... I'm sure we could remove tons of entries that way!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #48, on August 17th, 2011, 01:31 PM »
I missed a few but by and large I do remove them as I go, I try to make sure I check at least. Some of the strings you've pulled out lately aren't properly used in SMF either...
Quote
I'm sure we could remove tons of entries that way!
Bad idea. Quite a few strings are identified programmatically, never directly, such as most of the errors in the Errors language file that have error_ as a prefix, or compound ones like we use in the newer numeric context function. We'd probably end up spending more time hunting down false positives at present.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: These two bytes may not matter to you...
« Reply #49, on August 17th, 2011, 01:34 PM »
Quote from Arantor on August 17th, 2011, 01:31 PM
I missed a few but by and large I do remove them as I go,
Because I remember how thoroughly you're doing this these days, going as far as to remove the French versions as well, so I was surprised to find this line today... Made me panic a bit :lol:
Quote
I try to make sure I check at least. Some of the strings you've pulled out lately aren't properly used in SMF either...
Yeah, the previous one I found, I added the 'SMF bug' header to it, to mention it's also a SMF problem. But the new one, I checked in SMF and it wasn't there. Hence my question. :)
Quote
Bad idea. Quite a few strings are identified programmatically, never directly,
Of course, but we could find them anyway. I'd just like for a tool to allow us to narrow down a list of suspects.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #50, on August 17th, 2011, 01:40 PM »
Quote
Made me panic a bit
We're human, we miss things, it happens. But it's not something that's hell to fix after, fortunately.
Quote
Of course, but we could find them anyway. I'd just like for a tool to allow us to narrow down a list of suspects
In that respect it would help; there are a LOT of language strings, and having a tool to indicate possibles might be useful, but I'd suggest we do it nearer to release, simply because I think we have enough to do without chasing down a list of false positives, since Errors.*.php alone will generate many, as will Who.*.php.

AngelinaBelle

  • Still thinking...
  • Posts: 92
Re: These two bytes may not matter to you...
« Reply #51, on August 17th, 2011, 02:37 PM »Last edited on August 17th, 2011, 06:37 PM by AngelinaBelle
Quote from Nao/Gilles on August 17th, 2011, 10:30 AM
dishonest of us to take code from SMF when we're preventing them to use ours...
SMF is BSD licensed. Throuought your development process, you have honestly described the process of deriving Wedge from SMF. As long as you follow the licensing agreement, you are honest.

I am guessing you will be more proud of your work if you change the constant name, the variable names, and the session name, regardless of the additional work it might cost you in the future. That pride might be a good enough reason to make those changes.
I'm an SMF doc writer.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #52, on August 17th, 2011, 02:42 PM »
Quote
As long as you follow the licensing agreement, you are honest.
Be very, very careful with that statement. I could very easily repeat most of what ttForum did, rebranding the software throughout, even released it as a paid package and still be well within the terms of the licence - provided I retained the copyrights in the code.

I'm not disputing that it's not exactly pleasant for us to be taking from SMF without giving something back, but I feel firmly that I gave a lot more to SMF than I've got back from them so far...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: These two bytes may not matter to you...
« Reply #53, on August 17th, 2011, 03:11 PM »
Yes, we can postpone $txt to later -- but remember how we postponed changing SMF stuff to Wedge for later...? I'm doing it now because I fear I will forget later, and I'd rather have done it before... :P
Quote from Arantor on August 17th, 2011, 02:42 PM
I'm not disputing that it's not exactly pleasant for us to be taking from SMF without giving something back,
We are giving things back.

- Several years of work for the SMF community from the both of us. We gave that without getting anything in return. I think at least half of the SMF team agrees that it's only fair to consider we don't owe SMF anything -- and it's the other way around.

- The changelog. It might seem like nothing, but as I said multiple times, it documents the entire list of SMF bugs that we fixed. It's up to the SMF team to process the changelog, analyze what they need changing, and do it themselves. I made over 400 bug reports at Mantis, including many *after* I was post-banned from SMF. I didn't suddenly stop spotting and fixing bugs in SMF... The only difference, now, is that I can't submit them directly to SMF because they removed my beta tester account. And even then, I'm still making the changelog public and thus the list of SMF bugs is now accessible.

- The ideas. We published our feature list months ago, and we're now discussing publicly as much as we can of our current ideas and implementations (just look at this very topic, since we're totally OT here.) Ideas can't be copyrighted. SMF can steal those ideas, we can't do anything about it -- except to take note that they considered our ideas to be good enough to steal them... We own our implementations of these ideas. But they may not even be the *best* implementations of it. (Although, TBH, I don't think the current SMF developer team is up to the task to make better implementations... :whistle:)

So, yeah, I'm sorry but at this point, I can see a lot of things we're giving back to the SMF community.
If all the SMF team wants is *for us to share our code*, then they should have asked us to become the SMF developer team a year ago. Instead, they showed us the way out, indicating they didn't feel the need for our ideas and work.

It's as simple as that... It would be quite preposterous from the SMF team to expect anything more than what we're currently giving them.
Quote
but I feel firmly that I gave a lot more to SMF than I've got back from them so far...
Couldn't agree more.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #54, on August 17th, 2011, 03:18 PM »
Quote
- Several years of work for the SMF community from the both of us. We gave that without getting anything in return. I think at least half of the SMF team agrees that it's only fair to consider we don't owe SMF anything -- and it's the other way around.
As I just noted elsewhere, not only did they get a helpdesk from me, there is still talk of them taking over SimpleDesk as a project, which would pretty much compel me to become an NPO member, though if they can wait until I release SD 2.0 and make my account vanish, there is no risk of my being drawn into the NPO.

AngelinaBelle

  • Still thinking...
  • Posts: 92
Re: These two bytes may not matter to you...
« Reply #55, on August 17th, 2011, 06:41 PM »
Quote from Arantor on August 17th, 2011, 02:42 PM
I could very easily repeat most of what ttForum did, rebranding the software throughout, even released it as a paid package and still be well within the terms of the licence
Yep.  It might not be considered friendly, but it is certainly permitted, and someone might try it one of these days.
That's the funny thing about the BSD license. It is not CC-by-SA.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: These two bytes may not matter to you...
« Reply #56, on August 17th, 2011, 07:01 PM »
Quote
Yep.  It might not be considered friendly, but it is certainly permitted, and someone might try it one of these days.
That's the funny thing about the BSD license. It is not CC-by-SA
Which was the point I was making. I think we've been more honest about our intentions than someone doing that would be.

And specifically for the record, if we went CC, I suspect it would be BY-SA-NC.

AngelinaBelle

  • Still thinking...
  • Posts: 92

Nao

  • Dadman with a boy
  • Posts: 16,082

AngelinaBelle

  • Still thinking...
  • Posts: 92
Re: These two bytes may not matter to you...
« Reply #59, on August 18th, 2011, 03:55 PM »
BSD to the "something like the old SMF license" to GPL.  That's something like the SMF/YaBB SE licensing history, in reverse.