« Plugin revs
New revs - Public comments
Resize images no in Wedge? »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #315, on February 15th, 2012, 10:45 PM »
Quote from Arantor on February 15th, 2012, 03:54 PM
Though, looking at it, I think somewhere we broke something, I go to a profile, and 'send a message' just goes to the base send-PM page, no user id is being passed.
Posted: February 15th, 2012, 03:53 PM

That is, going through the menu; the send-PM link in the personal info area is fine.
Okay fixed, thanks!
Posted: February 15th, 2012, 10:37 PM
Quote from Arantor on February 15th, 2012, 05:57 PM
I was concerned that it would break things, because there is more than one place where a default value should be thrown at the user so they have to do something but it looks like it all works properly :)
There are probably dozens of places where sbox broke something. That's what public beta testing is for ;)
Quote
See, I forget stuff like that. It doesn't help that I haven't touched jQuery much in the last 3 months, I've been working mostly in Impact which is a very different beast, though it does all kinds of neat stuff with classes and extending thereof.
Hey I'm the front-end guy, I'm not expecting you to delve into JS on a daily basis :P
Quote
Quote
I'd love to be able to do ($something = $param || 0) in PHP
As an expression? What should that expression mean logically? (Seems to me like it means $something = (bool) $param)
Would be the equivalent of... Hmm...
$something = isset($param) ? $param : 0;
More importantly, it also sets the fallback variable type. i.e. if you have "undefined || false", it the final variable will be a boolean, not undefined.
Quote
Oh, essentially being shorthand for $something = isset($param) ? $param : 0, I see. The thing is, JS has a very different idea of what a variable is compared to PHP and I think I prefer PHP's idea in that direction.
I just never was fond of isset()... Even in later versions of PHP, they added "?:", which is a nice idea, but WHO will use that anyway? Since it doesn't work on variables you're not sure have been initialized...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #316, on February 15th, 2012, 10:51 PM »
Well, I haven't seen any other places where it's broken but I guess I can give it some testing; I'm on my Mac for the rest of the evening (because my PC currently can't play DVDs, and I got the Buffy collection today!) and I have MAMP on there so I can install it.
Quote
More importantly, it also sets the fallback variable type. i.e. if you have "undefined || false", it the final variable will be a boolean, not undefined.
*nods* It's a nice shortcut, however I guess I prefer the more thorough requirement with isset().
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #317, on February 15th, 2012, 11:06 PM »
Are you planning to watch all 7 seasons of Buffy for the foreseeable future...? :^^;:

Really, don't bother testing. I don't think there are any important places where I missed it.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #318, on February 15th, 2012, 11:24 PM »
No, I'm just planning to watch an episode or two a day. Mind you, if I can find a *good* SVN client, I can develop on here as well.

(I already have Komodo Edit but it should be quite easy to make Notepad++ work)

Aaron

  • Posts: 356
Re: New revs - Public comments
« Reply #319, on February 19th, 2012, 10:50 PM »
Quote from Nao
! Tahoma is not always installed on Linux. (index.css, Wine/index.css)
Cheers for fixing that. :)
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #320, on February 19th, 2012, 11:50 PM »
I'd rather have feedback on the new 'reset' keyword you know :niark:

(Woohoo I'm so happy it's finally in... Now it's become much easier to make child skins, because you can simply inherit everything, and if you have a single element like a header that you'd like to redo entirely, you can just reset it and not have to worry about Wedge making further changes to the parent skin... :))
Re: New revs - Public comments
« Reply #321, on March 29th, 2012, 03:21 PM »
Re:

! Thoughts were using the wrong permissions for 'any', no such permission as 'moderate', since there's either 'moderate_forum' or 'moderate_board', and nothing else magically defines 'moderate' on its own. (Ajax.php)

--> I'm not exactly sure the changelog relates to what was actually committed... There was a single change in that file -- a 'moderate' instead of 'moderate_forum' (and yes, it's certainly my fault), but it doesn't change anything else (including the other 'moderate' permission test...)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #322, on March 29th, 2012, 05:28 PM »
I only noticed that one check against 'moderate', which is a permission that doesn't exist, I didn't see any other checks.

Re 'any', it does sort of fall into the own/any convention that permissions have, users can alter their own but only moderators can alter anyone else's.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #323, on March 29th, 2012, 05:36 PM »
Quote from Arantor on March 29th, 2012, 05:28 PM
I only noticed that one check against 'moderate', which is a permission that doesn't exist, I didn't see any other checks.
Err, can you look into rev 1522? It looks like the exact same thing to me...?
i.e. I did a search on allowedTo('moderate') BEFORE updating my copy, and it found two entries in the file. Your commit only fixed one. That's why I'm reporting it...
Quote
Re 'any', it does sort of fall into the own/any convention that permissions have, users can alter their own but only moderators can alter anyone else's.
I still don't get what it has to do with Ajax.php and the single change you made to it...?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #324, on March 29th, 2012, 05:58 PM »
In absence of having a real 'own/any' pair of permissions, it's using 'is it the owner' or 'can they moderate the forum'. That's really what I'm stating there, it made sense in my head >_>

Egad, I need sleep *yawn*

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #326, on March 29th, 2012, 06:16 PM »
No, all I did was make moderate_forum be the equivalent of the 'any' permission if there were actually such permissions.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #327, on March 29th, 2012, 06:41 PM »
It's like we're both deaf and we keep pretending we can hear each other... :lol:
OMG I'm sorry! Let's just say my English is not good enough to convey what I wanted to ask ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #328, on March 29th, 2012, 06:55 PM »
It's OK, I'm too zombified from walking around miles and miles of Brighton trying to take pictures to think too clearly anyway >_>

Nao

  • Dadman with a boy
  • Posts: 16,082
« Plugin revs
Resize images no in Wedge? »