Go up and go down links are backwards.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.
live627
-
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,670
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
That's... interesting since I didn't change any of the logic, just unwrapped the ifs in them. I'll take a look in a bit.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial
live627
-
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,670
Looks like the two JS functions in topic.js need swapped to fix it.
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Hmm, my fault apparently! rev 1070. Sorry :^^;: will fix.
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
In other news, remember I said about the ob_sessrewrite rewriting stuff being split up into multiple functions for clarity? I found another reason I would do that, or at least part of that.
Specifically, I'm working on WedgeDesk a bit, and there's a point where a link to a user's profile might be retrieved via AJAX. But because it's sent back via AJAX, the user name isn't reformatted.
Now, I know I can invoke the output buffer callback manually but when the entirety of what I'm sending back is:
Code: [Select]
...it almost doesn't seem worth invoking the entire buffer operation for that.
Specifically, I'm working on WedgeDesk a bit, and there's a point where a link to a user's profile might be retrieved via AJAX. But because it's sent back via AJAX, the user name isn't reformatted.
Now, I know I can invoke the output buffer callback manually but when the entirety of what I'm sending back is:
<?xml version="1.0" encoding="UTF-8"?><response><item><![CDATA[<a href="http://smf/wedge/index.php?action=profile;u=1">Arantor</a>]]></item></response>...it almost doesn't seem worth invoking the entire buffer operation for that.
Aaron
-
-
- Posts: 356
* Even with all of the keyboard shortcut additions, still managed to go from 2386 to 2351... I eat bytes for breakfast. (And if you're French: I said bytes, with a y.) (sbox.js)
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."
Nao
- Dadman with a boy
-
-
- Posts: 16,082
With pleasure! :P
Oh, and about the last rev.... It seems that there's a glitch when showing dropdowns in Opera 12. I don't know why, but the last 8 pixels or so at the bottom don't have any border, rounded corners or even box shadow... It's just plain white. If I try to inspect the element, it suddenly fixes itself, so it's clearly a bug linked to how they mark their areas as 'dirty'. Hopefully they'll fix it later... It doesn't bother me too much because it works in other browsers I tested.
Also, the new code makes an unnecessary call to .outerHeight() when repositioning a dropdown, which probably wastes a couple milliseconds, but saves a few bytes. Anyone contesting my choices? :niark:
Quote from Arantor on October 31st, 2011, 12:12 PM ...hook? :P
(I feel like the librarian in Discworld :lol:)
Oh, and about the last rev.... It seems that there's a glitch when showing dropdowns in Opera 12. I don't know why, but the last 8 pixels or so at the bottom don't have any border, rounded corners or even box shadow... It's just plain white. If I try to inspect the element, it suddenly fixes itself, so it's clearly a bug linked to how they mark their areas as 'dirty'. Hopefully they'll fix it later... It doesn't bother me too much because it works in other browsers I tested.
Also, the new code makes an unnecessary call to .outerHeight() when repositioning a dropdown, which probably wastes a couple milliseconds, but saves a few bytes. Anyone contesting my choices? :niark:
Posted: December 22nd, 2011, 10:52 AM
...it almost doesn't seem worth invoking the entire buffer operation for that.
(I feel like the librarian in Discworld :lol:)
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
I'm not sure a hook would help though :/
live627
-
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,670
Links on titlebg2 are yellowish and hard to read (advanced search)
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';' in J:\Backups\Linux Drive\www\wedge\trunk\Themes\default\ManageBoards.template.php on line 161
The profile field templates don't work. I select Facebook, Twitter, nothing happens.
Posted: December 24th, 2011, 04:49 AM
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';' in J:\Backups\Linux Drive\www\wedge\trunk\Themes\default\ManageBoards.template.php on line 161
Posted: December 24th, 2011, 05:22 AM
The profile field templates don't work. I select Facebook, Twitter, nothing happens.
Nao
- Dadman with a boy
-
-
- Posts: 16,082
First one is due to wanting to have a clear hint that they were clickable, by keeping them the same color as usual IIRC... And yeah, I know, it bothers me a bit too... I should also make links a bit smaller. But everything in my mind is controlled by how the Quick Reply link looks like... Meh.
Any color to suggest as replacement...?
Second issue: fixed, thank you. (4 errors overall in the file.)
Third issue: fixed, thank you again. This is due to the change event never being triggered because the original value was already overwritten at the time the change was tested against.
It's annoying how many bugs are going to be caused by the new select box... But OTOH, it looks really cool... :^^;:
Any color to suggest as replacement...?
Second issue: fixed, thank you. (4 errors overall in the file.)
Third issue: fixed, thank you again. This is due to the change event never being triggered because the original value was already overwritten at the time the change was tested against.
It's annoying how many bugs are going to be caused by the new select box... But OTOH, it looks really cool... :^^;:
Really impressed with the number of glitches due to the new select box code..... :( :( :(
Just have a look at the 'add/remove label' select box from the PM area. It's completely broken... Argh. I'm starting to have second thoughts about all this...
Just have a look at the 'add/remove label' select box from the PM area. It's completely broken... Argh. I'm starting to have second thoughts about all this...
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Only because so much of SMF used selectboxes in interesting and inconsistent ways. It'll be worth fixing them.
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Actually that feature was broken even before the new select box code. Hmm. Maybe it's broken in SMF as well?
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Very possibly, I'm not entirely sure how well it works, most don't even know it's there...
Nao
- Dadman with a boy
-
-
- Posts: 16,082
I used to use it a couple years ago. The feature would benefit from having default labels like {to_answer} etc. No?