New revs - Public comments

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #375, on April 29th, 2012, 08:21 AM »
Quote from willemjan on April 28th, 2012, 03:06 PM
I'm not sure what you guys have done, but this site allways looked great on my phone. Today well errr lets say it did not. It seems to have shrinked in width or something?
Shrunk where?
There's a default mobile theme. You can change it if you don't like it... But seriously, I don't understand how you could find the desktop version to be more desirable (for an HTC Desire) than the wireless skin, which is precisely geared towards improving readability and usability...
Heck, I can't live without it now.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #376, on April 29th, 2012, 02:36 PM »
Quote from Nao on April 29th, 2012, 08:19 AM
Quote from Arantor on April 28th, 2012, 02:17 PM
Well, it was annoying me that we had about a 1/3 of the area tied up with an almost entirely empty pair of table cells, which were legacy and needed to be moved somewhere.
Then are you annoyed too at the extra space left by the sidebar in long pages...?
(Heck, I could very well set up the sidebar so that it's a float and thus allows the page to extend, but I'm not a big fan of the idea of not letting the user control the maximum width of a post, at least per page...)
Quote
In that case, check the board's configuration and check you set the default ordering correctly ;)
Default ordering? There's default theme, default language, but no default ordering, is there...?
I actually have the sidebar at the bottom because I don't have my browser at full size (it would look a bit silly in other sites to run at 1920 wide)

As far as ordering, there isn't a UI for it, just as there isn't a UI to determine whether a board is a blog or not. However, in the boards table there is the sort_method and sort_override columns, sort_method defaults to last_post (order by last post in a topic) with the direction being set as naturally descending.

The override part allows four options: ascending/descending and natural/forced. Natural means that it defaults to whichever you've set of asc/desc, but forced means that it only allows that order and sort method.

Sorting method can be based on subject (alphabetically), starter, last poster (both by user name IIRC alphabetically), number of replies, number of views, and first post and last post. Blogging, typically, would use first post rather than last post.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

willemjan

  • Projects, projects, projects......
  • Posts: 25
Re: New revs - Public comments
« Reply #377, on April 29th, 2012, 04:12 PM »
Quote from Nao on April 29th, 2012, 08:21 AM
Quote from willemjan on April 28th, 2012, 03:06 PM
I'm not sure what you guys have done, but this site allways looked great on my phone. Today well errr lets say it did not. It seems to have shrinked in width or something?
Shrunk where?
There's a default mobile theme. You can change it if you don't like it... But seriously, I don't understand how you could find the desktop version to be more desirable (for an HTC Desire) than the wireless skin, which is precisely geared towards improving readability and usability...
Heck, I can't live without it now.
See attaches.

📎 2012-04-29_12-03-35.jpg - 58.37 kB, 480x800, viewed 1,782 times.


live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

willemjan

  • Projects, projects, projects......
  • Posts: 25
Re: New revs - Public comments
« Reply #379, on May 1st, 2012, 05:20 PM »
Well, for one the menu is not looking good. There is an gap at the right, and the register button is on an new line. Thats what I mean with shrinked, at first, it was just 1 line.

I also miss the date and time of the post. I'm not sure if this is an bug, or intended, but I just really miss it.

Things get more messy when I log in.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: New revs - Public comments
« Reply #381, on May 1st, 2012, 10:25 PM »
Quote
I also miss the date and time of the post. I'm not sure if this is an bug, or intended, but I just really miss it.
Isn't it on the top right of the post?

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #382, on May 3rd, 2012, 08:11 PM »
In Xml.template.php, there's a template_results function... It's apparently an Ajax return function for search results.
However, it's never used in Wedge. It's actually used for remote searches on the SMF official website (Admin.php in SMF2), but never here.

I'm going to remove it, but I'd like to know if there's any reason to keep it in...

Also, I'd like to merge QuoteFast.php (5KB) into Ajax.php, and possibly JsModify.php (12KB) as well. I don't see much of a reason to multiply files that are of such a small size... It's alright for big files like Search.php/Search2.php, but other than that, considering we gave up on the idea of automatic action file discovery...
Posted: May 3rd, 2012, 08:05 PM
Quote from Arantor on April 29th, 2012, 02:36 PM
I actually have the sidebar at the bottom because I don't have my browser at full size (it would look a bit silly in other sites to run at 1920 wide)
Same here. I have the sidebar enabled in Opera, with my list of tabs, because with 736 tabs (as of now...), it's definitely impossible to use the horizontal tab bar for switching between tabs.
Heck, I absolutely hate Google for removing their vertical tabs sidebar, because it was actually usable at the time... It was a bit buggy, but removing it also removed my interest in Chrome entirely. (Heck, now I do my Chrome testing under... Maxthon Webkit, because it's got a more usable tab UI.)
Quote
As far as ordering, there isn't a UI for it, just as there isn't a UI to determine whether a board is a blog or not.
Yeah, there's also plenty of other options that are missing some kind of UI... Eh. (Mostly mine :P)
Quote
However, in the boards table there is the sort_method and sort_override columns, sort_method defaults to last_post (order by last post in a topic) with the direction being set as naturally descending.
(Modified after your post. Seems to work now.)
Quote
Sorting method can be based on subject (alphabetically), starter, last poster (both by user name IIRC alphabetically), number of replies, number of views, and first post and last post. Blogging, typically, would use first post rather than last post.
Before we forget -- when we add UI for choosing blog types, it should act as a 'template' like in the custom fields, i.e. it'll automatically set up other things in the page but users will be free to change them... I suppose that's how you envisioned it, too?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #383, on May 3rd, 2012, 08:12 PM »
If it's not used for anything other than receiving those results, get rid of it because we don't need it.

As far as multiplying small files goes, it's a tricky one. Certainly for such things it would be faster to have the small files for specific actions rather than big files containing everything (because that all still has to be loaded and parsed even if not run).

In hindsight it was one of the things I didn't like about SimpleDesk in the end was putting all the AJAX stuff into a single file, when all the AJAX code was all called for every action even if only part of it was ever used. There is a part of me that would prefer to break things down where there's no commonality to code (if they don't have any shared code, split 'em up) but I can see the argument about fewer files too.

One thing I would say at this juncture is that I would quite like to split Aeva-Gallery up a bit. Loading all that code for every single action=media item (including items, previews, albums, etc.) is heavy.
Quote
Same here. I have the sidebar enabled in Opera, with my list of tabs, because with 736 tabs (as of now...), it's definitely impossible to use the horizontal tab bar for switching between tabs.
I've been working with ~50 tabs lately where I've been trying to piece together stuff on Node.js etc. but 700 tabs is insane!
Quote
Before we forget -- when we add UI for choosing blog types, it should act as a 'template' like in the custom fields, i.e. it'll automatically set up other things in the page but users will be free to change them... I suppose that's how you envisioned it, too?
Pretty much, yes.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #384, on May 3rd, 2012, 08:16 PM »
Quote from willemjan on May 1st, 2012, 05:20 PM
Well, for one the menu is not looking good. There is an gap at the right, and the register button is on an new line. Thats what I mean with shrinked, at first, it was just 1 line.
The menu issue is not an issue at all. Making the text bigger makes it easier to tap an option...
Also, the menu width always depends on how many items are in there. And it depends on whether you're logged in or not, and whether you have access to all options, etc...
Quote
I also miss the date and time of the post. I'm not sure if this is an bug, or intended, but I just really miss it.
It's still there. This is apparently a bug in your browser, as it shows up right-aligned next to the user name. Your browser seems to cut off the post right there... :-/
Re: New revs - Public comments
« Reply #385, on May 3rd, 2012, 08:28 PM »
Quick bug... Admin area > Search for 'post' > First result says "Array" (it's actually the option for signature_minposts). Looks like it's trying to echo an array...
Quote from Arantor on May 3rd, 2012, 08:12 PM
If it's not used for anything other than receiving those results, get rid of it because we don't need it.
Yup... We can always restore it later, although I doubt it. Saved 1.5KB off the 10KB filesize.
Quote
As far as multiplying small files goes, it's a tricky one. Certainly for such things it would be faster to have the small files for specific actions rather than big files containing everything (because that all still has to be loaded and parsed even if not run).
Yeah, it's perfectly true, and that's why I'm not sure about JsModify, but QuoteFast isn't used a lot I'd say, and other Ajax functions are the same... And I don't think that technically 10KB or 15KB isn't going to change the parsing time a lot. (It's not even an extra 5KB because there's the Wedge file header...)

Or perhaps we could add prefixes to the Ajax files? Ajax-QuoteFast, Ajax-JsModify...
Quote
In hindsight it was one of the things I didn't like about SimpleDesk in the end was putting all the AJAX stuff into a single file, when all the AJAX code was all called for every action even if only part of it was ever used. There is a part of me that would prefer to break things down where there's no commonality to code (if they don't have any shared code, split 'em up) but I can see the argument about fewer files too.
Let's say that we should try to keep files split up when we determine they're used relatively a lot, or they're very resource-intensive.
Quote
One thing I would say at this juncture is that I would quite like to split Aeva-Gallery up a bit. Loading all that code for every single action=media item (including items, previews, albums, etc.) is heavy.
I suppose so. Especially since it has its own folder anyway... It could be done. And it'd be a good idea to rename 'Aeva-Gallery2' or 'Subs-Aeva' to some self-explained names...
Quote
I've been working with ~50 tabs lately where I've been trying to piece together stuff on Node.js etc. but 700 tabs is insane!
Meh. About 200 of them are 'quick tabs' that I just don't have time to read... About 300 are late answers to Wedge.org... Things I promised myself I'll answer (and never will, of course.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #386, on May 3rd, 2012, 08:48 PM »
Quote
Yeah, it's perfectly true, and that's why I'm not sure about JsModify, but QuoteFast isn't used a lot I'd say, and other Ajax functions are the same... And I don't think that technically 10KB or 15KB isn't going to change the parsing time a lot. (It's not even an extra 5KB because there's the Wedge file header...)

Or perhaps we could add prefixes to the Ajax files? Ajax-QuoteFast, Ajax-JsModify...
QuoteFast is used any time you press quote to insert it into the editor. There's two sets of circumstances it can be called - either to insert from main display into quick reply, or to insert from the summary of topic into the main reply. Probably more than you'd suspect.
Quote
I suppose so. Especially since it has its own folder anyway... It could be done. And it'd be a good idea to rename 'Aeva-Gallery2' or 'Subs-Aeva' to some self-explained names...
That's the big one that occurs to me, anyway.
Quote
Meh. About 200 of them are 'quick tabs' that I just don't have time to read... About 300 are late answers to Wedge.org... Things I promised myself I'll answer (and never will, of course.)
Heh, I do know what you mean, though in my case all my tabs are passive ones that I'm keeping open until I've finished with the information therein.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs - Public comments
« Reply #387, on May 6th, 2012, 01:41 AM »
Hey guys! Now here's for a good opportunity to use the Like system: since you can't post in the New Revs topic, you can share your satisfaction with a given commit by 'liking' it :)
(Don't 'like' a technical boring commit though, as I'll know you're just trying to make me feel good... :P)

Now for a good suggestion too... Should likes be disabled if a topic is locked? My gut feeling is 'no'.
Quote from Arantor on May 3rd, 2012, 08:48 PM
QuoteFast is used any time you press quote to insert it into the editor. There's two sets of circumstances it can be called - either to insert from main display into quick reply, or to insert from the summary of topic into the main reply. Probably more than you'd suspect.
I don't use it much, really.
Quote
Quote
I suppose so. Especially since it has its own folder anyway... It could be done. And it'd be a good idea to rename 'Aeva-Gallery2' or 'Subs-Aeva' to some self-explained names...
That's the big one that occurs to me, anyway.
And I suppose you're expecting me to find the names...... :lol:
Quote
Heh, I do know what you mean, though in my case all my tabs are passive ones that I'm keeping open until I've finished with the information therein.
Easy to say, cowboy! You read faster than your shadow... :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs - Public comments
« Reply #388, on May 6th, 2012, 03:33 AM »
Quote
Now for a good suggestion too... Should likes be disabled if a topic is locked? My gut feeling is 'no'.
It wouldn't be a big deal to make a Likes configuration page which allows for disabling likes entirely (which of course has performance benefits if you don't want such things), to cover whether likes should be allowed on locked topics or not, or whether you're allowed to like your own posts or not, or even whether it is only allowed on the first post of a topic, or all posts.
Quote
I don't use it much, really.
No, neither do I, but I understand a lot of users do.
Quote
And I suppose you're expecting me to find the names......
Oh, I can sit and do it sometime but I don't know Aeva nearly as well as I'd like.
Quote
Easy to say, cowboy! You read faster than your shadow...
I know I'm not nearly as awesome as her shadow, but it's not a case of reading, it's a case of actually finding the bloody information I need first and then actually being able to apply it. Most of what I have in tabs is stuff I don't need immediately but will very shortly.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670