- Convert to is_dir, then?
- Okay!
- What does the 'be insert' mean, if it's not a typo....? :unsure:
- Okay!
- What does the 'be insert' mean, if it's not a typo....? :unsure:
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Oh, heh, yeah, 'be insert' is a typo.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial
Nao
- Dadman with a boy
-
-
- Posts: 16,082
So, the original sentence is....?
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
"User might insert 5, or 5.3, or 5.3.0" or something to that effect.
Nao
- Dadman with a boy
-
-
- Posts: 16,082
+ $params = array(&$boardIndexOptions);
+ if ($boardIndexOptions)
+ $params[] = &$categories;
+ else
+ $params[] = &$this_category;
+ call_hook('get_boardindex', $params);
I'm assuming you meant to test for include_categories...?
Wouldn't that be simpler (and more accurate)?
Code: [Select]
+ if ($boardIndexOptions)
+ $params[] = &$categories;
+ else
+ $params[] = &$this_category;
+ call_hook('get_boardindex', $params);
I'm assuming you meant to test for include_categories...?
Wouldn't that be simpler (and more accurate)?
call_hook('get_boardindex', array(&$boardIndexOptions, $boardIndexOptions['include_categories'] ? &$categories : &$this_category));Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Yes, I meant to test for that. No, you can't do what you suggest, I tried it originally and PHP complained bitterly.
Nao
- Dadman with a boy
-
-
- Posts: 16,082
- Does that mean I need to test your 3000 lines thoroughly? :P I'm kind of skipping through the large functions because they seem to be okay and I'm mainly focusing on the smaller things outside these functions, such as this... Please don't tell me I have to spend my week on that... :^^;: I still have 1600 lines left to check...
- Yeah, I remembered in the meantime: the official syntax is "$a =& $b", not "$a = &$b", because that's really "=&" and it basically says that $a is an alias to $b, and $b is an alias to $a just the same, so it's not really the same to PHP...
There are some beautiful pieces of code in your table creation function, btw :)
- Yeah, I remembered in the meantime: the official syntax is "$a =& $b", not "$a = &$b", because that's really "=&" and it basically says that $a is an alias to $b, and $b is an alias to $a just the same, so it's not really the same to PHP...
Posted: September 28th, 2011, 09:50 PM
There are some beautiful pieces of code in your table creation function, btw :)
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
I wouldn't worry about testing the code thoroughly because what will happen is that I'll be testing it by writing add-ons which will show up different weaknesses in the code, e.g. how live reported an issue with ENUM handling in the DB code, and the more hammering it gets with add-ons, the more thoroughly it's all going to be shaken out.
It might not hurt to write unit tests for the add-on manager.
And thanks :) I did try to construct something that would handle what I was going to throw at it, and it reverts one of the irritations I had in later SMF releases that the code was removed instead of fixing it.
It might not hurt to write unit tests for the add-on manager.
And thanks :) I did try to construct something that would handle what I was going to throw at it, and it reverts one of the irritations I had in later SMF releases that the code was removed instead of fixing it.
Some interesting things in r1049.
Probably the first one which occurs to me is:Quote Why? It wasn't part of $context originally for a reason: security. The only way it could be modified was through the defined hook, because as soon as it's been back from the hook, housekeeping is done then it's sent off to createMenu, whereupon it is discarded.Quote I'd rather automate that if possible. While it's not particularly ideal to sit and retest the entire menu structure for changes, if it's been to a hook, the hook is going to have added some items which will likely negate the cache.
What, exactly, is cached here? (I haven't looked yet.) I wasn't that fond in SMF of having things cached after hooks had been run, it seemed to defy the point of having per-run hooks and can lead to messiness after things have been disabled or even enabled. (Perhaps the plugin enable/disable steps should also clean cache generally anyway.)
That said, it seems to be purely CSS cached here, in which case only plugins that do... something... with CSS need to clear it? Let me know exactly what's being cached, or I'll figure it out from the source, whichever happens first, and I can then make a judgement as to whether the plugin manager should do that automatically or whether plugins that make a change there need to deal with it.Quote Icons are good. Unless they look massively out of place, they'll probably be fine and might encourage us to iconify the rest, which is generally a good thing.Quote I wouldn't worry too much about maintaining these files. As things evolve, these two plus Subs-Package are going to be phased out anyway.
Probably the first one which occurs to me is:
Also note that $admin_areas is now a global, so the admin menu hook doesn't need to specify it as a param.
if you modify the admin menu, you'll need to manually remove the cache file, or run clean_cache('css', 'admenu') through a hook or something.
What, exactly, is cached here? (I haven't looked yet.) I wasn't that fond in SMF of having things cached after hooks had been run, it seemed to defy the point of having per-run hooks and can lead to messiness after things have been disabled or even enabled. (Perhaps the plugin enable/disable steps should also clean cache generally anyway.)
That said, it seems to be purely CSS cached here, in which case only plugins that do... something... with CSS need to clear it? Let me know exactly what's being cached, or I'll figure it out from the source, whichever happens first, and I can then make a judgement as to whether the plugin manager should do that automatically or whether plugins that make a change there need to deal with it.
Added three icons to the topic moderation menu. Only visible to members with the correct permissions.
Package functions don't need to declare admin.css, since it's already declared by that time. (PackageGet.php, Packages.php)
Nao
- Dadman with a boy
-
-
- Posts: 16,082
Why? It wasn't part of $context originally for a reason: security. The only way it could be modified was through the defined hook, because as soon as it's been back from the hook, housekeeping is done then it's sent off to createMenu, whereupon it is discarded.Quote Also note that $admin_areas is now a global, so the admin menu hook doesn't need to specify it as a param.
I'd rather automate that if possible. While it's not particularly ideal to sit and retest the entire menu structure for changes, if it's been to a hook, the hook is going to have added some items which will likely negate the cache.Quote if you modify the admin menu, you'll need to manually remove the cache file, or run clean_cache('css', 'admenu') through a hook or something.
As for the loadBlock stuff, it's going to have to wait until tomorrow. I noticed another bug in the index rebuilder -- if it's called more than once, it erases the skeleton :(
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
It's only an icon cache... I'm caching ALL of the icons in the array, regardless of whether they can be shown to the user. Small enough anyway.
I still haven't looked at the code, but I really hope it's checking whether it's a URL or not, because otherwise it's likely to be calling for a plugin's icon(s) through an external URL request only to be served locally... (I couldn't see any way of passing just a filename to the menu builder and for it to be able to cope with it, so the menu builder looks to see if it's a URL or not, and if not, serves it from the theme as normal)
Nao
- Dadman with a boy
-
-
- Posts: 16,082
That's the thing. It checks for urls first. Meaning this is never a real problem.
Holy fuck I'm stuck to bed for now. My legs hurt horribly after a ridiculous attempt to ahem, jog...
Holy fuck I'm stuck to bed for now. My legs hurt horribly after a ridiculous attempt to ahem, jog...
Arantor
-
-
- As powerful as possible, as complex as necessary.
- Posts: 14,278
Jogging is harsh :/
Anything in particular you'd like me to look over in r1049 since you flagged it as wanting feedback?
Also, I've committed the RelaxNG spec I've been referring to. It should validate current plugin-info.xml files - that should cover everything currently supported in the plugin manager, as well as validating new columns and indexes for existing tables, which is currently not supported.
Anything in particular you'd like me to look over in r1049 since you flagged it as wanting feedback?
Also, I've committed the RelaxNG spec I've been referring to. It should validate current plugin-info.xml files - that should cover everything currently supported in the plugin manager, as well as validating new columns and indexes for existing tables, which is currently not supported.
Although, I'm getting pretty fed up when one tool validates both my RNG schema and a big scary file against it but PHP's XMLReader won't because of 'Extra element database in interleave' when there really isn't - and, just for fun, if I comment out the <tables> construct inside <database>, it works as expected :/
I figured out the problem with the above, mostly it's because libxml2 is more strict than <oXygen/> XML editor is.
For those who've written a plugin thus far, you can crudely test it with:
Code: [Select]
Note that you set the schema after you load the document, as opposed to the more traditional approach of stating the schema actually in the file like you would through a DOCTYPE.
For those who've written a plugin thus far, you can crudely test it with:
<?php
$schema = '/path/to/other/plugin-info.rng';
$document = '/path/to/plugin-info.xml';
$xml_reader = new XMLReader();
$xml_reader->open($document);
$xml_reader->setRelaxNGSchema($schema);
$valid = true;
while ($xml_reader->read())
if (!$xml_reader->isValid())
$valid = false;
var_dump($valid);
?>Note that you set the schema after you load the document, as opposed to the more traditional approach of stating the schema actually in the file like you would through a DOCTYPE.