Poll

Recycle bin or inline moderation?

recycle
22 (50%)
inline
12 (27.3%)
Don't care
7 (15.9%)
Don't know
3 (6.8%)
Total Members Voted: 42

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #15, on January 28th, 2011, 01:28 PM »
Hmm. I still have no better ideas on implementing this other than what I originally implemented.

I think I'm going to go ahead and implement as originally mentioned (i.e. a new install creates a recycle board by default), close this topic and then see if inspiration strikes.

I know Nao commented above, but I found it just didn't work in practice :( It just gets too unwieldy to keep managed and is the source of at least two bugs in SD 1.0 that were fixed post release.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #16, on January 28th, 2011, 01:32 PM »
I'll trust your judgment. Just try and fix my bugs in the future ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #17, on January 28th, 2011, 01:34 PM »
Heh :P

I'm going on the usability experience I found of doing it that way - and honestly I think more people relate to the concept of a recycle bin-as-board much better than trying to do it inline, or something else. Maybe we could make the usage of ids and so on a little more elegant but the general process seems pretty logical for users.

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #19, on January 28th, 2011, 06:49 PM »
Quote from Arantor on January 28th, 2011, 01:34 PM
Heh :P
BTW what's going to happen when all newly created Wedge forums get this in their board list?

1. My first board
3. My second board

"Hey man, where has id_board #2 gone?!
- Err... I don't know, I'm not a specialist. I just created my boards is all.
- Tis the apocalypse!! We're all gona DIE!!!!111"

(What, I already did that one? 'kay..)
Quote
I'm going on the usability experience I found of doing it that way - and honestly I think more people relate to the concept of a recycle bin-as-board much better than trying to do it inline, or something else. Maybe we could make the usage of ids and so on a little more elegant but the general process seems pretty logical for users.
I don't know what you mean, but what I know is that I've never liked seeing several topics created when you delete several posts in a row from a same topic. Topic IDs are precious. Don't waste them. These posts should be integrated into the recycled topic all the same.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #20, on January 28th, 2011, 11:01 PM »
In that case, how about we get funky and make the recycled board 0 (since there's no technical reason I'm aware of that prevents it)? Or, failing that, 65535 and reset the board id back to 2 thereafter.
Quote
I don't know what you mean, but what I know is that I've never liked seeing several topics created when you delete several posts in a row from a same topic. Topic IDs are precious. Don't waste them. These posts should be integrated into the recycled topic all the same.
There is one reason to avoid it: it's possible to end up losing state and theoretically the original topic. We did this in SimpleDesk originally, had it working reasonably well but it ended up with the situation whereby deleting every post in a ticket would move to a new ticket but if you later reinstated the ticket there were consistency issues with the topic id being reinstated later, but I didn't write it and I don't remember what the issue was. I just remember spending a day staring at it, as we were approaching the deadline we'd set ourselves for release and I ended up ditching it entirely and rewriting from scratch to what you see now.

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #21, on February 14th, 2011, 07:16 PM »Last edited on February 14th, 2011, 07:22 PM by Nao/Gilles
Quote from Arantor on January 28th, 2011, 11:01 PM
In that case, how about we get funky and make the recycled board 0 (since there's no technical reason I'm aware of that prevents it)?
I just looked into that.
I replaced with 0, and it said "duplicate primary key 1"; basically, MySQL considered the '0' to be '1'.
I could make sure it accepts 0, but then I get this warning:
http://dev.mysql.com/doc/refman/5.0/en/server-sql-mode.html#sqlmode_no_auto_value_on_zero
Basically, they don't recommend using 0 as a valid value.

What do you think...?
Quote
Or, failing that, 65535 and reset the board id back to 2 thereafter.
Is 65535 the maximum value? I hope it isn't, if we want users to be able to create their own blogs on a board... :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #22, on February 14th, 2011, 07:23 PM »
Yes, 65535 is the maximum value as it's an unsigned smallint column.

Maybe I should sit down and map the schema sometime so we can see where the column gets replicated to (off the top of my head, id_board is used as a foreign key in: messages, boards, members as a comma sep. value, board permissions)

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #23, on February 14th, 2011, 07:35 PM »
OTOH, if someone has enough members to have 65k+ blogs/forums on their install, they're BOUND to know about MySQL and stuff, and they'll be able to deal with that by themselves, because they'll have studied what limits Wedge/SMF have for huge websites... (I suppose.)

But what about my first question?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #24, on February 14th, 2011, 07:38 PM »
Hmm, you're right about the recycle board 0 business.

Guess it might be time to consider something else?

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #25, on February 14th, 2011, 08:07 PM »
It's technically possible. Anything preventing us from going forward?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Recycling board by default
« Reply #26, on February 14th, 2011, 08:38 PM »
I'm not overly keen on having errors, so having 0 seems out, but if 65535 is still viable, then we can use that provided there's a suitable ALTER TABLE after it.

Nao

  • Dadman with a boy
  • Posts: 16,063

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Recycling board by default
« Reply #29, on February 14th, 2011, 09:27 PM »
Link says how to fix the error but says it's not recommended. I just don't know why.