New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2445, on February 9th, 2014, 10:18 PM »
[Commit revision 79e58f0]
Author: Nao
Date: Sun, 09 Feb 2014 22:18:05 +0100
Stats: 4 files changed; +42 (insertions), -43 (deletions)

  • Merged both license files together for simplicity (and a cleaner repo), and updated README.md and contributors.txt to match the change. No licenses were harmed in the process. (README.md, LICENSE, contributors.txt)
Re: New revs
« Reply #2446, on February 10th, 2014, 07:44 AM »
[Commit revision e68248d]
Author: Nao
Date: Mon, 10 Feb 2014 07:44:25 +0100
Stats: 1 file changed; +0 (insertion), -1 (deletion)

  • Removed an erroneous copyright credit for Wess, which has absolutely *zero* code taken from SMF. As I expected, that's the risk when you do mass additions, even after two thorough checks. You get tired and you forget a file or two. Thanks to Spuds for pointing out this one! (Class-CSS.php)
Re: New revs
« Reply #2447, on February 10th, 2014, 11:51 AM »
[Commit revision 2b8b676]
Author: Nao
Date: Mon, 10 Feb 2014 11:51:15 +0100
Stats: 1 file changed; +2 (insertions), -1 (deletion)

  • Added self-references to Wess variables. In other words: up until now, whenever you redefined a variable, you couldn't re-use its existing value inside the definition. Now you can. In yet other words: `$big_font = "Segoe UI", $big_font` is now possible in a sub-skin if you want to add a new default font but want to keep the existing font stack as a fallback. Okay, are we good now? ;) (Class-CSS.php)
Re: New revs
« Reply #2448, on February 11th, 2014, 10:21 AM »
[Commit revision 09007c2]
Author: Nao
Date: Tue, 11 Feb 2014 10:20:47 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)

  • Sortable classes don't need to be limited in width. It looks bad on some pages, and fixing it didn't break anything I could see. (I thought I'd already committed this...) (mana.css)
  • Adding a separator between 'no group' and the group list in the profile groups page. Technically, I should be adding more separators. They look good, and I'm barely using them in a dozen places in Wedge at this point (e.g. stats select boxes.) (Profile.template.php)
Re: New revs
« Reply #2449, on February 11th, 2014, 07:13 PM »
[Commit revision ad44a98]
Author: Nao
Date: Tue, 11 Feb 2014 10:22:10 +0100
Stats: 1 file changed; +5 (insertions), -3 (deletions)

  • Notifications text update. Already in the languages repo. (Notifications.english.php)

[Commit revision 61b1aa4]
Author: Nao
Date: Tue, 11 Feb 2014 19:13:01 +0100
Stats: 2 files changed; +3 (insertions), -3 (deletions)

  • Hmm, this *should* fix the incorrect default skin updates in the skin management page. Sorry about that... (Themes.php, Themes.template.php)
Re: New revs
« Reply #2450, on February 12th, 2014, 10:35 AM »
[Commit revision 40c1bdf]
Author: Nao
Date: Wed, 12 Feb 2014 10:35:24 +0100
Stats: 2 files changed; +11 (insertions), -6 (deletions)

  • PayPal subscriptions were completely, horribly, awfully broken. Took me two days to find out it was a frigging underscore replacing a dash during a rewrite (not mine). Thanks to Maxx and MultiformeIngegno for their multiple fake-donations that allowed me to finally spot it! (Subscriptions-PayPal.php)
  • Added some extra error messages in places where the PayPal subscription verification was unsuccessful. (Subscriptions-PayPal.php, ManagePaid.english.php)
Re: New revs
« Reply #2451, on February 12th, 2014, 11:45 PM »
[Commit revision 9de68b7]
Author: Nao
Date: Wed, 12 Feb 2014 23:33:24 +0100
Stats: 3 files changed; +4 (insertions), -3 (deletions)

  • Added a 'style' variable to admin setting lists. It will basically allow you to customize the <dl> that encloses your setting. I needed it in one place, but I suspect it might be helpful in other occasions. (Admin.template.php)
  • Fixed select box drop downs being cut off in membergroup badge settings. Not my bug. (ManageMembergroups.php)
  • Fixed invalid HTML. Not my bug. (ManageMembergroups.template.php)

[Commit revision af2d910]
Author: Nao
Date: Wed, 12 Feb 2014 23:45:04 +0100
Stats: 1 file changed; +11 (insertions), -13 (deletions)

  • Fixed badges being shown after another badge even when set to "show only when no other badge is shown". This was due to $user_profile[$id]['badges'] being tested against in a loop, when at this point it was *explicitly* empty. $badges was the actual target of that test. Not my bug. (Load.php)
Re: New revs
« Reply #2452, on February 13th, 2014, 07:08 PM »
[Commit revision 4d2a78a]
Author: Nao
Date: Thu, 13 Feb 2014 14:54:53 +0100
Stats: 11 files changed; +32 (insertions), -32 (deletions)

  • Renamed Class-DBPackages to Class-DBHelper, and wedbPackages to just wedb. It's better to simplify names and the 'wedb' class wasn't used anyway, so why add a reference to a feature that was removed from Wedge long ago..? (Class-DBHelper.php, ManageMaintenance.php, ManagePlugins.php, ManageSearch.php, ManageSearchEngines.php, ManageSmileys.php, ScheduledTasks.php, SearchAPI-Custom.php, Subs-Admin.php, Subs-Plugins.php, install.php)

[Commit revision 77226ee]
Author: Nao
Date: Thu, 13 Feb 2014 19:08:27 +0100
Stats: 1 file changed; +2 (insertions), -1 (deletion)

  • Fixed groups without badges still taking precedence over groups with badges, resulting in badges not showing up when they should. (Load.php)
Re: New revs
« Reply #2453, on February 14th, 2014, 12:38 AM »
[Commit revision a3602d9]
Author: Nao
Date: Fri, 14 Feb 2014 00:38:34 +0100
Stats: 1 file changed; +4 (insertions), -3 (deletions)

  • Default Theme selectors were showing the wrong default values when loading the theme management page. (Themes.template.php)
Re: New revs
« Reply #2454, on February 16th, 2014, 11:01 PM »
[Commit revision 005ce99]
Author: Nao
Date: Sun, 16 Feb 2014 22:51:11 +0100
Stats: 6 files changed; +16 (insertions), -24 (deletions)

  • English typo. Also removing more file versions I forgot to commit. (ManageBans.english.php, Media.english.php, Security.english.php)
  • Saving milliseconds on scrolling in topic pages. I was hoping it would help make it possible to enable follow_me on mobile, but its performance still sucks on Android. I'm not sure why. (topic.js)
  • A more compact (and cleaner) version of the gravatar loading code. (Load.php)
  • Commenazi. (Subs.php)

[Commit revision 543289e]
Author: Nao
Date: Sun, 16 Feb 2014 22:56:21 +0100
Stats: 1 file changed; +5 (insertions), -23 (deletions)

  • As much as I love Apache 2.2.16+'s FallbackResource directive, it fails to work when your forum is installed in a sub-folder. If you want (slightly) better performance, you'll have to manually replace the Pretty URLs section of .htaccess with "FallbackResource /forum/index.php", where 'forum' is the name of your sub-folder, of course. Or just /index.php if it's not in a sub-folder. I'm not taking that chance again. (install/.htaccess)
  • Also, as a reminder... The .htaccess file really should be moved to your root folder. I don't want to move it to the root directly from the repo because you might want to edit the file for your own sake, so... Well, it's a complicated matter.
Re: New revs
« Reply #2455, on February 16th, 2014, 11:07 PM »
[Commit revision c39fcc6]
Author: Nao
Date: Fri, 14 Feb 2014 16:37:50 +0100
Stats: 2 files changed; +30 (insertions), -33 (deletions)

  • In Subscription management pages, changing the day wouldn't update it in the select box (thanks to @live627 for the original PR). (ManagePaid.template.php)
  • In the same place, fixed day being reset to 1 if the last day was selected and the user switched to another month with the same number of days.
  • Also, a more generateDays() function.
  • Minor improvements to layout and bracket-nazi in ManagePaid pages. (ManagePaid.php, too.)
:edit: This is a re-submitted older push. GitHub now allows me to get a list of the pushes that failed to communicate with the GitHub plugin, so until I get a more solid version of the plugin out, this will have to do!
Re: New revs
« Reply #2456, on February 16th, 2014, 11:09 PM »
[Commit revision 2f5c4ca]
Author: Nao
Date: Fri, 14 Feb 2014 16:48:48 +0100
Stats: 1 file changed; +18 (insertions), -0 (deletion)

  • Added helper functions query_all and query_rows to the wesql class; they'll just do the entire SQL communication process for you. If you have a quick query you want to do, sometimes it's not worth bothering with the free_result that comes after it, but I'm still a bit attached to that... (Class-DB.php)

[Commit revision a0abedc]
Author: Nao
Date: Fri, 14 Feb 2014 16:52:40 +0100
Stats: 1 file changed; +23 (insertions), -27 (deletions)

  • Simplified wedb's handling of default column values. Moved everything to a function, wedb::escape_default, that will also test whether the default is an integer. While it doesn't matter in most cases that you specify it as an int or a string, in the particular case of bit(1), it can actually break your query to have a '0' default, so... I had to do all this just to have a default 0 instead. (Class-DBHelper.php)

[Commit revision def73d3]
Author: Nao
Date: Fri, 14 Feb 2014 22:13:44 +0100
Stats: 1 file changed; +4 (insertions), -0 (deletion)

  • 'New' icons in topic pages didn't have enough margin on the left. (index.css)
  • Your gravatars were distorted in the sidebar, due to them having a fixed height, taking precedence over the CSS. Thanks to @Xarcell, @eurich and Bunstonious for the report! (index.css)
:edit: Another push that wasn't properly processed.
Re: New revs
« Reply #2457, on February 17th, 2014, 04:23 PM »
[Commit revision d911448]
Author: Nao
Date: Mon, 17 Feb 2014 16:13:25 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed the JS toggler, which had been broken for guests for a year now. Apparently, nobody ever noticed... Oops :) (script.js)
Re: New revs
« Reply #2458, on February 17th, 2014, 11:32 PM »
[Commit revision 52e4686]
Author: Nao
Date: Mon, 17 Feb 2014 23:31:56 +0100
Stats: 10 files changed; +97 (insertions), -39 (deletions)

  • Added upgrade tool to Wedge. This will automatically upgrade your database and files to what's currently expected. I'm not exactly sure what to do if two users are simultaneously running the upgrade script, as I'm not versed into multi-tasking, but... Well, if you have a suggestion on the nicest way to prevent that... (index.php, Upgrade.php)
  • Which also means that I can celebrate by upping Wedge's version number from 0.1 to... 1.0, alpha 1. I'm not saying it's usable in production. I'm just saying we're getting closer to that. (index.php, changelog.txt)
  • Added hey_not and hey_pm variables; these flags are set if you have new notifications (or PMs) and you haven't opened the notification popups yet. Basically, they control the notification button colors (orange or gray). (Class-Notification.php, Notifications.php, PersonalMessage.php, Subs-Post.php, Upgrade.php, index.template.php, install.sql)
  • Root, source and plugin folders are now checked for existence within index.php, like the rest, rather than the settings file. Settings should only hold settings. (index.php, OriginalFiles.php)
  • Tweaked the Settings.php automatically generated at install time. (OriginalFiles.php)
  • Note: you may want to edit your Settings.php file to remove the multiple file_exists tests after "Make sure the paths are correct"... Really, it'll save your server some time.
Re: New revs
« Reply #2459, on February 17th, 2014, 11:46 PM »
[Commit revision d8f0e00]
Author: Nao
Date: Mon, 17 Feb 2014 23:46:04 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Last-minute typo™. Is important enough to warrant a push. (Upgrade.php)