New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2430, on February 3rd, 2014, 11:30 PM »
[Commit revision ef08042]
Author: Nao
Date: Mon, 03 Feb 2014 23:30:08 +0100
Stats: 7 files changed; +23 (insertions), -18 (deletions)

  • Finished patching with what I could find from 2.0.7 that made sense to backport. (Class-String.php, Login2.php, ManageMembergroups.php, Modlog.php, Subs-Members.php, Subs-Post.php)
  • Cleaning up. (Subs-Auth.php)
  • Putting thought into replacing tons of custom entity-replacement functions with generic ones, and then forgetting to remove the custom ones? Check. Adding comments about PHP 5.3 supporting the 'uses' keyword when it's actually 'use'? Check. Declaring and using a function with a neat typo in its name? Check. Providing a Themes.template.php~ file in all of their official download packages? Check. Definitely one of SMF's finest patches.
Re: New revs
« Reply #2431, on February 3rd, 2014, 11:58 PM »
[Commit revision 13ce79c]
Author: Nao
Date: Mon, 03 Feb 2014 23:58:20 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • This should fix shadow Likes showing up on soft-merged posts when clicking Like on the first post in the list. (topic.js)
Re: New revs
« Reply #2432, on February 4th, 2014, 03:49 PM »
[Commit revision e044b10][1]
Author: Nao
Date: Tue, 04 Feb 2014 15:44:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Undefined index when truncating the board table. (Subs-BoardIndex.php)

[Commit revision 4bb13a6][2]
Author: Pandos (Signed-off)
Date: Thu, 30 Jan 2014 09:33:39 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Imagick::getImageSize is deprecated. Imagick::getImageLength should be used instead.
 1. That was my 180th commit in a row, SVN-style. Obviously my record, but a very useless one! :lol:
 2. And Pandos's first commit to mainline Wedge ;)
Re: New revs
« Reply #2433, on February 4th, 2014, 04:25 PM »
[Commit revision 017ece5]
Author: Nao
Date: Tue, 04 Feb 2014 16:16:44 +0100
Stats: 2 files changed; +5 (insertions), -8 (deletions)

  • Readme update. (README.md)
  • Spacinazi. (subscriptions.php)
Re: New revs
« Reply #2434, on February 4th, 2014, 10:15 PM »
[Commit revision f35e99e]
Author: Nao
Date: Tue, 04 Feb 2014 22:00:46 +0100
Stats: 1 file changed; +28 (insertions), -24 (deletions)

  • Fixed 'board' variables overriding other actions in the URL if specified in numeric form (e.g. action=something;board=1). (QueryString.php)

[Commit revision 34210fe]
Author: Nao
Date: Tue, 04 Feb 2014 22:10:50 +0100
Stats: 1 file changed; +6 (insertions), -6 (deletions)

  • Hopefully fixed broken link in moderation center. I never use that, err... Thing. (PostModeration.php)
Re: New revs
« Reply #2435, on February 5th, 2014, 12:03 PM »
[Commit revision dfd9b01]
Author: Nao
Date: Wed, 05 Feb 2014 12:01:55 +0100
Stats: 1 file changed; +8 (insertions), -6 (deletions)

  • Main menu icons will now link to their neighbor's location, instead of simply closing the menu without doing anything else. Adds about 30 gzipped bytes of JS but that's better than adding more links on every HTML page. (script.js)
  • Fixed menu closing 'delay' not happening when the mouse left the menu around the vicinity of a tab list. Which, technically, isn't a menu of course, but shares some of its CSS, so it was confusing to Wedge. (script.js)
  • Increased said menu closing delay by 50ms. Not much for your convenience, but close to the acceptable limit to me. (script.js)
Re: New revs
« Reply #2436, on February 5th, 2014, 03:14 PM »
[Commit revision 3e0b227]
Author: Nao
Date: Wed, 05 Feb 2014 15:13:54 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • $reencode_sensitive wasn't properly kept in scope. (Class-String.php)
  • Fixed a bug in the plugin installer -- a dash-separated XML variable was referred to by an underscore instead. (Subs-Plugins.php)
Re: New revs
« Reply #2437, on February 6th, 2014, 12:41 AM »
[Commit revision 7df6fcf]
Author: Nao
Date: Thu, 06 Feb 2014 00:40:58 +0100
Stats: 5 files changed; +29 (insertions), -24 (deletions)

  • large_text and multi_select needed to use underscores, not dashes. I could probably fix it the other way around, but whatever. Feedback welcome. If you don't know what these are, for instance large_text is used to show a textarea in your plugin's admin page. (ManageSettings.php)
  • More bugs similar to the one in Subs-Plugins.php. (ManagePlugins.php)
  • redirectexit() shouldn't try to prettify external URLs. Well, duh. (Subs.php)
  • Plugin homepage layout tweak. (ManagePlugins.template.php, mana.css)
Re: New revs
« Reply #2438, on February 6th, 2014, 06:36 PM »
[Commit revision 5ffe11d]
Author: Nao
Date: Thu, 06 Feb 2014 16:01:31 +0100
Stats: 1 file changed; +41 (insertions), -44 (deletions)

  • Fixed news header not being styled. This is because $context['random_news_line'] was only filled in after the CSS was parsed at all... (index.css)
  • Various CSS tweaks: don't set border-radius if $radius is set to 0. Put the proper text color in #wedge, rather than #content. Some margin and alignment hacks, too. (index.css)

[Commit revision cf84467]
Author: Nao
Date: Thu, 06 Feb 2014 18:25:23 +0100
Stats: 4 files changed; +17 (insertions), -81 (deletions)

  • Reverted most of the changes from 422595b (January 8) with the session-based cache. The first implementation lasted a couple of days until I saw its limits. The second implementation lasted a month before it started to show bugs. I spent a day on it, couldn't fix much of it, decided, what the hell, it was only 5% faster. Maybe there will be a third implementation, but I wouldn't count on it too much. Stick to file-based caching, it's still the most consistently stable and efficient cache system for Wedge. Even my work on a database-based cache was too disappointing to further explore. (Load.php, ManageServer.php, Subs-Cache.php, ManageSettings.english.php)

[Commit revision d0229b3]
Author: Nao
Date: Thu, 06 Feb 2014 18:36:02 +0100
Stats: 2 files changed; +5 (insertions), -15 (deletions)

  • I believe it's the first time I'm using a lambda function to emulate cache_put_data... Well, it shows you how it's done! (Subs-Boards.php)
  • 6 lines into 1. That's better. For my OCD at least. (Subs-Cache.php)
Re: New revs
« Reply #2439, on February 7th, 2014, 12:23 AM »
[Commit revision 3231132]
Author: Nao
Date: Thu, 06 Feb 2014 23:20:25 +0100
Stats: 6 files changed; +56 (insertions), -16 (deletions)

  • Added notifications for Thought likes. (Like.php, Notifications.php, notifiers/Likes.php, Notifications.template.php, Notifications.english.php, script.js)
  • Seriously, 6 files and lots of code just for a tweak to the Post Like code...? It seems like overkill to me, but I've been unable to find a cleaner way to do it. Meh...

Posted: February 6th, 2014, 11:20 PM

[Commit revision c0db789]
Author: Nao
Date: Fri, 07 Feb 2014 00:08:19 +0100
Stats: 2 files changed; +1 (insertion), -5 (deletions)

  • Fixed undefined index error. Hopefully. (notifiers/Likes.php)
  • Minor revert for a syntax error, and a styling issue. (index.css)

Posted: February 7th, 2014, 12:08 AM

[Commit revision a54e87f]
Author: Nao
Date: Fri, 07 Feb 2014 00:14:22 +0100
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Just because a notification has no preview doesn't mean it shouldn't be harder to dismiss... (script.js)

Posted: February 7th, 2014, 12:15 AM

[Commit revision de470ad]
Author: Nao
Date: Fri, 07 Feb 2014 00:23:10 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • Apologies for the bad fix, I'm very tired. And ill. This one should work better. (script.js)
Re: New revs
« Reply #2440, on February 8th, 2014, 12:24 PM »
[Commit revision b01e5dc]
Author: Nao
Date: Fri, 07 Feb 2014 19:32:05 +0100
Stats: 1 file changed; +5 (insertions), -13 (deletions)

  • Fixing wrong Reply links on blog homepages. (MessageIndex.template.php)
  • Moving board/blog descriptions to the top of their homepages, rather than below the sub-board list. (MessageIndex.template.php)
Re: New revs
« Reply #2441, on February 8th, 2014, 10:51 PM »
[Commit revision 580c48e]
Author: Nao
Date: Sat, 08 Feb 2014 18:29:03 +0100
Stats: 4 files changed; +5 (insertions), -12 (deletions)

  • Removing some package-related strings, even though their contents implied they were used in plugin code. (ManageSmileys.php, Themes.php, Errors.english.php)

[Commit revision 12ef33c]
Author: Nao
Date: Sat, 08 Feb 2014 18:29:18 +0100
Stats: 2 files changed; +1 (insertion), -2 (deletions)

  • Assets URL wasn't properly implemented in membergroup badge setter. (ManageMembergroups.template.php, ManageMembers.english.php)



Note: this is kinda annoying... I noticed that my latest push wasn't in the list. I'm guessing GitHub was met with a timeout when they pushed to my webhook, thus forcing me to go to the website, settings, and 'test hook' to re-submit the latest push. I have no idea how to deal with that, honestly... (??)
Perhaps I should, when pushed to, reply with a request to get all latest commits, and then keep a list of these commits in memory. That'd force me to re-create the DB table I'd happily removed recently when I turned my plugin into a webhook... :-/ :-/ Any opinions? (On another topic, of course. Sorry.)
Re: New revs
« Reply #2442, on February 9th, 2014, 04:30 PM »
[Commit revision f1fa3e5]
Author: Nao
Date: Sun, 09 Feb 2014 09:14:02 +0100
Stats: 1 file changed; +66 (insertions), -403 (deletions)

  • Removed lots of helper functions that are no longer used in Wedge: copytree, listtree, deltree, package_get_contents, and removed all package cache code (it sucks, perhaps not for FTP or something, but that was removed by Pete a year ago, so...) (Subs-Package.php)
  • SMF bug in passing (it doesn't concern Wedge since the code was removed, so I didn't test this in action either): "if we're on a Windows server (okay), or package cache is explicitly disabled (yeah), or we managed to set RAM queries to 128MB (YEAH!), then DISABLE the RAM-consuming package cache." It's been in their codebase for years, and even modified several times... Everytime keeping the same logic. I don't know about you, but if their codebase never runs that package cache, why do they have it at all..?

[Commit revision 4308a39]
Author: Nao
Date: Sun, 09 Feb 2014 13:47:26 +0100
Stats: 3 files changed; +3 (insertions), -2 (deletions)

  • Fixed duplicate txt string and added own 'settings' string to membergroups, allowing to point out that you can also set badge settings there, until I get around to splitting them into their own page, because I think they deserve it... (Admin.php, Admin.english.php, ManageMembers.english.php)
Re: New revs
« Reply #2443, on February 9th, 2014, 04:59 PM »
[Commit revision 62d34d1]
Author: Nao
Date: Sun, 09 Feb 2014 16:58:53 +0100
Stats: 5 files changed; +11 (insertions), -17 (deletions)

  • Properly aligning language select boxes in the antispam admin area. (ManageSettings.php)
  • Details. (ManagePlugins.php, Subs-Plugins.php, InfoCenter.template.php)
  • Forgot to remove a package_flush_cache() call. In a function I'll be removing soon anyway, hmm... (Themes.php)
Re: New revs
« Reply #2444, on February 9th, 2014, 08:36 PM »
[Commit revision 46f8f6e]
Author: Nao
Date: Sun, 09 Feb 2014 20:23:52 +0100
Stats: 174 files changed; +697 (insertions), -698 (deletions)

  • The mandatory legal update. This restores the copyright notice that Pete removed back in 2011, and keeps it minimalist, while still respecting the BSD license terms. (174 files. There are a few left, which will be in a less boring future commit.)

[Commit revision f88fee6]
Author: Nao
Date: Sun, 09 Feb 2014 20:35:35 +0100
Stats: 66 files changed; +309 (insertions), -401 (deletions)

  • Removed theme.js file, which I forgot to delete after removing theme features. If you need to add custom JS, the filename should be 'custom.js'... Alrighty? :) (index.template.php, theme.js)
  • Removed JSOption.php and JSEditor.php, they're now handled through Ajax.php. (index.php, JSOption.php, JSEditor.php, Subs-BBC.php, Admin.template.php, script.js, editor.js)
  • Renamed JSModify.php to QuickEdit.php, along with its URL action. (index.php, QuickEdit.php)
  • End of the file cleanup operation. Tired. (Dozens of files.)